From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.59098.1594045674391096659 for ; Mon, 06 Jul 2020 07:27:54 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: thomas.abraham@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F01F3C0A for ; Mon, 6 Jul 2020 07:27:52 -0700 (PDT) Received: from mail-il1-f175.google.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DADA13F7B4 for ; Mon, 6 Jul 2020 07:27:52 -0700 (PDT) Received: by mail-il1-f175.google.com with SMTP id r12so25841534ilh.4 for ; Mon, 06 Jul 2020 07:27:52 -0700 (PDT) X-Gm-Message-State: AOAM532slMBuWufNa/2FjRiuk2p4NiucbuuaiQrbjbiyuKJkud/TY6Aq FCREdwX4JsM+7Hv8Nb3fuXgDNP4ncuSMfoq2jvM= X-Google-Smtp-Source: ABdhPJyWLEj2V6Lm33jRkElBWgWFVTVOuU6LHAws0mz2Ku/NLmmZ/qaxpmWAdPwpM4GM0WaTxGRXmUV9etkiIZ/x4MY= X-Received: by 2002:a92:c213:: with SMTP id j19mr30940440ilo.40.1594045664436; Mon, 06 Jul 2020 07:27:44 -0700 (PDT) MIME-Version: 1.0 References: <1593775136-17859-1-git-send-email-pranav.madhu@arm.com> In-Reply-To: <1593775136-17859-1-git-send-email-pranav.madhu@arm.com> From: "Thomas Abraham" Date: Mon, 6 Jul 2020 19:57:33 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-platforms][PATCH v3 0/4] Platform: Add initial support for N1SDP board To: devel@edk2.groups.io, pranav.madhu@arm.com Cc: Ard Biesheuvel , Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Fri, Jul 3, 2020 at 4:49 PM Pranav Madhu wrote: > > Changes since v2: > - Addressed comments from Thomas. > - Renamed Silicon/ARM/N1SDP to Silicon/ARM/NeoverseN1Soc. > > Changes since v1: > - Addressed comments from Ard. > - Split the code between Silicon and Platform directories. > > Arm's N1SDP is a Arm v8.2-A Neoverse N1 CPU based reference design platform > primariliy intended for development on Arm64 based platform. This patch series > adds initial platform support for this board. > > The first patch in this series adds the platform libary implementation. The > second patch adds a custom implementation of the PciExpressLib due to a PCIe > integration issue which results in all config space accesses to non-existing > BDFs resulting in a Serror (bus abort). To avoid this, the N1SDP specific > PciExpressLib implementation provides a workaround for this issue. The third > patch in this series adds the platform library for the PciHostBridge. The > fourth patch adds the initial platform support for the N1SDP platform. > > Deepak Pandey (4): > Silicon/ARM/N1SoC: Add platform library implementation > Silicon/ARM/N1SoC: Implement Neoverse N1 Soc specific PciExpressLib > Silicon/ARM/N1SoC: Implement the PciHostBridgeLib library > Platform/ARM/N1SDP: Add initial N1SDP platform support For this series: Reviewed-by: Thomas Abraham > > Silicon/ARM/NeoverseN1Soc/NeoverseN1SocPlatform.dec | 46 + > Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 245 ++++ > Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 294 ++++ > Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/NeoverseN1SocPciExpressLib.inf | 39 + > Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 49 + > Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.inf | 54 + > Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1SocPlatform.h | 68 + > Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/NeoverseN1SocPciExpressLib.c | 1545 ++++++++++++++++++++ > Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c | 187 +++ > Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c | 67 + > Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c | 152 ++ > Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/AArch64/Helper.S | 84 ++ > 12 files changed, 2830 insertions(+) > create mode 100644 Silicon/ARM/NeoverseN1Soc/NeoverseN1SocPlatform.dec > create mode 100644 Platform/ARM/N1Sdp/N1SdpPlatform.dsc > create mode 100644 Platform/ARM/N1Sdp/N1SdpPlatform.fdf > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/NeoverseN1SocPciExpressLib.inf > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.inf > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.inf > create mode 100644 Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1SocPlatform.h > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/NeoverseN1SocPciExpressLib.c > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c > create mode 100644 Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/AArch64/Helper.S > > -- > 2.7.4 > > > ------------ > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#62019): https://edk2.groups.io/g/devel/message/62019 > Mute This Topic: https://groups.io/mt/75274945/1785013 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ta.omasab@gmail.com] > ------------ >