From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 3B336211D07B2 for ; Mon, 11 Mar 2019 06:56:37 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F25F41688 for ; Mon, 11 Mar 2019 06:56:36 -0700 (PDT) Received: from mail-it1-f178.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D93273F703 for ; Mon, 11 Mar 2019 06:56:36 -0700 (PDT) Received: by mail-it1-f178.google.com with SMTP id e24so7370249itl.1 for ; Mon, 11 Mar 2019 06:56:36 -0700 (PDT) X-Gm-Message-State: APjAAAUiO6VppZWTF8euX9+ol9yGkEuYxHAnv6bwsJgKxi6hBGN7GZm1 UfVc2IH+gGJOL0uvGaEHfSYQlcGjCkQd4cHQB1k= X-Google-Smtp-Source: APXvYqwNmSIVNN70MJD4HzvKsVfOvlN9lrZo4yc+zucmH+UOjVEivndRgJerIMy7RwagvN9pZ+N6b0IW3oZVMDqFbso= X-Received: by 2002:a24:7a85:: with SMTP id a127mr16496605itc.46.1552312596061; Mon, 11 Mar 2019 06:56:36 -0700 (PDT) MIME-Version: 1.0 References: <20190308153010.18486-1-ard.biesheuvel@linaro.org> In-Reply-To: From: Thomas Abraham Date: Mon, 11 Mar 2019 19:26:24 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms 1/2] Platform/ARM/SgiPkg: align with upstream StandaloneMmPkg changes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 13:56:37 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, Mar 11, 2019 at 7:09 PM Ard Biesheuvel wrote: > > On Mon, 11 Mar 2019 at 14:31, Thomas Abraham wrote: > > > > On Fri, Mar 8, 2019 at 9:01 PM Ard Biesheuvel wrote: > > > > > > Bring SgiPkg in line with EDK2 core changes to StandaloneMmPkg: > > > - add a resolution for ExtractGuidedSectionLib > > > - remove reference to gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable > > > - update the resolution of StandaloneMmDriverEntryPoint > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Ard Biesheuvel > > > --- > > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > index 65dd6ac82c4a..ef16bfa9a20e 100644 > > > --- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > @@ -43,6 +43,7 @@ > > > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > > > + ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf > > > > The build fails with the following error > > > > /home/thopan01/devel/sgi/sgi-dev/uefi/edk2/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c:37: > > undefined reference to `memcpy' > > /tmp/ccOj5Ie6.ltrans0.ltrans.o: In function > > `ExtractGuidedSectionLibConstructor': > > /home/thopan01/devel/sgi/sgi-dev/uefi/edk2/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c:233: > > undefined reference to `memcpy' > > collect2: error: ld returned 1 exit status > > > > I will check further why the build fails here. > > > > We need to add this in the .dsc > > # > # It is not possible to prevent the ARM compiler for generic > intrinsic functions. > # This library provides the instrinsic functions generate by a given compiler. > # And NULL mean link this library into all ARM images. > # > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf Thanks, it works with this change. So with this change rolled into this patch. Reviewed-by: Thomas Abraham