Re: [PATCH v3 0/6] ArmPkg related changes for StandaloneMM package

From: Thomas Abraham <thomas.abraham@arm.com>
To: sughosh.ganu@arm.com
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	edk2-devel@lists.01.org
Subject: Re: [PATCH v3 0/6] ArmPkg related changes for StandaloneMM package
Date: Wed, 21 Nov 2018 21:31:31 +0530	[thread overview]
Message-ID: <CAJuA9aj7rG_GA7=zqR2bEE53QYpoOm=6ZDv=wZuUbGC9Omcf3A@mail.gmail.com> (raw)
In-Reply-To: <20181119050045.GA4937@arm.com>

Hi Ard, Leif,

On Mon, Nov 19, 2018 at 10:39 AM Sughosh Ganu <sughosh.ganu@arm.com> wrote:
>
> hi Ard,
>
> On Thu Oct 25, 2018 at 01:02:33PM +0530, Sughosh Ganu wrote:
> > The following patch series adds support for Management Mode related
> > changes for aarch64 based platforms.
> >
> > Changes since v2:
> > Based on review comments from Ard, moved the memory attribute updation
> > changes out of DebugPeCoffExtraActionLib into an extra action library
> > added in StandaloneMM package. The patch for setting the memory
> > attributes, now under StandaloneMmPkg directory, will be submitted
> > separately from this series.
>
> Can you please review the V3 of this series. Based on your review
> comments, i have moved the memory attribute updation into an extra
> action lib added under StandaloneMmPkg. Can you please check if these
> updated patches for ArmPkg[1] and the one under StandaloneMmPkg[2] are
> fine.
>
> I had put you and Leif on Cc while sending out the patches, but i
> think that the mailserver deleted those, which is why you may have
> missed the patches.
>
> -sughosh
>
> [1] - https://lists.01.org/pipermail/edk2-devel/2018-October/031377.html
> [2] - https://lists.01.org/pipermail/edk2-devel/2018-October/031384.html
>
> >
> >
> > Achin Gupta (5):
> >   ArmPkg: Add PCDs needed for MM communication driver.
> >   ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.
> >   ArmPkg/Include: Add MM interface SVC return codes.
> >   ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.
> >   ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.
> >
> > Sughosh Ganu (1):
> >   ArmPkg/Include: Fix the SPM version SVC ID
> >
> >  ArmPkg/ArmPkg.dec                                                            |   3 +
> >  ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf                        |  56 +++
> >  ArmPkg/Library/ArmMmuLib/{ArmMmuPeiLib.inf => ArmMmuStandaloneMmCoreLib.inf} |  23 +-
> >  ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h                            |  28 ++
> >  ArmPkg/Include/IndustryStandard/ArmMmSvc.h                                   |   9 +-
> >  ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c                          | 395 ++++++++++++++++++++
> >  ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuStandaloneMmCoreLib.c                 | 204 ++++++++++
> >  7 files changed, 704 insertions(+), 14 deletions(-)
> >  create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
> >  copy ArmPkg/Library/ArmMmuLib/{ArmMmuPeiLib.inf => ArmMmuStandaloneMmCoreLib.inf} (51%)
> >  create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h
> >  create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
> >  create mode 100644 ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuStandaloneMmCoreLib.c

Any feedback on this patch series. This series is important in getting
the MM Standalone mode feature supported for Arm platforms. There are
patches being worked on to enable secure variable access feature for
Arm platforms and it depends on this series. So if there any comments
on these patches, please let us know.

Thanks,
Thomas.

> >
> > --
> > 2.7.4
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
>
> --
> -sughosh
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel