public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Thomas Abraham" <thomas.abraham@arm.com>
To: devel@edk2.groups.io, Leif Lindholm <leif.lindholm@linaro.org>
Cc: shenglei.zhang@intel.com, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 13/16] Platform/SgiPkg: Update FDF to use NetworkPkg's include fragment file.
Date: Fri, 17 May 2019 11:31:57 +0530	[thread overview]
Message-ID: <CAJuA9ajKCXZ1P84HK1zpPSDvwCbUkLiFcy3ffUQTeq5xHmeGtg@mail.gmail.com> (raw)
In-Reply-To: <20190516202558.m253nhsqplh4dsh3@bivouac.eciton.net>

On Fri, May 17, 2019 at 1:56 AM Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Wed, May 15, 2019 at 04:56:58PM +0800, Zhang, Shenglei wrote:
> > This patch updates the platform FDF files to use the include fragment
> > files provided by NetworkPkg.
> >
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  Platform/ARM/SgiPkg/SgiPlatform.fdf | 12 +-----------
> >  1 file changed, 1 insertion(+), 11 deletions(-)
> >
> > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> > index b163dab5c3..93ea18ba18 100644
> > --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf
> > +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> > @@ -189,17 +189,7 @@ READ_LOCK_STATUS   = TRUE
> >    #
> >    # Networking stack
> >    #
> > -  INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
> > -  INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
> > -  INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> > -  INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> > -  INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
> > -  INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
> > -  INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> > -  INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> > -  INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > -  INF NetworkPkg/TcpDxe/TcpDxe.inf
> > -  INF NetworkPkg/IScsiDxe/IScsiDxe.inf
> > +!include NetworkPkg/Network.fdf.inc
>
> OK, so this is a little bit messy, but that is due to the include of
> ArmVExpress.dsc.inc and how all that sticks together.
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> But Thomas, would you mind looking into aligning how the VExpress
> config fragments used by various platforms in Platform/ARM interact
> with these new NetworkPkg fragments, and try to clean up so the actual
> function enabling/disabling happens per-platform?

Sure, I will have a look at this next week.

-Thomas.

>
> /
>     Leif
>
> >
> >  !ifdef EDK2_ENABLE_SMSC_91X
> >    INF EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf
> > --
> > 2.18.0.windows.1
> >
> >
> >
> >
>
> 
>

  reply	other threads:[~2019-05-17  6:02 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15  8:56 [PATCH edk2-platforms 00/16] Add Network's include segment files in DSC/FDF Zhang, Shenglei
2019-05-15  8:56 ` [PATCH edk2-platforms 01/16] Platform/OverdriveBoard: Update DSC/FDF to use NetworkPkg's fragment file Zhang, Shenglei
2019-05-16 15:32   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 02/16] Platform/VExpressPkg: Update DSC/FDF to use NetworkPkg's include " Zhang, Shenglei
2019-05-16 16:24   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 03/16] Hisilicon/D03: " Zhang, Shenglei
2019-05-16 16:41   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 04/16] Hisilicon/D05: " Zhang, Shenglei
2019-05-16 16:57   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 05/16] Hisilicon/D06: " Zhang, Shenglei
2019-05-16 17:02   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 06/16] Hisilicon/HiKey: " Zhang, Shenglei
2019-05-16 19:23   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 07/16] Hisilicon/HiKey960: " Zhang, Shenglei
2019-05-16 19:23   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 08/16] Platform/CelloBoard: " Zhang, Shenglei
2019-05-16 20:06   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 09/16] Platform/DeveloperBox: Update DSC/FDF to use NetworkPkg's " Zhang, Shenglei
2019-05-16 20:07   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 10/16] Platform/SynQuacerEvalBoard: " Zhang, Shenglei
2019-05-16 20:10   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 11/16] Platform/Overdrive1000Board: " Zhang, Shenglei
2019-05-16 20:11   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 12/16] Silicon/Armada7k8k: Update DSC/FDF to use NetworkPkg's include " Zhang, Shenglei
2019-05-16 20:18   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 13/16] Platform/SgiPkg: Update FDF " Zhang, Shenglei
2019-05-16 20:25   ` [edk2-devel] " Leif Lindholm
2019-05-17  6:01     ` Thomas Abraham [this message]
2019-05-15  8:56 ` [PATCH edk2-platforms 14/16] Platform/RDKQemu: Update DSC " Zhang, Shenglei
2019-05-16 20:27   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:57 ` [PATCH edk2-platforms 15/16] Platform/Vlv2TbltDevicePkg: Update DSC/FDF to use NetworkPkg's " Zhang, Shenglei
2019-05-15  8:57 ` [PATCH edk2-platforms 16/16] Platform/PurleyOpenBoardPkg: " Zhang, Shenglei
2019-05-15 12:29 ` [edk2-devel] [PATCH edk2-platforms 00/16] Add Network's include segment files in DSC/FDF Liming Gao
2019-05-16 20:30 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJuA9ajKCXZ1P84HK1zpPSDvwCbUkLiFcy3ffUQTeq5xHmeGtg@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox