From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.101.70, mailfrom: thomas.abraham@arm.com) Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by groups.io with SMTP; Thu, 16 May 2019 23:02:10 -0700 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 133A01688 for ; Thu, 16 May 2019 23:02:10 -0700 (PDT) Received: from mail-it1-f176.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC1283F5AF for ; Thu, 16 May 2019 23:02:09 -0700 (PDT) Received: by mail-it1-f176.google.com with SMTP id a190so10094925ite.4 for ; Thu, 16 May 2019 23:02:09 -0700 (PDT) X-Gm-Message-State: APjAAAVIVlej4WIigJyEfJll/PhvIyrmbGlX9XNQtuAp+Cpubiovswfm fHwpgkf3RFXBs0+1gvVgWoH/ys6UmmLZ2aoMegM= X-Google-Smtp-Source: APXvYqzHyGO/A7uuy0ewACeRcIWHTUcbGTSB7PipYUzWZwPzluNBsJt4WHijt319EG7RxDCrrA2nxOTBgXBfq/4zmXQ= X-Received: by 2002:a05:660c:fd3:: with SMTP id m19mr1322236itn.54.1558072929012; Thu, 16 May 2019 23:02:09 -0700 (PDT) MIME-Version: 1.0 References: <20190515085701.24724-1-shenglei.zhang@intel.com> <20190515085701.24724-14-shenglei.zhang@intel.com> <20190516202558.m253nhsqplh4dsh3@bivouac.eciton.net> In-Reply-To: <20190516202558.m253nhsqplh4dsh3@bivouac.eciton.net> From: "Thomas Abraham" Date: Fri, 17 May 2019 11:31:57 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 13/16] Platform/SgiPkg: Update FDF to use NetworkPkg's include fragment file. To: devel@edk2.groups.io, Leif Lindholm Cc: shenglei.zhang@intel.com, Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" On Fri, May 17, 2019 at 1:56 AM Leif Lindholm wrote: > > On Wed, May 15, 2019 at 04:56:58PM +0800, Zhang, Shenglei wrote: > > This patch updates the platform FDF files to use the include fragment > > files provided by NetworkPkg. > > > > Signed-off-by: Shenglei Zhang > > --- > > Platform/ARM/SgiPkg/SgiPlatform.fdf | 12 +----------- > > 1 file changed, 1 insertion(+), 11 deletions(-) > > > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf > > index b163dab5c3..93ea18ba18 100644 > > --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf > > +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf > > @@ -189,17 +189,7 @@ READ_LOCK_STATUS = TRUE > > # > > # Networking stack > > # > > - INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > > - INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > > - INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > > - INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > > - INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > > - INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > > - INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > > - INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > > - INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > > - INF NetworkPkg/TcpDxe/TcpDxe.inf > > - INF NetworkPkg/IScsiDxe/IScsiDxe.inf > > +!include NetworkPkg/Network.fdf.inc > > OK, so this is a little bit messy, but that is due to the include of > ArmVExpress.dsc.inc and how all that sticks together. > > Reviewed-by: Leif Lindholm > > But Thomas, would you mind looking into aligning how the VExpress > config fragments used by various platforms in Platform/ARM interact > with these new NetworkPkg fragments, and try to clean up so the actual > function enabling/disabling happens per-platform? Sure, I will have a look at this next week. -Thomas. > > / > Leif > > > > > !ifdef EDK2_ENABLE_SMSC_91X > > INF EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf > > -- > > 2.18.0.windows.1 > > > > > > > > > > >