public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Thomas Abraham <thomas.abraham@arm.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: vijayenthiran.subramaniam@arm.com, edk2-devel@lists.01.org,
	 star.zeng@intel.com,
	Nariman Poushin <nariman.poushin@linaro.org>
Subject: Re: [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB
Date: Tue, 20 Nov 2018 19:32:35 +0530	[thread overview]
Message-ID: <CAJuA9ajcp5xLAgyCL5M+GR2QaB_jQTv_v0SZ+ZOVbJ+ivY4yLQ@mail.gmail.com> (raw)
In-Reply-To: <20181120131546.du4ywfipsrrsa4vf@bivouac.eciton.net>

On Tue, Nov 20, 2018 at 6:45 PM Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote:
> > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with
> > NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg
> > package. This driver requires the platform to support a maximum variable
> > size of atleast 4KB.
> >
> > So increase the maximum supported variable size to 8KB on the SGI
> > platforms. Without this, the iSCSI driver fails to load.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
>
> Looks good to me, but I'd like an R-b from Thomas/Nariman.

Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>

>
> On a separate note, MdeModulePkg maintainers - is this reason enough
> to change the default of this Pcd?
>
> /
>     Leif
>
> > ---
> >  Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > index 3f0ca9872e79..1c152fad2246 100644
> > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > @@ -102,6 +102,7 @@
> >
> >  [PcdsFixedAtBuild.common]
> >    gArmTokenSpaceGuid.PcdVFPEnabled|1
> > +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> >
> >    # DRAM Block2 Base and Size
> >    gArmSgiTokenSpaceGuid.PcdDramBlock2Base|0x8080000000
> > --
> > 2.17.1
> >
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2018-11-20 14:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 10:31 [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB Vijayenthiran Subramaniam
2018-11-20 13:15 ` Leif Lindholm
2018-11-20 14:02   ` Thomas Abraham [this message]
2018-11-20 14:52     ` Leif Lindholm
2018-11-21  1:30   ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJuA9ajcp5xLAgyCL5M+GR2QaB_jQTv_v0SZ+ZOVbJ+ivY4yLQ@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox