From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 5106721A07A82 for ; Tue, 20 Nov 2018 06:02:48 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A6F215BE for ; Tue, 20 Nov 2018 06:02:48 -0800 (PST) Received: from mail-io1-f41.google.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E5E073F777 for ; Tue, 20 Nov 2018 06:02:47 -0800 (PST) Received: by mail-io1-f41.google.com with SMTP id l14so1275700ioj.5 for ; Tue, 20 Nov 2018 06:02:47 -0800 (PST) X-Gm-Message-State: AA+aEWYyg7vzC3ezwbmTZwtiDCV4xbWS8NBayoDmxw1Ud2ahST/6Jb3B lrYJXv9CXcLzt/AxJ1khORd239lGi1gntZJhNTo= X-Google-Smtp-Source: AFSGD/XqlsJHGBPtSYBlyyeDeHzP7moapfABgmNJHcy/sO6B2ZEHoKV8TW83IZJhkmQ0XkXQ9Dqz4BEijO975kH2bhI= X-Received: by 2002:a5d:8c89:: with SMTP id g9mr719002ion.111.1542722567211; Tue, 20 Nov 2018 06:02:47 -0800 (PST) MIME-Version: 1.0 References: <20181120103102.17775-1-vijayenthiran.subramaniam@arm.com> <20181120131546.du4ywfipsrrsa4vf@bivouac.eciton.net> In-Reply-To: <20181120131546.du4ywfipsrrsa4vf@bivouac.eciton.net> From: Thomas Abraham Date: Tue, 20 Nov 2018 19:32:35 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Leif Lindholm Cc: vijayenthiran.subramaniam@arm.com, edk2-devel@lists.01.org, star.zeng@intel.com, Nariman Poushin Subject: Re: [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 14:02:48 -0000 Content-Type: text/plain; charset="UTF-8" On Tue, Nov 20, 2018 at 6:45 PM Leif Lindholm wrote: > > On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote: > > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with > > NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg > > package. This driver requires the platform to support a maximum variable > > size of atleast 4KB. > > > > So increase the maximum supported variable size to 8KB on the SGI > > platforms. Without this, the iSCSI driver fails to load. > > > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Vijayenthiran Subramaniam > > Looks good to me, but I'd like an R-b from Thomas/Nariman. Reviewed-by: Thomas Abraham > > On a separate note, MdeModulePkg maintainers - is this reason enough > to change the default of this Pcd? > > / > Leif > > > --- > > Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc > > index 3f0ca9872e79..1c152fad2246 100644 > > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc > > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc > > @@ -102,6 +102,7 @@ > > > > [PcdsFixedAtBuild.common] > > gArmTokenSpaceGuid.PcdVFPEnabled|1 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > > > > # DRAM Block2 Base and Size > > gArmSgiTokenSpaceGuid.PcdDramBlock2Base|0x8080000000 > > -- > > 2.17.1 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel