* [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB
@ 2018-11-20 10:31 Vijayenthiran Subramaniam
2018-11-20 13:15 ` Leif Lindholm
0 siblings, 1 reply; 5+ messages in thread
From: Vijayenthiran Subramaniam @ 2018-11-20 10:31 UTC (permalink / raw)
To: edk2-devel, ard.biesheuvel, leif.lindholm; +Cc: Vijayenthiran Subramaniam
Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with
NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg
package. This driver requires the platform to support a maximum variable
size of atleast 4KB.
So increase the maximum supported variable size to 8KB on the SGI
platforms. Without this, the iSCSI driver fails to load.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
---
Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc
index 3f0ca9872e79..1c152fad2246 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dsc
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc
@@ -102,6 +102,7 @@
[PcdsFixedAtBuild.common]
gArmTokenSpaceGuid.PcdVFPEnabled|1
+ gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
# DRAM Block2 Base and Size
gArmSgiTokenSpaceGuid.PcdDramBlock2Base|0x8080000000
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB
2018-11-20 10:31 [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB Vijayenthiran Subramaniam
@ 2018-11-20 13:15 ` Leif Lindholm
2018-11-20 14:02 ` Thomas Abraham
2018-11-21 1:30 ` Zeng, Star
0 siblings, 2 replies; 5+ messages in thread
From: Leif Lindholm @ 2018-11-20 13:15 UTC (permalink / raw)
To: Vijayenthiran Subramaniam
Cc: edk2-devel, ard.biesheuvel, Thomas Panakamattam Abraham,
Nariman Poushin, Star Zeng, Jian J Wang
On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote:
> Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with
> NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg
> package. This driver requires the platform to support a maximum variable
> size of atleast 4KB.
>
> So increase the maximum supported variable size to 8KB on the SGI
> platforms. Without this, the iSCSI driver fails to load.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
Looks good to me, but I'd like an R-b from Thomas/Nariman.
On a separate note, MdeModulePkg maintainers - is this reason enough
to change the default of this Pcd?
/
Leif
> ---
> Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> index 3f0ca9872e79..1c152fad2246 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> @@ -102,6 +102,7 @@
>
> [PcdsFixedAtBuild.common]
> gArmTokenSpaceGuid.PcdVFPEnabled|1
> + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
>
> # DRAM Block2 Base and Size
> gArmSgiTokenSpaceGuid.PcdDramBlock2Base|0x8080000000
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB
2018-11-20 13:15 ` Leif Lindholm
@ 2018-11-20 14:02 ` Thomas Abraham
2018-11-20 14:52 ` Leif Lindholm
2018-11-21 1:30 ` Zeng, Star
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Abraham @ 2018-11-20 14:02 UTC (permalink / raw)
To: Leif Lindholm
Cc: vijayenthiran.subramaniam, edk2-devel, star.zeng, Nariman Poushin
On Tue, Nov 20, 2018 at 6:45 PM Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote:
> > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with
> > NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg
> > package. This driver requires the platform to support a maximum variable
> > size of atleast 4KB.
> >
> > So increase the maximum supported variable size to 8KB on the SGI
> > platforms. Without this, the iSCSI driver fails to load.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
>
> Looks good to me, but I'd like an R-b from Thomas/Nariman.
Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
>
> On a separate note, MdeModulePkg maintainers - is this reason enough
> to change the default of this Pcd?
>
> /
> Leif
>
> > ---
> > Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > index 3f0ca9872e79..1c152fad2246 100644
> > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > @@ -102,6 +102,7 @@
> >
> > [PcdsFixedAtBuild.common]
> > gArmTokenSpaceGuid.PcdVFPEnabled|1
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> >
> > # DRAM Block2 Base and Size
> > gArmSgiTokenSpaceGuid.PcdDramBlock2Base|0x8080000000
> > --
> > 2.17.1
> >
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB
2018-11-20 14:02 ` Thomas Abraham
@ 2018-11-20 14:52 ` Leif Lindholm
0 siblings, 0 replies; 5+ messages in thread
From: Leif Lindholm @ 2018-11-20 14:52 UTC (permalink / raw)
To: Thomas Abraham
Cc: vijayenthiran.subramaniam, edk2-devel, star.zeng, Nariman Poushin
On Tue, Nov 20, 2018 at 07:32:35PM +0530, Thomas Abraham wrote:
> On Tue, Nov 20, 2018 at 6:45 PM Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote:
> > > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with
> > > NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg
> > > package. This driver requires the platform to support a maximum variable
> > > size of atleast 4KB.
> > >
> > > So increase the maximum supported variable size to 8KB on the SGI
> > > platforms. Without this, the iSCSI driver fails to load.
> > >
> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> >
> > Looks good to me, but I'd like an R-b from Thomas/Nariman.
>
> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
Thanks!
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as d9e68a756c.
> >
> > On a separate note, MdeModulePkg maintainers - is this reason enough
> > to change the default of this Pcd?
> >
> > /
> > Leif
> >
> > > ---
> > > Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > > index 3f0ca9872e79..1c152fad2246 100644
> > > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> > > @@ -102,6 +102,7 @@
> > >
> > > [PcdsFixedAtBuild.common]
> > > gArmTokenSpaceGuid.PcdVFPEnabled|1
> > > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> > >
> > > # DRAM Block2 Base and Size
> > > gArmSgiTokenSpaceGuid.PcdDramBlock2Base|0x8080000000
> > > --
> > > 2.17.1
> > >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB
2018-11-20 13:15 ` Leif Lindholm
2018-11-20 14:02 ` Thomas Abraham
@ 2018-11-21 1:30 ` Zeng, Star
1 sibling, 0 replies; 5+ messages in thread
From: Zeng, Star @ 2018-11-21 1:30 UTC (permalink / raw)
To: Leif Lindholm, Vijayenthiran Subramaniam
Cc: edk2-devel, Nariman Poushin, star.zeng
On 2018/11/20 21:15, Leif Lindholm wrote:
> On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote:
>> Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with
>> NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg
>> package. This driver requires the platform to support a maximum variable
>> size of atleast 4KB.
>>
>> So increase the maximum supported variable size to 8KB on the SGI
>> platforms. Without this, the iSCSI driver fails to load.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
>
> Looks good to me, but I'd like an R-b from Thomas/Nariman.
>
> On a separate note, MdeModulePkg maintainers - is this reason enough
> to change the default of this Pcd?
Yes, the PCD is for platform to customize based on usage, so reasonable.
Thanks,
Star
>
> /
> Leif
>
>> ---
>> Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc
>> index 3f0ca9872e79..1c152fad2246 100644
>> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc
>> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc
>> @@ -102,6 +102,7 @@
>>
>> [PcdsFixedAtBuild.common]
>> gArmTokenSpaceGuid.PcdVFPEnabled|1
>> + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
>>
>> # DRAM Block2 Base and Size
>> gArmSgiTokenSpaceGuid.PcdDramBlock2Base|0x8080000000
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-21 1:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-20 10:31 [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB Vijayenthiran Subramaniam
2018-11-20 13:15 ` Leif Lindholm
2018-11-20 14:02 ` Thomas Abraham
2018-11-20 14:52 ` Leif Lindholm
2018-11-21 1:30 ` Zeng, Star
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox