Re: [PATCH v2 2/2] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg drivers.

[Thomas Abraham <thomas.abraham@arm.com>]

On Wed, Nov 7, 2018 at 1:55 PM Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> Hi Fu Siyan,
>
> On Wed, Nov 07, 2018 at 08:12:55AM +0000, Fu, Siyuan wrote:
> > Hi, Leif and Ard
> >
> > I just realized that you may not be CCed in this email. I resent these patches a few minutes ago, my Git Bash send-email reports it added you to CC receiver, but the Outlook received email still doesn't have your name in CC list.
> >
> > Do you have any comments for this v2 patch of the edk2platforms?
> >
> >
> > BestRegards
> > Fu Siyuan
> >
> > > -----Original Message-----
> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu
> > > Siyuan
> > > Sent: Monday, November 5, 2018 9:33 AM
> > > To: edk2-devel@lists.01.org
> > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > > Subject: [edk2] [PATCH v2 2/2] Edk2Platforms: Replace MdeModulePkg
> > > PXE/iSCSI/TCP with NetworkPkg drivers.
> > >
> > > V2:
> > > Additional fixups required for NetworkPkg migration
>
> Revision history like this belongs in the cover letter.
>
> > > The PXE/iSCSI/TCP drivers in MdeModulePkg are going to be deprecated. All
> > > platform DSC/FDF files should be updated to use the dual-stack drivers in
> > > NetworkPkg.
> > >
> > > The NetworkPkg driver have all the functionality compared with
> > > MdeModulePkg
> > > one, with more bug fixes and new feature added. While its image size will
> > > be a little bigger because it contains both IPv4 and IPv6 stack support,
> > > so it may cause build error in a platform if the flash space is very tight.
> > > Basically, this patch won't cause any other problem if build could pass.
> > >
> > > I haven't built all the updated platform because the repo ReadMe doesn't
> > > provide a method to build them on Windows Environment, so I would very
> > > appreciate if anybody can help to test the build or tell me how to build
> > > it on Windows.
>
> And comments like the paragraph above belong in the cover letter or
> below the ---
> If you are OK with me deleting these bits before committing:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> /
>     Leif
>
> > >
> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> > > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > > ---
> > >  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              |  6 +++---
> > >  Platform/AMD/OverdriveBoard/OverdriveBoard.fdf              |  6 +++---
> > >  Platform/ARM/SgiPkg/SgiPlatform.fdf                         |  6 +++---
> > >  Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc           |  1 +
> > >  Platform/ARM/VExpressPkg/ArmVExpress-networking.fdf.inc     |  6 +++---
> > >  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                | 13 +++++++-
> > > -----
> > >  Platform/Comcast/RDKQemu/RDKQemu.dsc                        | 10 +++-----
> > > --
> > >  Platform/Hisilicon/D03/D03.dsc                              |  4 ++--
> > >  Platform/Hisilicon/D03/D03.fdf                              |  4 ++--
> > >  Platform/Hisilicon/D05/D05.dsc                              | 11 +++-----
> > > ---
> > >  Platform/Hisilicon/D05/D05.fdf                              |  9 +++-----
> > > -
> > >  Platform/Hisilicon/D06/D06.dsc                              | 11 +++-----
> > > ---
> > >  Platform/Hisilicon/D06/D06.fdf                              |  9 +++-----
> > > -
> > >  Platform/Hisilicon/HiKey/HiKey.dsc                          |  4 ++--
> > >  Platform/Hisilicon/HiKey/HiKey.fdf                          |  4 ++--
> > >  Platform/Hisilicon/HiKey960/HiKey960.dsc                    |  4 ++--
> > >  Platform/Hisilicon/HiKey960/HiKey960.fdf                    |  4 ++--
> > >  Platform/LeMaker/CelloBoard/CelloBoard.dsc                  | 11
> > > ++++++++---
> > >  Platform/LeMaker/CelloBoard/CelloBoard.fdf                  |  6 +++---
> > >  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc |  6 +++---
> > >  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf |  6 +++---
> > >  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc               |  4 ++--
> > >  Silicon/Marvell/Armada7k8k/Armada7k8k.fdf                   |  4 ++--
> > >  23 files changed, 68 insertions(+), 81 deletions(-)
> > >

[...]

> > >    #
> > >    # Core Info
> > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf
> > > b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> > > index fd87563246..c9129841d7 100644
> > > --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf
> > > +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> > > @@ -185,10 +185,10 @@ READ_LOCK_STATUS   = TRUE
> > >    INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
> > >    INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
> > >    INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> > > -  INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> > >    INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> > > -  INF MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > > -  INF MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
> > > +  INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > > +  INF NetworkPkg/TcpDxe/TcpDxe.inf
> > > +  INF NetworkPkg/IScsiDxe/IScsiDxe.inf
> > >    INF EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf
> > >

[...]

On SGI platforms, the above change causes a crash (Synchronous
Exception). This issue is yet to be debugged but initial observations
are the following messages on the console.

Loading driver at 0x000F7FFC000 EntryPoint=0x000F800B2AC IScsiDxe.efi
InstallProtocolInterface: input handle at 0xFE229C98 is invalid
InstallProtocolInterface: 18A031AB-B443-4D1A-A5C0-0C09261E9F71
F801AA18 failed with Invalid Parameter
Error: Image at 000F7FFC000 start failed: Invalid Parameter
remove-symbol-file
/home/thopan01/devel/sgi/upstream-dev/uefi/edk2/Build/ArmSgi/DEBUG_GCC5/AARCH64/NetworkPkg/IScsiDxe/IScsiDxe/DEBUG/IScsiDxe.dll
0xF7FFD000

and then later crashes in the "PlatformBootManagerBeforeConsole"
function in "ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c" file.

This issue will be debugged. If there are any suggestions on possible
fixes, please let me know.

Thanks,
Thomas.