From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4010:c07::242; helo=mail-lf0-x242.google.com; envelope-from=arvindprasanna@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-lf0-x242.google.com (mail-lf0-x242.google.com [IPv6:2a00:1450:4010:c07::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 14EEC220C2A4C for ; Mon, 12 Mar 2018 22:37:41 -0700 (PDT) Received: by mail-lf0-x242.google.com with SMTP id x205-v6so8559469lfa.0 for ; Mon, 12 Mar 2018 22:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=l++bFBFxE8QfEBZHqCSQ4wsSrxUfRRMkKAO8NXN2pgo=; b=HopJhgQFTjUVFgXxhVPCYqP1Umcel378RgklgGubkgMDaRlJAd/CXviUZX9fp6ksrO qKnsRKbgo0JlwhEiVvy0aYhX5pi6nrMkNDyB/MdTYjeSlFqtMPF5GbpFJtT4eP2qQDoY g+ujn4gOO4hgM41nJTfvbvV3vFovduHklxx6QAtH4MmliP+C0zHDxVbGm3WXuhQ6mmm4 9cz4aUNHoSFX+hin51TsSfbk1udW6PAbsNYS17ttc+O1D2X7deWfLA4LqOdmSHFyuZct 83bWYoBiyU/ZVIKSachz5ghrUvUcRLtgj5DgiwfU2hQdCB9AOC7hlMXrY8zqbyPjnJHH 9IbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=l++bFBFxE8QfEBZHqCSQ4wsSrxUfRRMkKAO8NXN2pgo=; b=f9ago5uNbVbPRpBFPZOqRa/WYpc9YVlOESG0ZNRzX5JKansY0Dp7p3oa203OmjafRY skiavBC6r+dZGqTzLR0Nx7Wtoj9Pwc6iErUPH60q5P+nlh/r7h8gKPeCtANLoGQg8NTJ XncToeF/pw+zZP72gIQNo8+KSRwpqsXcLBdC3QaAxAeciUAt+Wj1pFNT1nU1ulm7Cd2m 0pgiagf/Tq3TRqQlL+g8Srw/7ww/A47nMI0bt6Qr5/wm4xL5twuuWZVbaNocu9z4zNs0 U9xddT+kWwt7tzpK31aHVCWWiQ4hkvhx6/i1buhLA9aLdpDiewX8bBs9NWf3TyfVdfFb XfOQ== X-Gm-Message-State: AElRT7FwaJ/Jpj/DYfz4JTpo8L74wrKjEqYywwNjUlFx9exf8DO2szVw xfctEliGMhK0Zn7pnJnvFc/lBfK+kCGSORAtF4g= X-Google-Smtp-Source: AG47ELssVQcKOMlTm6jJmyJA0gSRmcVc9rSAMVzlLhkqsoPagiydiiZ/yEU1aslL3wE2bSLZPUvJ5Gjpl0z25MxFEts= X-Received: by 2002:a19:cd4c:: with SMTP id d73-v6mr6596476lfg.12.1520919841809; Mon, 12 Mar 2018 22:44:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.179.75.154 with HTTP; Mon, 12 Mar 2018 22:44:01 -0700 (PDT) In-Reply-To: <1520919486-9859-1-git-send-email-arvindprasanna@gmail.com> References: <1520919486-9859-1-git-send-email-arvindprasanna@gmail.com> From: Arvind Prasanna Date: Tue, 13 Mar 2018 01:44:01 -0400 Message-ID: To: Arvind Prasanna Cc: Liming Gao , Yonghong Zhu , edk2-devel@lists.01.org X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: Re: [PATCH v2] edksetup.sh: Update help section regarding positional parameters X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 05:37:42 -0000 Content-Type: text/plain; charset="UTF-8" Please ignore this and follow my original email thread. Git did not chain this as I had expected. - Arvind. On Tue, Mar 13, 2018 at 1:38 AM, Arvind Prasanna wrote: > It is possible to source edksetup.sh from another script. If the > calling/sourcing script has any positional parameters set, those are > incorrectly accounted for in edksetup.sh while sourcing it resulting in > the the help section always being shown. This patch updates the help > section advising the user about these set positional parameters so they > can be unset prior to sourcing edksetup.sh. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Arvind Prasanna > > Changes in v2: > - Fixed a typo. > - Minor rewording. > --- > edksetup.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/edksetup.sh b/edksetup.sh > index 93d6525..e85fbf2 100755 > --- a/edksetup.sh > +++ b/edksetup.sh > @@ -42,6 +42,8 @@ function HelpMsg() > echo Please note: This script must be \'sourced\' so the environment > can be changed. > echo ". $SCRIPTNAME" > echo "source $SCRIPTNAME" > + echo "If this script is being sourced from another script, please > ensure that the" > + echo "sourcing script has no set positional parameters." > } > > function SetWorkspace() > -- > 2.7.4 > >