From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BBEF9AC1199 for ; Mon, 8 Jan 2024 15:08:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mRBY29svja5/MhLuLux1YWJcDIBIRcqGU5wiruD8hEA=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1704726526; v=1; b=aMEqZdFJnlAEq/LmWapkHiL+dlpZlsFVhHUFoS4kQoL1VPHGa0KGp+f+DHJw2nn/YRoZu16P UPxhR+pFYaqBtP2/yHd9XDrWWQ6MnQ0TMJUx6KZAHDN+NVeLEbtGlkoAJkDiyP4Sw5GgnVmN1e4 fFM5oR37uv+XpssW7Wi3oRzw= X-Received: by 127.0.0.2 with SMTP id VuukYY7687511xg2FrbW6HWb; Mon, 08 Jan 2024 07:08:46 -0800 X-Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mx.groups.io with SMTP id smtpd.web10.9105.1704726525515141592 for ; Mon, 08 Jan 2024 07:08:45 -0800 X-Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-28beb1d946fso1721790a91.0 for ; Mon, 08 Jan 2024 07:08:45 -0800 (PST) X-Gm-Message-State: Sw2vUfo0HjPaUNA258N5YYerx7686176AA= X-Google-Smtp-Source: AGHT+IFQCku6CRjHcrvo48QzKmeBbqM/PaueHlu8hxxAleqj/jDD+D85zHjgfZYBEZ/VlV36JNYBx0oBooDEcZWO0X4= X-Received: by 2002:a17:90a:2e18:b0:28c:3b32:bab2 with SMTP id q24-20020a17090a2e1800b0028c3b32bab2mr1737767pjd.98.1704726524561; Mon, 08 Jan 2024 07:08:44 -0800 (PST) MIME-Version: 1.0 References: <20231228164739.1042-1-joey.vagedes@gmail.com> <20231228164739.1042-2-joey.vagedes@gmail.com> <17A83A4D186CC8F7.1387@groups.io> <03b201da4236$1c8c87d0$55a59770$@byosoft.com.cn> In-Reply-To: From: "Joey Vagedes via groups.io" Date: Mon, 8 Jan 2024 07:08:33 -0800 Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Fix raw strings containing valid escape characters To: "Huang, Yanbo" Cc: "Chen, Christine" , "Feng, Bob C" , "Gao, Liming" , "Kinney, Michael D" , Rebecca Cran , "devel@edk2.groups.io" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,joeyvagedes@microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/alternative; boundary="000000000000ef8f32060e709232" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=aMEqZdFJ; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --000000000000ef8f32060e709232 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Liming, It was introduced due to the fact that a few of the regex strings with invalid escape sequences (due to regex using their own escape sequences) also included valid escape sequences - for handling new lines. I did not see the valid escape characters in the strings, and the virtual platforms (Ovmf, etc) did not have the circumstances to catch this, so it slipped through the cracks. Some platform DSCs do, and cause the break that the patch is resolving. I=E2=80=99ve already verified this fix resolves the issue on numerous platf= orms. thanks, Joey On Mon, Jan 8, 2024 at 5:59=E2=80=AFAM Huang, Yanbo = wrote: > Hi Liming, > > This issue is introduced by this commit: > SHA-1: 9f0061a03b61d282fbc0ba5be22155d06a5e64a1 > > * BaseTools: Resolve regex syntax warnings > > Switches regex patterns to raw text to resolve python 3.12 syntax > warnings in regards to invalid escape sequences, as is suggested by the > re (regex) module in python. > > Best Regards, > Yanbo Huang > > -----Original Message----- > From: gaoliming > Sent: Monday, January 8, 2024 9:25 PM > To: devel@edk2.groups.io; Chen, Christine ; 'Joey > Vagedes' > Cc: 'Rebecca Cran' ; Feng, Bob C ; > Huang, Yanbo ; Kinney, Michael D < > michael.d.kinney@intel.com> > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH v1 1/1] BaseTools: Fix r= aw strings > containing valid escape characters > > Christine: > Is this a regression issue? Or does it resolve new usage? I am curious > why it is not reported before. > > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Yuwei Chen > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B41=E6=9C=888=E6=97=A5= 13:37 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Chen, Christine ; > > Joey Vagedes > > =E6=8A=84=E9=80=81: Rebecca Cran ; Gao, Liming > > ; Feng, Bob C ; Huang, > > Yanbo ; Kinney, Michael D > > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Fix raw = strings > containing > > valid escape characters > > > > Hi Liming and Cran, > > > > We should merge this fixing patch asap as it influences BaseTool's usag= e. > > > > Thanks, > > Christine > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of Yuwei > > > Chen > > > Sent: Monday, January 8, 2024 9:16 AM > > > To: Joey Vagedes ; devel@edk2.groups.io > > > Cc: Rebecca Cran ; Gao, Liming > > > ; Feng, Bob C > > > Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Fix raw strings > > containing > > > valid escape characters > > > > > > Hi Joey, > > > > > > Thanks for fixing. > > > > > > Reviewed-by: Yuwei Chen > > > > > > > -----Original Message----- > > > > From: Joey Vagedes > > > > Sent: Friday, December 29, 2023 12:48 AM > > > > To: devel@edk2.groups.io > > > > Cc: Rebecca Cran ; Gao, Liming > > > > ; Feng, Bob C ; > > Chen, > > > > Christine > > > > Subject: [PATCH v1 1/1] BaseTools: Fix raw strings containing > > > > valid escape characters > > > > > > > > Fixes raw regex strings that contain valid (and purposeful) escape > > > > characters as they are being treated as individual characters > > > > rather than the single escaped character they represent (i.e. '\t' > > > > is being > treated > > as > > > a '\' and a 't' > > > > rather than a single tab character). > > > > > > > > Signed-off-by: Joey Vagedes > > > > Cc: Rebecca Cran > > > > Cc: Liming Gao > > > > Cc: Bob Feng > > > > Cc: Yuwei Chen > > > > --- > > > > BaseTools/Source/Python/AutoGen/GenMake.py | 2 +- > > > > BaseTools/Source/Python/Common/Misc.py | 2 +- > > > > BaseTools/Source/Python/Workspace/DscBuildData.py | 4 ++-- > > > > 3 files changed, 4 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py > > > > b/BaseTools/Source/Python/AutoGen/GenMake.py > > > > index c416fe172fe5..fbd35d498923 100755 > > > > --- a/BaseTools/Source/Python/AutoGen/GenMake.py > > > > +++ b/BaseTools/Source/Python/AutoGen/GenMake.py > > > > @@ -28,7 +28,7 @@ from Common.DataType import > > > TAB_COMPILER_MSFT > > > > gIncludePattern =3D re.compile(r"^[ \t]*[#%]?[ \t]*include(?:[ > > > > \t]*(?:\\(?:\r\n|\r|\n))*[ \t]*)*(?:\(?[ \"<]?[ \t]*)([-\w.\\/() > > > > \t]+)(?:[ \t]*[\">]?\)?)", re.MULTILINE | re.UNICODE | > > > > re.IGNORECASE) ## Regular expression for matching macro used in > > > > header file inclusion-gMacroPattern =3D > > > > re.compile(r"([_A-Z][_A-Z0-9]*)[ \t]*\((.+)\)", > > > > re.UNICODE)+gMacroPattern =3D re.compile("([_A-Z][_A-Z0-9]*)[ > > > > \t]*\\((.+)\\)", > > > > re.UNICODE) gIsFileMap =3D {} diff --git > > > > a/BaseTools/Source/Python/Common/Misc.py > > > > b/BaseTools/Source/Python/Common/Misc.py > > > > index f87d9dbdba39..34bfc90abd94 100755 > > > > --- a/BaseTools/Source/Python/Common/Misc.py > > > > +++ b/BaseTools/Source/Python/Common/Misc.py > > > > @@ -1926,4 +1926,4 @@ def CopyDict(ori_dict): > > > > # Remove the c/c++ comments: // and /* */ # def > > > > RemoveCComments(ctext):- return re.sub(r'//.*?\n|/\*.*?\*/', '\n= ', > > ctext, > > > > flags=3Dre.S)+ return re.sub('//.*?\n|/\\*.*?\\*/', '\n', ctext, > > flags=3Dre.S)diff -- > > > git > > > > a/BaseTools/Source/Python/Workspace/DscBuildData.py > > > > b/BaseTools/Source/Python/Workspace/DscBuildData.py > > > > index 817cdbe5f19c..4768099343e5 100644 > > > > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > > > > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > > > > @@ -2840,7 +2840,7 @@ class DscBuildData(PlatformBuildClassObject): > > > > # start generating makefile MakeApp =3D > > PcdMakefileHeader if > > > > sys.platform =3D=3D "win32":- MakeApp =3D MakeApp + r'AP= PFILE > > > > =3D %s\%s.exe\n' % (self.OutputPath, PcdValueInitName) + r'APPNAME = =3D > > > > %s\n' % (PcdValueInitName) + r'OBJECTS =3D %s\%s.obj %s.obj\n' % > > > > (self.OutputPath, PcdValueInitName, os.path.join(self.OutputPath, > > > > PcdValueCommonName)) + 'INC =3D '+ MakeApp =3D MakeApp > > + 'APPFILE > > > > =3D %s\\%s.exe\n' % (self.OutputPath, PcdValueInitName) + 'APPNAME = =3D > > > > %s\n' % (PcdValueInitName) + 'OBJECTS =3D %s\\%s.obj %s.obj\n' % > > > > (self.OutputPath, PcdValueInitName, os.path.join(self.OutputPath, > > > > PcdValueCommonName)) + 'INC =3D ' else: > > MakeApp =3D MakeApp + > > > > PcdGccMakefile MakeApp =3D MakeApp + 'APPFILE > > =3D %s/%s\n' % > > > > (self.OutputPath, PcdValueInitName) + 'APPNAME =3D %s\n' % > > > > (PcdValueInitName) + 'OBJECTS =3D %s/%s.o %s.o\n' % > > > > (self.OutputPath, PcdValueInitName, os.path.join(self.OutputPath, > > > > PcdValueCommonName)) > > > + > > > > \@@ -2950,7 +2950,7 @@ class DscBuildData(PlatformBuildClassObject)= : > > > > MakeApp +=3D "$(OBJECTS) : %s\n" % include_file > > if sys.platform > > > =3D=3D > > > > "win32": PcdValueCommonPath =3D > > > > > > > > > os.path.normpath(mws.join(GlobalData.gGlobalDefines["EDK_TOOLS_PATH"] > > > > , "Source\C\Common\PcdValueCommon.c"))- MakeApp =3D > > MakeApp + > > > > r'%s\PcdValueCommon.c : %s\n' % (self.OutputPath, > > > PcdValueCommonPath)+ > > > > MakeApp =3D MakeApp + '%s\\PcdValueCommon.c : %s\n' % > > (self.OutputPath, > > > > PcdValueCommonPath) MakeApp =3D MakeApp + '\tcopy > > /y %s > > > $@\n' % > > > > (PcdValueCommonPath) else: > > PcdValueCommonPath =3D > > > > > > > > > os.path.normpath(mws.join(GlobalData.gGlobalDefines["EDK_TOOLS_PATH"] > > > > , "Source/C/Common/PcdValueCommon.c"))-- > > > > 2.43.0.windows.1 > > > > > > > > > > > > > > > > > > > > > > >=20 > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113402): https://edk2.groups.io/g/devel/message/113402 Mute This Topic: https://groups.io/mt/103597129/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --000000000000ef8f32060e709232 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Liming,

It was introduced due to the fact that a few of the regex strings with= invalid escape sequences (due to regex using their own escape sequences) a= lso included valid escape sequences - for handling new lines. I did not see= the valid escape characters in the strings, and the virtual platforms (Ovm= f, etc) did not have the circumstances to catch this, so it slipped through= the cracks.=C2=A0

Some = platform DSCs do, and cause the break that the patch is resolving. I=E2=80= =99ve already verified this fix resolves the issue on numerous platforms.= =C2=A0

thanks,
Joey

On Mon, Jan 8, 2024 at 5:59=E2=80=AFAM Huang, Yanbo = <yanbo.huang@intel.com> = wrote:
Hi Liming,

This issue is introduced by this commit:
SHA-1: 9f0061a03b61d282fbc0ba5be22155d06a5e64a1

* BaseTools: Resolve regex syntax warnings

Switches regex patterns to raw text to resolve python 3.12 syntax
warnings in regards to invalid escape sequences, as is suggested by the
re (regex) module in python.

Best Regards,
Yanbo Huang

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Monday, January 8, 2024 9:25 PM
To: devel@edk2.gr= oups.io; Chen, Christine <yuwei.chen@intel.com>; 'Joey Vagedes' <joey.vagedes@gmai= l.com>
Cc: 'Rebecca Cran' <rebecca@bsdio.com>; Feng, Bob C <bob.c.feng@intel.com>; Huang, = Yanbo <yanbo.= huang@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH v1 1/1] BaseTools: Fix raw= strings containing valid escape characters

Christine:
=C2=A0 Is this a regression issue? Or does it resolve new usage? I am curio= us why it is not reported before.

Thanks
Liming
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io <devel@edk2.groups.io> =E4=BB=A3=E8=A1= =A8 Yuwei Chen
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B41=E6=9C=888=E6=97= =A5 13:37
> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Chen, Christine <yuwei.chen@intel.com>;=
> Joey Vagedes <joey.vagedes@gmail.com>
> =E6=8A=84=E9=80=81: Rebecca Cran <rebecca@bsdio.com>; Gao, Liming
> <gaol= iming@byosoft.com.cn>; Feng, Bob C <bob.c.feng@intel.com>; Huang,
> Yanbo <y= anbo.huang@intel.com>; Kinney, Michael D
> <mi= chael.d.kinney@intel.com>
> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Fix raw= strings
containing
> valid escape characters
>
> Hi Liming and Cran,
>
> We should merge this fixing patch asap as it influences BaseTool's= usage.
>
> Thanks,
> Christine
>
> > -----Original Message-----
> > From: d= evel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yuwei
> > Chen
> > Sent: Monday, January 8, 2024 9:16 AM
> > To: Joey Vagedes <joey.vagedes@gmail.com>; devel@edk2.groups.io
> > Cc: Rebecca Cran <rebecca@bsdio.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Feng, Bob C <bob.c.feng@intel.com>
> > Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Fix raw strin= gs
> containing
> > valid escape characters
> >
> > Hi Joey,
> >
> > Thanks for fixing.
> >
> > Reviewed-by: Yuwei Chen <yuwei.chen@intel.com>
> >
> > > -----Original Message-----
> > > From: Joey Vagedes <joey.vagedes@gmail.com>
> > > Sent: Friday, December 29, 2023 12:48 AM
> > > To: devel@edk2.groups.io
> > > Cc: Rebecca Cran <rebecca@bsdio.com>; Gao, Liming
> > > <gaoliming@byosoft.com.cn>; Feng, Bob C <bob.c.feng@intel.com>;
> Chen,
> > > Christine <yuwei.chen@intel.com>
> > > Subject: [PATCH v1 1/1] BaseTools: Fix raw strings containin= g
> > > valid escape characters
> > >
> > > Fixes raw regex strings that contain valid (and purposeful) = escape
> > > characters as they are being treated as individual character= s
> > > rather than the single escaped character they represent (i.e= . '\t'
> > > is being
treated
> as
> > a '\' and a 't'
> > > rather than a single tab character).
> > >
> > > Signed-off-by: Joey Vagedes <joey.vagedes@gmail.com>
> > > Cc: Rebecca Cran <rebecca@bsdio.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Bob Feng <bob.c.feng@intel.com>
> > > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > > ---
> > >=C2=A0 BaseTools/Source/Python/AutoGen/GenMake.py=C2=A0 =C2= =A0 =C2=A0 =C2=A0 | 2 +-
> > >=C2=A0 BaseTools/Source/Python/Common/Misc.py=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
> > >=C2=A0 BaseTools/Source/Python/Workspace/DscBuildData.py | 4 = ++--
> > >=C2=A0 3 files changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py
> > > b/BaseTools/Source/Python/AutoGen/GenMake.py
> > > index c416fe172fe5..fbd35d498923 100755
> > > --- a/BaseTools/Source/Python/AutoGen/GenMake.py
> > > +++ b/BaseTools/Source/Python/AutoGen/GenMake.py
> > > @@ -28,7 +28,7 @@ from Common.DataType import
> > TAB_COMPILER_MSFT
> > > gIncludePattern =3D re.compile(r"^[ \t]*[#%]?[ \t]*incl= ude(?:[
> > > \t]*(?:\\(?:\r\n|\r|\n))*[ \t]*)*(?:\(?[ \"<]?[ \t]*= )([-\w.\\/()
> > > \t]+)(?:[ \t]*[\">]?\)?)", re.MULTILINE | re.UN= ICODE |
> > > re.IGNORECASE)=C2=A0 ## Regular expression for matching macr= o used in
> > > header file inclusion-gMacroPattern =3D
> > > re.compile(r"([_A-Z][_A-Z0-9]*)[ \t]*\((.+)\)", > > > re.UNICODE)+gMacroPattern =3D re.compile("([_A-Z][_A-Z0= -9]*)[
> > > \t]*\\((.+)\\)",
> > > re.UNICODE)=C2=A0 gIsFileMap =3D {} diff --git
> > > a/BaseTools/Source/Python/Common/Misc.py
> > > b/BaseTools/Source/Python/Common/Misc.py
> > > index f87d9dbdba39..34bfc90abd94 100755
> > > --- a/BaseTools/Source/Python/Common/Misc.py
> > > +++ b/BaseTools/Source/Python/Common/Misc.py
> > > @@ -1926,4 +1926,4 @@ def CopyDict(ori_dict):
> > >=C2=A0 # Remove the c/c++ comments: // and /* */ # def
> > > RemoveCComments(ctext):-=C2=A0 =C2=A0 return re.sub(r'//= .*?\n|/\*.*?\*/', '\n',
> ctext,
> > > flags=3Dre.S)+=C2=A0 =C2=A0 return re.sub('//.*?\n|/\\*.= *?\\*/', '\n', ctext,
> flags=3Dre.S)diff --
> > git
> > > a/BaseTools/Source/Python/Workspace/DscBuildData.py
> > > b/BaseTools/Source/Python/Workspace/DscBuildData.py
> > > index 817cdbe5f19c..4768099343e5 100644
> > > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py
> > > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
> > > @@ -2840,7 +2840,7 @@ class DscBuildData(PlatformBuildClassO= bject):
> > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # start generating makefil= e=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0MakeApp =3D
> PcdMakefileHeader=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if
> > > sys.platform =3D=3D "win32":-=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 MakeApp =3D MakeApp + r'APPFILE
> > > =3D %s\%s.exe\n' % (self.OutputPath, PcdValueInitName) += r'APPNAME =3D
> > > %s\n' % (PcdValueInitName) + r'OBJECTS =3D %s\%s.obj= %s.obj\n' %
> > > (self.OutputPath, PcdValueInitName, os.path.join(self.Output= Path,
> > > PcdValueCommonName)) + 'INC =3D '+=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 MakeApp =3D MakeApp
> + 'APPFILE
> > > =3D %s\\%s.exe\n' % (self.OutputPath, PcdValueInitName) = + 'APPNAME =3D
> > > %s\n' % (PcdValueInitName) + 'OBJECTS =3D %s\\%s.obj= %s.obj\n' %
> > > (self.OutputPath, PcdValueInitName, os.path.join(self.Output= Path,
> > > PcdValueCommonName)) + 'INC =3D '=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0else:
> MakeApp =3D MakeApp +
> > > PcdGccMakefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0MakeApp =3D MakeApp + 'APPFILE
> =3D %s/%s\n' %
> > > (self.OutputPath, PcdValueInitName) + 'APPNAME =3D %s\n&= #39; %
> > > (PcdValueInitName) + 'OBJECTS =3D %s/%s.o %s.o\n' % =
> > > (self.OutputPath, PcdValueInitName, os.path.join(self.Output= Path,
> > > PcdValueCommonName))
> > +
> > > \@@ -2950,7 +2950,7 @@ class DscBuildData(PlatformBuildClass= Object):
> > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 MakeApp +=3D= "$(OBJECTS) : %s\n" % include_file
> if sys.platform
> > =3D=3D
> > > "win32":=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0PcdValueCommonPath =3D
> > >
> >
> os.path.normpath(mws.join(GlobalData.gGlobalDefines["EDK_TOOLS_PA= TH"]
> > > , "Source\C\Common\PcdValueCommon.c"))-=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 MakeApp =3D
> MakeApp +
> > > r'%s\PcdValueCommon.c : %s\n' % (self.OutputPath, > > PcdValueCommonPath)+
> > > MakeApp =3D MakeApp + '%s\\PcdValueCommon.c : %s\n' = %
> (self.OutputPath,
> > > PcdValueCommonPath)=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0MakeApp =3D MakeApp + '\tcopy
> /y %s
> > $@\n' %
> > > (PcdValueCommonPath)=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else:<= br> > PcdValueCommonPath =3D
> > >
> >
> os.path.normpath(mws.join(GlobalData.gGlobalDefines["EDK_TOOLS_PA= TH"]
> > > , "Source/C/Common/PcdValueCommon.c"))--
> > > 2.43.0.windows.1
> >
> >
> >
> >
> >
>
>
>
>
>



_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#113402) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--000000000000ef8f32060e709232--