Re: [edk2-devel] [PATCH v1 00/24] Update Edk2-pytools to latest versions

["Joey Vagedes via groups.io" <joeyvagedes=microsoft.com@groups.io>]

[-- Attachment #1: Type: text/plain, Size: 7093 bytes --]

Hello everyone, I'm still looking for reviews for this change. Please
remember this has no effect on the package itself, rather it adds
additional helps to ensure your package is tested when necessary. The
particular situation this change now catches is when a library instance
(INF) from outside your package changes and your package consumes that
library instance. When this situation occurs, your package will also be
built as a part of CI, ensuring other package changes don't break your
package in a build breaking way.

I still need reviews from the following packages:
- UefiPayloadPkg
- ArmPkg
- UefiCpuPkg
- ArmPlatformPkg
- CryptoPkg
- FatPkg
- FmpDevicePkg
- IntelFsp2Pkg
- CryptoPkg
- SourceLevelDebugPkg
- SignedCapsulePkg
- ShellPkg
- SecurityPkg
- PcAtChipsetPkg
- NetworkPkg
- MdePkg
- MdeModulePkg
- IntelFsp2WrapperPkg

Thank you to those that have already reviewed!

Thanks,
Joey

On Thu, Jul 6, 2023 at 8:22 AM Joey Vagedes <joey.vagedes@gmail.com> wrote:

> Hello everyone,
>
> Just following up on this patch series; looking for reviews from each
> package owner. Just to reiterate, this patch series enables a new policy
> for detecting which packages should be built for any given PR / Patch on
> github. The policy is used when an INF is changed. It requires that any
> package consuming that inf (generally a library instance) be built and
> tested. I'm happy to help answer any questions!
>
> Thanks,
> Joey
>
> On Mon, Jun 26, 2023 at 2:34 PM Joey Vagedes <joey.vagedes@gmail.com>
> wrote:
>
>> Updates Edk2-pytools to the latest versions, which introduces a new Policy
>> for detecting which packages must be built given a set of changes. This
>> policy
>> is used when a library class instance INF is changed. When this occurs,
>> it will
>> review the PrEval:DscPath provided in the CI YAML file and determine if
>> the
>> package uses the library instance or not. If it does, it will build and
>> test
>> the package.
>>
>> Due to these changes, each package must now include an entry in it's CI
>> YAML
>> file (PrEval:DscPath). If the package does not provide this entry, this
>> policy
>> will be skipped, which could lead to a library instance breaking packages
>> outside
>> of it's parent package.
>>
>> Cc: Abner Chang <abner.chang@amd.com>
>> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Chen Gang C <gang.c.chen@intel.com>
>> Cc: Daniel Schaefer <git@danielschaefer.me>
>> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Guo Dong <guo.dong@intel.com>
>> Cc: Guomin Jiang <guomin.jiang@intel.com>
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>> Cc: Igor Kulchytskyy <igork@ami.com>
>> Cc: James Lu <james.lu@intel.com>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Nickle Wang <nicklew@nvidia.com>
>> Cc: Pierre Gondois <pierre.gondois@arm.com>
>> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>> Cc: Ray Han Lim Ng <ray.han.lim.ng@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>> Cc: Sean Rhodes <sean@starlabs.systems>
>> Cc: Siyuan Fu <siyuan.fu@intel.com>
>> Cc: Star Zeng <star.zeng@intel.com>
>> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
>> Cc: Ted Kuo <ted.kuo@intel.com>
>> Cc: Wei6 Xu <wei6.xu@intel.com>
>> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
>> Cc: Yi Li <yi1.li@intel.com>
>> Cc: Zhichao Gao <zhichao.gao@intel.com>
>> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>>
>> Joey Vagedes (24):
>>   Edk2: edk2-pytools: Update to latest versions
>>   UnitTestFrameworkPkg: CI: Add PrEval entry
>>   UefiPayloadPkg: CI: Add PrEval entry
>>   ArmPkg: CI: Add PrEval entry
>>   UefiCpuPkg: CI: Add PrEval entry
>>   ArmPlatformPkg: CI: Add PrEval entry
>>   CryptoPkg: CI: Add PrEval entry
>>   DynamicTablesPkg: CI: Add PrEval entry
>>   EmbeddedPkg: CI: Add PrEval entry
>>   FatPkg: CI: Add PrEval entry
>>   FmpDevicePkg: CI: Add PrEval entry
>>   IntelFsp2Pkg: CI: Add PrEval entry
>>   CryptoPkg: CI: Add PrEval entry
>>   SourceLevelDebugPkg: CI: Add PrEval entry
>>   SignedCapsulePkg: CI: Add PrEval entry
>>   ShellPkg: CI: Add PrEval entry
>>   SecurityPkg: CI: Add PrEval entry
>>   RedfishPkg: CI: Add PrEval entry
>>   PrmPkg: CI: Add PrEval entry
>>   PcAtChipsetPkg: CI: Add PrEval entry
>>   NetworkPkg: CI: Add PrEval entry
>>   MdePkg: CI: Add PrEval entry
>>   MdeModulePkg: CI: Add PrEval entry
>>   IntelFsp2WrapperPkg: CI: Add PrEval entry
>>
>>  ArmPkg/ArmPkg.ci.yaml                             | 3 +++
>>  ArmPlatformPkg/ArmPlatformPkg.ci.yaml             | 3 +++
>>  CryptoPkg/CryptoPkg.ci.yaml                       | 3 +++
>>  DynamicTablesPkg/DynamicTablesPkg.ci.yaml         | 3 +++
>>  EmbeddedPkg/EmbeddedPkg.ci.yaml                   | 3 +++
>>  FatPkg/FatPkg.ci.yaml                             | 3 +++
>>  FmpDevicePkg/FmpDevicePkg.ci.yaml                 | 3 +++
>>  IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml                 | 3 +++
>>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml   | 3 +++
>>  MdeModulePkg/MdeModulePkg.ci.yaml                 | 3 +++
>>  MdePkg/MdePkg.ci.yaml                             | 3 +++
>>  NetworkPkg/NetworkPkg.ci.yaml                     | 3 +++
>>  PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml             | 3 +++
>>  PrmPkg/PrmPkg.ci.yaml                             | 3 +++
>>  RedfishPkg/RedfishPkg.ci.yaml                     | 3 +++
>>  SecurityPkg/SecurityPkg.ci.yaml                   | 3 +++
>>  ShellPkg/ShellPkg.ci.yaml                         | 3 +++
>>  SignedCapsulePkg/SignedCapsulePkg.ci.yaml         | 3 +++
>>  SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml   | 3 +++
>>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml           | 3 +++
>>  UefiCpuPkg/UefiCpuPkg.ci.yaml                     | 3 +++
>>  UefiPayloadPkg/UefiPayloadPkg.ci.yaml             | 3 +++
>>  UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++
>>  pip-requirements.txt                              | 4 ++--
>>  24 files changed, 71 insertions(+), 2 deletions(-)
>>
>> --
>> 2.41.0.windows.1
>>
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107430): https://edk2.groups.io/g/devel/message/107430
Mute This Topic: https://groups.io/mt/99798032/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 11334 bytes --]