Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry

["Joey Vagedes via groups.io" <joeyvagedes=microsoft.com@groups.io>]

[-- Attachment #1: Type: text/plain, Size: 2864 bytes --]

Thank you for catching this! I will correct it.

Thanks,
Joey

On Fri, Oct 6, 2023 at 8:07 PM Li, Yi1 <yi1.li@intel.com> wrote:

> Joey:
>
> I already give feedback for CryptoPkg part.
>
> Seems there are two Crypto patch 07/24 and 13/24, but actually 13 is
> StandaloneMmPkg changes. Please check.
> [PATCH v1 13/24] CryptoPkg: CI: Add PrEval entry
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Li, Yi
> Sent: Wednesday, August 2, 2023 12:42 PM
> To: Joey Vagedes <joey.vagedes@gmail.com>; devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>;
> Jiang, Guomin <guomin.jiang@intel.com>
> Subject: Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry
>
>
> Looks good to me.
> Reviewed-by: Yi Li <yi1.li@intel.com>
>
> -----Original Message-----
> From: Joey Vagedes <joey.vagedes@gmail.com>
> Sent: Tuesday, June 27, 2023 5:34 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Lu,
> Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
> Subject: [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry
>
> Adds a PrEval entry to the package's ci.yaml file which is used to verify
> if the package uses a particular library instance when that library
> instance file (INF) is updated.
>
> When a library instance file (INF) is updated, PrEval will review each
> package's DSC as described in the ci.yaml file to determine if the package
> uses said library instance. If the package does use the library instance,
> it will be built and tested to ensure the package is not broken from the
> change.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
> ---
>  CryptoPkg/CryptoPkg.ci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
> index 47f29759676d..4cec206477bc 100644
> --- a/CryptoPkg/CryptoPkg.ci.yaml
> +++ b/CryptoPkg/CryptoPkg.ci.yaml
> @@ -6,6 +6,9 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent ## {+    "PrEval": {+
>   "DscPath": "CryptoPkg.dsc",+    },     "LicenseCheck": {
>  "IgnoreFiles": [             # These directories contain auto-generated
> OpenSSL content--
> 2.41.0.windows.1
>
>
>
> 
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109462): https://edk2.groups.io/g/devel/message/109462
Mute This Topic: https://groups.io/mt/99798040/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 4948 bytes --]