From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0A044941A89 for ; Mon, 9 Oct 2023 16:26:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jldpEIHOYtKQ35g+RnMOJAZwEpqNBouSz6TNM2vAqo8=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1696868785; v=1; b=EbVjJRm+Nv0W5B4DybM6xYpNDJJ3ygcc9sCAgfrY0lxA0JMeMoxdDu8K9y/4jvEFd1Jwys/N HUp9Qy3gaJw2E6sPtvTp9gwNT995PmjQfaOBceqYFjlGDM90WvLi8I7f1FLEjpBy3ORY5UsFJMF I7YHMgWS9H1tKPpXw5z5xcco= X-Received: by 127.0.0.2 with SMTP id pXL0YY7687511xC0Yp4hviC4; Mon, 09 Oct 2023 09:26:25 -0700 X-Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mx.groups.io with SMTP id smtpd.web10.67726.1696868785187154721 for ; Mon, 09 Oct 2023 09:26:25 -0700 X-Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-564af0ac494so3072910a12.0 for ; Mon, 09 Oct 2023 09:26:25 -0700 (PDT) X-Gm-Message-State: wFz5CwzOk5HMiMkW2oyEHaJdx7686176AA= X-Google-Smtp-Source: AGHT+IHF3iQDieZV8BhYICsJBWh4uP/9SXbfTKoy9uFCxx8X9fBdODN+YYDxPR/dAkkJOcU6wGje8HeqafafByNWnp4= X-Received: by 2002:a17:90b:fcb:b0:276:6b9d:7503 with SMTP id gd11-20020a17090b0fcb00b002766b9d7503mr13521461pjb.28.1696868784471; Mon, 09 Oct 2023 09:26:24 -0700 (PDT) MIME-Version: 1.0 References: <20230626213434.8-1-joey.vagedes@gmail.com> <20230626213434.8-8-joey.vagedes@gmail.com> <1777774354535489.2497@groups.io> In-Reply-To: From: "Joey Vagedes via groups.io" Date: Mon, 9 Oct 2023 09:26:14 -0700 Message-ID: Subject: Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry To: "Li, Yi1" Cc: "devel@edk2.groups.io" , "Yao, Jiewen" , "Lu, Xiaoyu1" , "Jiang, Guomin" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,joeyvagedes@microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/alternative; boundary="0000000000002102aa06074b0d6f" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=EbVjJRm+; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --0000000000002102aa06074b0d6f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you for catching this! I will correct it. Thanks, Joey On Fri, Oct 6, 2023 at 8:07=E2=80=AFPM Li, Yi1 wrote: > Joey: > > I already give feedback for CryptoPkg part. > > Seems there are two Crypto patch 07/24 and 13/24, but actually 13 is > StandaloneMmPkg changes. Please check. > [PATCH v1 13/24] CryptoPkg: CI: Add PrEval entry > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Li, Yi > Sent: Wednesday, August 2, 2023 12:42 PM > To: Joey Vagedes ; devel@edk2.groups.io > Cc: Yao, Jiewen ; Lu, Xiaoyu1 ; > Jiang, Guomin > Subject: Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entr= y > > > Looks good to me. > Reviewed-by: Yi Li > > -----Original Message----- > From: Joey Vagedes > Sent: Tuesday, June 27, 2023 5:34 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Li, Yi1 ; Lu, > Xiaoyu1 ; Jiang, Guomin > Subject: [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry > > Adds a PrEval entry to the package's ci.yaml file which is used to verify > if the package uses a particular library instance when that library > instance file (INF) is updated. > > When a library instance file (INF) is updated, PrEval will review each > package's DSC as described in the ci.yaml file to determine if the packag= e > uses said library instance. If the package does use the library instance, > it will be built and tested to ensure the package is not broken from the > change. > > Cc: Jiewen Yao > Cc: Yi Li > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Signed-off-by: Joey Vagedes > --- > CryptoPkg/CryptoPkg.ci.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml > index 47f29759676d..4cec206477bc 100644 > --- a/CryptoPkg/CryptoPkg.ci.yaml > +++ b/CryptoPkg/CryptoPkg.ci.yaml > @@ -6,6 +6,9 @@ > # SPDX-License-Identifier: BSD-2-Clause-Patent ## {+ "PrEval": {+ > "DscPath": "CryptoPkg.dsc",+ }, "LicenseCheck": { > "IgnoreFiles": [ # These directories contain auto-generated > OpenSSL content-- > 2.41.0.windows.1 > > > >=20 > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109462): https://edk2.groups.io/g/devel/message/109462 Mute This Topic: https://groups.io/mt/99798040/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --0000000000002102aa06074b0d6f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you for catching this! I will correct it.

Thanks,
Joey

<= div dir=3D"ltr" class=3D"gmail_attr">On Fri, Oct 6, 2023 at 8:07=E2=80=AFPM= Li, Yi1 <yi1.li@intel.com> w= rote:
Joey:

I already give feedback for CryptoPkg part.

Seems there are two Crypto patch 07/24 and 13/24, but actually 13 is Standa= loneMmPkg changes. Please check.
[PATCH v1 13/24] CryptoPkg: CI: Add PrEval entry

-----Original Message-----
From: devel@edk2.= groups.io <devel@edk2.groups.io> On Behalf Of Li, Yi
Sent: Wednesday, August 2, 2023 12:42 PM
To: Joey Vagedes <joey.vagedes@gmail.com>; devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin= <guomin.jia= ng@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry<= br>

Looks good to me.
Reviewed-by: Yi Li <yi1.li@intel.com>

-----Original Message-----
From: Joey Vagedes <joey.vagedes@gmail.com>
Sent: Tuesday, June 27, 2023 5:34 AM
To: devel@edk2.gr= oups.io
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com= >; Jiang, Guomin <guomin.jiang@intel.com>
Subject: [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry

Adds a PrEval entry to the package's ci.yaml file which is used to veri= fy if the package uses a particular library instance when that library inst= ance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each pack= age's DSC as described in the ci.yaml file to determine if the package = uses said library instance. If the package does use the library instance, i= t will be built and tested to ensure the package is not broken from the cha= nge.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Yi Li <yi1.li@= intel.com>
Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
=C2=A0CryptoPkg/CryptoPkg.ci.yaml | 3 +++
=C2=A01 file changed, 3 insertions(+)

diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml inde= x 47f29759676d..4cec206477bc 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -6,6 +6,9 @@
=C2=A0# SPDX-License-Identifier: BSD-2-Clause-Patent ## {+=C2=A0 =C2=A0 &qu= ot;PrEval": {+=C2=A0 =C2=A0 =C2=A0 =C2=A0 "DscPath": "C= ryptoPkg.dsc",+=C2=A0 =C2=A0 },=C2=A0 =C2=A0 =C2=A0"LicenseCheck&= quot;: {=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"IgnoreFiles": [=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0# These directories contain auto-g= enerated OpenSSL content--
2.41.0.windows.1






_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#109462) | =20 | Mute = This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--0000000000002102aa06074b0d6f--