Hello everyone, Almost done! Following up on this patch series. I still need reviews for the following packages: Please see comments above as to why this will not affect the package, except to ensure it is tested if another package changes a library INF your package uses. UefiPayloadPkg ArmPkg UefiCpuPkg ArmPlatformPkg CryptoPkg FatPkg SourceLevelDebugPkg SignedCapsulePkg ShellPkg SecurityPkgPcAtChipsetPkg NetworkPkg Thanks, Joey On Tue, Aug 1, 2023 at 9:16 AM Joey Vagedes wrote: > Hello everyone, I'm still looking for reviews for this change. Please > remember this has no effect on the package itself, rather it adds > additional helps to ensure your package is tested when necessary. The > particular situation this change now catches is when a library instance > (INF) from outside your package changes and your package consumes that > library instance. When this situation occurs, your package will also be > built as a part of CI, ensuring other package changes don't break your > package in a build breaking way. > > I still need reviews from the following packages: > - UefiPayloadPkg > - ArmPkg > - UefiCpuPkg > - ArmPlatformPkg > - CryptoPkg > - FatPkg > - FmpDevicePkg > - IntelFsp2Pkg > - CryptoPkg > - SourceLevelDebugPkg > - SignedCapsulePkg > - ShellPkg > - SecurityPkg > - PcAtChipsetPkg > - NetworkPkg > - MdePkg > - MdeModulePkg > - IntelFsp2WrapperPkg > > Thank you to those that have already reviewed! > > Thanks, > Joey > > On Thu, Jul 6, 2023 at 8:22 AM Joey Vagedes > wrote: > >> Hello everyone, >> >> Just following up on this patch series; looking for reviews from each >> package owner. Just to reiterate, this patch series enables a new policy >> for detecting which packages should be built for any given PR / Patch on >> github. The policy is used when an INF is changed. It requires that any >> package consuming that inf (generally a library instance) be built and >> tested. I'm happy to help answer any questions! >> >> Thanks, >> Joey >> >> On Mon, Jun 26, 2023 at 2:34 PM Joey Vagedes >> wrote: >> >>> Updates Edk2-pytools to the latest versions, which introduces a new >>> Policy >>> for detecting which packages must be built given a set of changes. This >>> policy >>> is used when a library class instance INF is changed. When this occurs, >>> it will >>> review the PrEval:DscPath provided in the CI YAML file and determine if >>> the >>> package uses the library instance or not. If it does, it will build and >>> test >>> the package. >>> >>> Due to these changes, each package must now include an entry in it's CI >>> YAML >>> file (PrEval:DscPath). If the package does not provide this entry, this >>> policy >>> will be skipped, which could lead to a library instance breaking >>> packages outside >>> of it's parent package. >>> >>> Cc: Abner Chang >>> Cc: Alexei Fedorov >>> Cc: Ard Biesheuvel >>> Cc: Ashraf Ali S >>> Cc: Chasel Chiu >>> Cc: Chen Gang C >>> Cc: Daniel Schaefer >>> Cc: Duggapu Chinni B >>> Cc: Eric Dong >>> Cc: Gerd Hoffmann >>> Cc: Guo Dong >>> Cc: Guomin Jiang >>> Cc: Hao A Wu >>> Cc: Igor Kulchytskyy >>> Cc: James Lu >>> Cc: Jian J Wang >>> Cc: Jiewen Yao >>> Cc: Leif Lindholm >>> Cc: Liming Gao >>> Cc: Maciej Rabeda >>> Cc: Michael D Kinney >>> Cc: Michael Kubacki >>> Cc: Nate DeSimone >>> Cc: Nickle Wang >>> Cc: Pierre Gondois >>> Cc: Rahul Kumar >>> Cc: Ray Han Lim Ng >>> Cc: Ray Ni >>> Cc: Sami Mujawar >>> Cc: Sean Brogan >>> Cc: Sean Rhodes >>> Cc: Siyuan Fu >>> Cc: Star Zeng >>> Cc: Susovan Mohapatra >>> Cc: Ted Kuo >>> Cc: Wei6 Xu >>> Cc: Xiaoyu Lu >>> Cc: Yi Li >>> Cc: Zhichao Gao >>> Cc: Zhiguang Liu >>> >>> Joey Vagedes (24): >>> Edk2: edk2-pytools: Update to latest versions >>> UnitTestFrameworkPkg: CI: Add PrEval entry >>> UefiPayloadPkg: CI: Add PrEval entry >>> ArmPkg: CI: Add PrEval entry >>> UefiCpuPkg: CI: Add PrEval entry >>> ArmPlatformPkg: CI: Add PrEval entry >>> CryptoPkg: CI: Add PrEval entry >>> DynamicTablesPkg: CI: Add PrEval entry >>> EmbeddedPkg: CI: Add PrEval entry >>> FatPkg: CI: Add PrEval entry >>> FmpDevicePkg: CI: Add PrEval entry >>> IntelFsp2Pkg: CI: Add PrEval entry >>> CryptoPkg: CI: Add PrEval entry >>> SourceLevelDebugPkg: CI: Add PrEval entry >>> SignedCapsulePkg: CI: Add PrEval entry >>> ShellPkg: CI: Add PrEval entry >>> SecurityPkg: CI: Add PrEval entry >>> RedfishPkg: CI: Add PrEval entry >>> PrmPkg: CI: Add PrEval entry >>> PcAtChipsetPkg: CI: Add PrEval entry >>> NetworkPkg: CI: Add PrEval entry >>> MdePkg: CI: Add PrEval entry >>> MdeModulePkg: CI: Add PrEval entry >>> IntelFsp2WrapperPkg: CI: Add PrEval entry >>> >>> ArmPkg/ArmPkg.ci.yaml | 3 +++ >>> ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 3 +++ >>> CryptoPkg/CryptoPkg.ci.yaml | 3 +++ >>> DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 3 +++ >>> EmbeddedPkg/EmbeddedPkg.ci.yaml | 3 +++ >>> FatPkg/FatPkg.ci.yaml | 3 +++ >>> FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 +++ >>> IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml | 3 +++ >>> IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml | 3 +++ >>> MdeModulePkg/MdeModulePkg.ci.yaml | 3 +++ >>> MdePkg/MdePkg.ci.yaml | 3 +++ >>> NetworkPkg/NetworkPkg.ci.yaml | 3 +++ >>> PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 +++ >>> PrmPkg/PrmPkg.ci.yaml | 3 +++ >>> RedfishPkg/RedfishPkg.ci.yaml | 3 +++ >>> SecurityPkg/SecurityPkg.ci.yaml | 3 +++ >>> ShellPkg/ShellPkg.ci.yaml | 3 +++ >>> SignedCapsulePkg/SignedCapsulePkg.ci.yaml | 3 +++ >>> SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml | 3 +++ >>> StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 3 +++ >>> UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 +++ >>> UefiPayloadPkg/UefiPayloadPkg.ci.yaml | 3 +++ >>> UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++ >>> pip-requirements.txt | 4 ++-- >>> 24 files changed, 71 insertions(+), 2 deletions(-) >>> >>> -- >>> 2.41.0.windows.1 >>> >>> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107985): https://edk2.groups.io/g/devel/message/107985 Mute This Topic: https://groups.io/mt/99798032/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-