From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B3397941B69 for ; Mon, 9 Oct 2023 16:49:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=43CnZeoIYnpLgFh1sETNu3uDsre7tlUY16Ry3q8F9oo=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1696870153; v=1; b=XlMd24b1FVGj/2uC0150/GLQosVnpFWkrwy8aRLPk0B6v/rjXQ6wjPWd42tO48PNv3A0n6fE lCe167NTK0b9kCKZGMfCLSq8QkDv0ShpaaFcYq9PaX98gE/dM9k83+9L7Yf/GQriY22oBve/b61 xIVBF12BKHHsKLq1/pLXmWcM= X-Received: by 127.0.0.2 with SMTP id NwjmYY7687511x0pyi82tiyt; Mon, 09 Oct 2023 09:49:13 -0700 X-Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mx.groups.io with SMTP id smtpd.web10.68443.1696870152823650517 for ; Mon, 09 Oct 2023 09:49:12 -0700 X-Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1c60cec8041so27944015ad.3 for ; Mon, 09 Oct 2023 09:49:12 -0700 (PDT) X-Gm-Message-State: lQARavrsbqdaZeTyyxwlwraKx7686176AA= X-Google-Smtp-Source: AGHT+IEam+VMmpt84Q8/9ffqW1iThm82lRq4zW5XBhIdD3jC3tXR730c4cC6egqeQGKfIhG2naSuf7dUOE9Qo3SpgOc= X-Received: by 2002:a17:90b:4a07:b0:279:7963:cdf2 with SMTP id kk7-20020a17090b4a0700b002797963cdf2mr12508538pjb.0.1696870151636; Mon, 09 Oct 2023 09:49:11 -0700 (PDT) MIME-Version: 1.0 References: <20230626213434.8-1-joey.vagedes@gmail.com> <20230626213434.8-14-joey.vagedes@gmail.com> In-Reply-To: <20230626213434.8-14-joey.vagedes@gmail.com> From: "Joey Vagedes via groups.io" Date: Mon, 9 Oct 2023 09:49:01 -0700 Message-ID: Subject: Re: [edk2-devel] [PATCH v1 13/24] StandaloneMmPkg: CI: Add PrEval entry To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar , Ray Ni Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,joeyvagedes@microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/alternative; boundary="0000000000009e4de906074b5e80" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XlMd24b1; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --0000000000009e4de906074b5e80 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello All, Due to a Subject Line mistake, this particular patch was labeled as a CryptoPkg change. I'm resending this out to the package maintainers with the correct package (StandaloneMmPkg). Please review this change to your package's ci.yaml file ~ This change will ensure your package is properly tested if another package changes an INF that your package depends on to build, making sure it is not broken from another's change. If you wish for this to be merged into your package, please review. If not, I will be re-sending this patch series out with only the package's I have reviews on, to get it merged so that we can update edk2-pytools further. You will always be able to add this yourself at a later date if you wish. Thanks, Joey On Mon, Jun 26, 2023 at 2:35=E2=80=AFPM Joey Vagedes wrote: > Adds a PrEval entry to the package's ci.yaml file which is used to > verify if the package uses a particular library instance when that > library instance file (INF) is updated. > > When a library instance file (INF) is updated, PrEval will review each > package's DSC as described in the ci.yaml file to determine if the > package uses said library instance. If the package does use the library > instance, it will be built and tested to ensure the package is not > broken from the change. > > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni > Signed-off-by: Joey Vagedes > --- > StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml > b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml > index 4777532a7ede..f23f5f2c4db2 100644 > --- a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml > +++ b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml > @@ -5,6 +5,9 @@ > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## > { > + "PrEval": { > + "DscPath": "StandaloneMmPkg.dsc", > + }, > "EccCheck": { > ## Exception sample looks like below: > ## "ExceptionList": [ > -- > 2.41.0.windows.1 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109463): https://edk2.groups.io/g/devel/message/109463 Mute This Topic: https://groups.io/mt/101856788/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --0000000000009e4de906074b5e80 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello All,

Due to a Subject = Line mistake, this particular patch was labeled as a CryptoPkg change. I= 9;m resending this out to the package maintainers with the correct package = (StandaloneMmPkg).

Please review this change to yo= ur package's ci.yaml file ~ This change will ensure your package is pro= perly tested if another package changes an INF that your package depends on= to build, making sure it is not broken from another's change. If you w= ish for this to be merged into your package, please review.

<= /div>
If not, I will be re-sending this patch series out with only the = package's I have reviews on, to get it merged so that we can update edk= 2-pytools further. You will always be able to add this yourself at a later = date if you wish.

Thanks,
Joey


On Mon, Jun 26, 2023 at 2:35=E2=80=AFPM Joey Vagedes <joey.vagedes@gmail.com> wrote:
Adds a PrEval entry to t= he package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Ray Ni <ray.ni= @intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
=C2=A0StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 3 +++
=C2=A01 file changed, 3 insertions(+)

diff --git a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml b/StandaloneMmPkg/Stan= daloneMmPkg.ci.yaml
index 4777532a7ede..f23f5f2c4db2 100644
--- a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
+++ b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
@@ -5,6 +5,9 @@
=C2=A0#=C2=A0 SPDX-License-Identifier: BSD-2-Clause-Patent
=C2=A0##
=C2=A0{
+=C2=A0 =C2=A0 "PrEval": {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 "DscPath": "StandaloneMmPkg.dsc= ",
+=C2=A0 =C2=A0 },
=C2=A0 =C2=A0 =C2=A0"EccCheck": {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0## Exception sample looks like below:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0## "ExceptionList": [
--
2.41.0.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#109463) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--0000000000009e4de906074b5e80--