public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>, yi1.li@intel.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	 Jordan Justen <jordan.l.justen@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH] OvmfPkg/PlatformCI: Skip GCC5_OVMF_IA32X64_FULL_NOOPT build
Date: Wed, 21 Jun 2023 01:40:06 +0100	[thread overview]
Message-ID: <CAKbZUD0+75TDOuhsx6wdTY8zd=cEorDpuBxP2ic6ibFVWkh7rA@mail.gmail.com> (raw)
In-Reply-To: <20230620111139.21365-1-yi1.li@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2472 bytes --]

On Tue, 20 Jun 2023, 12:11 Li, Yi, <yi1.li@intel.com> wrote:

> The effect of LTO is limited with optimization turned off, and blocked
> the upgrade of Openssl3.0. We already skipped this build with VS2019,
> skip the GCC NOOPT build also.
>
Hi,

If LTO is the problem here, have you given ffunction-sections +
fdata-sections + gc-sections a spin?

It may end up working, though I genuinely don't remember if the GCC
toolchain has that on regardless (and wont be able to check foe the next
few days)...


> Signed-off-by: Yi Li <yi1.li@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  .../PlatformCI/.azurepipelines/Ubuntu-GCC5.yml  | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index ad43f9fad2..5809152d26 100644
> --- a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -109,13 +109,16 @@ jobs:
>              Build.Target: "RELEASE"
>              Run.Flags: $(run_flags)
>              Run: $(should_run)
> -          OVMF_IA32X64_FULL_NOOPT:
> -            Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> -            Build.Arch: "IA32,X64"
> -            Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=1 BLD_*_SMM_REQUIRE=1
> BLD_*_TPM2_ENABLE=1 BLD_*_NETWORK_TLS_ENABLE=1 BLD_*_NETWORK_IP6_ENABLE=1
> BLD_*_NETWORK_HTTP_BOOT_ENABLE=1"
> -            Build.Target: "NOOPT"
> -            Run.Flags: $(run_flags)
> -            Run: $(should_run)
> +          # This currently creates a very large image which is too big
> for the FDF declared range,
> +          # skip this build for now.
> +          #
> +          # OVMF_IA32X64_FULL_NOOPT:
> +          #   Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> +          #   Build.Arch: "IA32,X64"
> +          #   Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=1
> BLD_*_SMM_REQUIRE=1 BLD_*_TPM2_ENABLE=1 BLD_*_NETWORK_TLS_ENABLE=1
> BLD_*_NETWORK_IP6_ENABLE=1 BLD_*_NETWORK_HTTP_BOOT_ENABLE=1"
> +          #   Build.Target: "NOOPT"
> +          #   Run.Flags: $(run_flags)
> +          #   Run: $(should_run)
>
>            AMDSEV_X64_DEBUG:
>              Build.File: "$(package)/PlatformCI/AmdSevBuild.py"
> --
> 2.31.1.windows.1
>
>
>
> 
>
>
>

[-- Attachment #2: Type: text/html, Size: 3840 bytes --]

  parent reply	other threads:[~2023-06-21  0:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 11:11 [PATCH] OvmfPkg/PlatformCI: Skip GCC5_OVMF_IA32X64_FULL_NOOPT build Li, Yi
2023-06-20 14:35 ` [edk2-devel] " Gerd Hoffmann
2023-06-21  4:16   ` Yao, Jiewen
2023-06-21  0:40 ` Pedro Falcato [this message]
2023-06-21  4:03   ` Li, Yi
2023-06-21  7:55   ` Gerd Hoffmann
2023-06-21 14:13     ` Pedro Falcato
2023-06-27 10:14       ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKbZUD0+75TDOuhsx6wdTY8zd=cEorDpuBxP2ic6ibFVWkh7rA@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox