From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by mx.groups.io with SMTP id smtpd.web11.6698.1687308019619969843 for ; Tue, 20 Jun 2023 17:40:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=BmS1grId; spf=pass (domain: gmail.com, ip: 209.85.222.54, mailfrom: pedro.falcato@gmail.com) Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-78f6a9800c9so1276862241.3 for ; Tue, 20 Jun 2023 17:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687308018; x=1689900018; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1rUx3d6k0FMPakI7XpJHaKVz0R8gZP+PSeVj2e5NsEg=; b=BmS1grIdGoUmvbFSGhj+9Nc1il9Al0ylEj6exlFQ3Z3wVx39hpW+BqIf3HC6OSm+2r ToLUN38hYbxUEvQbujvygS4VcHBu256BR6bQqrGK/LSxKjNIId7ZkcLhkpMcKPmFFcTQ FwgQorU87gHXfu2l+lpN1FXTZrwht53imfn9INH6J2FxaSIhgskxxUZyaBWflqOwtbDX ywerPPVkeKp8hECnrrfJABwkTOfjBRjWi+XNYI/K3P4LXLGiBJ1dMqeO2WB+zPQadOKK suYKw+rgyuGFsyLvLLeP6feQXpxmAbHXgkRDjDrAi1RosHLScofBu3q7pJVsppivNft0 ULQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687308018; x=1689900018; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1rUx3d6k0FMPakI7XpJHaKVz0R8gZP+PSeVj2e5NsEg=; b=RwLJK5Ind3C7iH/ufnbYCCj8MX65BVMDZJ3wC4MoBqCXrQDzt+ouFEBQ+cyB2Plebm w5rlN7BBiYsPPdYt7xcaJfbnS5OHj7nFYf1yRI660gdu9L+79NnnmBHS5OZAThMvOdIt iWOws2YgE2+ftnPYVcmmZPo82MZff4sgc+T7fyh/eNEUItuaGr8Ft+R+KkdP6xPr/vBZ wfYem2o6g3xvLUB4epcFDvvCJJ+j7b2HMjY8bcmzQ2i7lt6Q8QOpaAxIxSy0G+9Q0+56 JoV5peErXzTSD2a40eG4ecCUZldKZsRmom9YuYfpXG1zyFP8+YTncbwTLaTxsM7mRR2x GDmg== X-Gm-Message-State: AC+VfDz8M+ig6AIMgoxXXEQA09di3aFVLgv5z5rvUtq03ljIt70SvQLH btladeRnlB2RBBeIV9/isx6bMVXf+o/NLAoWTuVaDhfS X-Google-Smtp-Source: ACHHUZ6Q9P9foppAL1TN4f8FSERwLIaAAImAc2pnZtR+5Uj09E4kA6YuLn7V1wBV8lj6q6x6CqeQMGrrpy74cso3fdQ= X-Received: by 2002:a67:f458:0:b0:440:a534:25fb with SMTP id r24-20020a67f458000000b00440a53425fbmr5664743vsn.10.1687308018480; Tue, 20 Jun 2023 17:40:18 -0700 (PDT) MIME-Version: 1.0 References: <20230620111139.21365-1-yi1.li@intel.com> In-Reply-To: <20230620111139.21365-1-yi1.li@intel.com> From: "Pedro Falcato" Date: Wed, 21 Jun 2023 01:40:06 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH] OvmfPkg/PlatformCI: Skip GCC5_OVMF_IA32X64_FULL_NOOPT build To: edk2-devel-groups-io , yi1.li@intel.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann Content-Type: multipart/alternative; boundary="000000000000117b9e05fe990356" --000000000000117b9e05fe990356 Content-Type: text/plain; charset="UTF-8" On Tue, 20 Jun 2023, 12:11 Li, Yi, wrote: > The effect of LTO is limited with optimization turned off, and blocked > the upgrade of Openssl3.0. We already skipped this build with VS2019, > skip the GCC NOOPT build also. > Hi, If LTO is the problem here, have you given ffunction-sections + fdata-sections + gc-sections a spin? It may end up working, though I genuinely don't remember if the GCC toolchain has that on regardless (and wont be able to check foe the next few days)... > Signed-off-by: Yi Li > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > --- > .../PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > index ad43f9fad2..5809152d26 100644 > --- a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > +++ b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > @@ -109,13 +109,16 @@ jobs: > Build.Target: "RELEASE" > Run.Flags: $(run_flags) > Run: $(should_run) > - OVMF_IA32X64_FULL_NOOPT: > - Build.File: "$(package)/PlatformCI/PlatformBuild.py" > - Build.Arch: "IA32,X64" > - Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=1 BLD_*_SMM_REQUIRE=1 > BLD_*_TPM2_ENABLE=1 BLD_*_NETWORK_TLS_ENABLE=1 BLD_*_NETWORK_IP6_ENABLE=1 > BLD_*_NETWORK_HTTP_BOOT_ENABLE=1" > - Build.Target: "NOOPT" > - Run.Flags: $(run_flags) > - Run: $(should_run) > + # This currently creates a very large image which is too big > for the FDF declared range, > + # skip this build for now. > + # > + # OVMF_IA32X64_FULL_NOOPT: > + # Build.File: "$(package)/PlatformCI/PlatformBuild.py" > + # Build.Arch: "IA32,X64" > + # Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=1 > BLD_*_SMM_REQUIRE=1 BLD_*_TPM2_ENABLE=1 BLD_*_NETWORK_TLS_ENABLE=1 > BLD_*_NETWORK_IP6_ENABLE=1 BLD_*_NETWORK_HTTP_BOOT_ENABLE=1" > + # Build.Target: "NOOPT" > + # Run.Flags: $(run_flags) > + # Run: $(should_run) > > AMDSEV_X64_DEBUG: > Build.File: "$(package)/PlatformCI/AmdSevBuild.py" > -- > 2.31.1.windows.1 > > > > > > > --000000000000117b9e05fe990356 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, 20 Jun 2023, 12:11 Li, Yi, <yi1.li@intel.com> wrote:
The effect of LTO is limited with optimization turned off, and bl= ocked
the upgrade of Openssl3.0. We already skipped this build with VS2019,
skip the GCC NOOPT build also.
Hi,

If LTO is the prob= lem here, have you given ffunction-sections + fdata-sections + gc-sections = a spin?

It may end up wo= rking, though I genuinely don't remember if the GCC toolchain has that = on regardless (and wont be able to check foe the next few days)...


Signed-off-by: Yi Li <yi1.li@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
---
=C2=A0.../PlatformCI/.azurepipelines/Ubuntu-GCC5.yml=C2=A0 | 17 ++++++++++-= ------
=C2=A01 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/OvmfPkg/P= latformCI/.azurepipelines/Ubuntu-GCC5.yml
index ad43f9fad2..5809152d26 100644
--- a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
+++ b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
@@ -109,13 +109,16 @@ jobs:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Build.Target: "RELEASE= "
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Run.Flags: $(run_flags)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Run: $(should_run)
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 OVMF_IA32X64_FULL_NOOPT:
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Build.File: "$(package)/Pla= tformCI/PlatformBuild.py"
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Build.Arch: "IA32,X64"=
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Build.Flags: "BLD_*_SECURE_= BOOT_ENABLE=3D1 BLD_*_SMM_REQUIRE=3D1 BLD_*_TPM2_ENABLE=3D1 BLD_*_NETWORK_T= LS_ENABLE=3D1 BLD_*_NETWORK_IP6_ENABLE=3D1 BLD_*_NETWORK_HTTP_BOOT_ENABLE= =3D1"
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Build.Target: "NOOPT"<= br> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Run.Flags: $(run_flags)
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Run: $(should_run)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # This currently creates a very large i= mage which is too big for the FDF declared range,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # skip this build for now.
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # OVMF_IA32X64_FULL_NOOPT:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #=C2=A0 =C2=A0Build.File: "$(packa= ge)/PlatformCI/PlatformBuild.py"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #=C2=A0 =C2=A0Build.Arch: "IA32,X6= 4"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #=C2=A0 =C2=A0Build.Flags: "BLD_*_= SECURE_BOOT_ENABLE=3D1 BLD_*_SMM_REQUIRE=3D1 BLD_*_TPM2_ENABLE=3D1 BLD_*_NE= TWORK_TLS_ENABLE=3D1 BLD_*_NETWORK_IP6_ENABLE=3D1 BLD_*_NETWORK_HTTP_BOOT_E= NABLE=3D1"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #=C2=A0 =C2=A0Build.Target: "NOOPT= "
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #=C2=A0 =C2=A0Run.Flags: $(run_flags) +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #=C2=A0 =C2=A0Run: $(should_run)

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AMDSEV_X64_DEBUG:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Build.File: "$(package= )/PlatformCI/AmdSevBuild.py"
--
2.31.1.windows.1






--000000000000117b9e05fe990356--