Re: [edk2-platforms][PATCH v4 1/1] Ext4Pkg: Fixes double-free in Ext4ReadSymlink

["Pedro Falcato" <pedro.falcato@gmail.com>]

On Fri, Feb 17, 2023 at 5:34 PM Pedro Falcato <pedro.falcato@gmail.com> wrote:
>
> On Fri, Feb 17, 2023 at 8:56 AM Savva Mitrofanov <savvamtr@gmail.com> wrote:
> >
> > The SymlinkTmp was deallocated unconditionally, so we shouldn't free it
> > again on EFI_ERROR
> >
> > Cc: Marvin Häuser <mhaeuser@posteo.de>
> > Cc: Pedro Falcato <pedro.falcato@gmail.com>
> > Cc: Vitaly Cheptsov <vit9696@protonmail.com>
> > Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support")
> > Signed-off-by: Savva Mitrofanov <savvamtr@gmail.com>
> > ---
> >  Features/Ext4Pkg/Ext4Dxe/Symlink.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/Features/Ext4Pkg/Ext4Dxe/Symlink.c b/Features/Ext4Pkg/Ext4Dxe/Symlink.c
> > index 1189a99ded2b..d80cb9fff92e 100644
> > --- a/Features/Ext4Pkg/Ext4Dxe/Symlink.c
> > +++ b/Features/Ext4Pkg/Ext4Dxe/Symlink.c
> > @@ -243,7 +243,6 @@ Ext4ReadSymlink (
> >        Status
> >        ));
> >      FreePool (Symlink16Tmp);
> > -    FreePool (SymlinkTmp);
> >      return Status;
> >    }
> >
> > --
> > 2.39.1
> >
>
> Thank you!
>
> Reviewed-by: Pedro Falcato <pedro.falcato@gmail.com>
>
> --
> Pedro

Pushed to edk2-platforms as 81ec441, with minor corrections (Fixes ->
Fix, as per the standard imperative commit message style).

Thanks!

-- 
Pedro