From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178])
 by mx.groups.io with SMTP id smtpd.web11.5374.1669155150557548638
 for <devel@edk2.groups.io>;
 Tue, 22 Nov 2022 14:12:30 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@gmail.com header.s=20210112 header.b=mfUFkr+W;
 spf=pass (domain: gmail.com, ip: 209.85.214.178, mailfrom: pedro.falcato@gmail.com)
Received: by mail-pl1-f178.google.com with SMTP id k7so14962615pll.6
        for <devel@edk2.groups.io>; Tue, 22 Nov 2022 14:12:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=g/sWNfssEerQ3sU8Z1SMzydcbY6F1eP6mcPTCffvcYQ=;
        b=mfUFkr+W+F5icgLwfUcTuhNcBQklJ3ZllT/7aLoU9NYxQ4skK7J184jGhtp0ltOUDs
         7mhU32cON4LMIOC4+5+zxkBkn0gwWVNEcyLP5vfz4laoTogiVljgCI7PyIgSzAwGyrQq
         62+FKznlEkNu9RGAex5l1bykXo9oRohpgWdPOetPtiv02iNuc7dM2YvBb9PSckufh+wd
         eJiyRA6omXjDTt4aMb+bQ4KNND+5uttHVOgB5J99bGtf4hlZY0MHQLplyalJBj5jRimF
         L2U8UIPZS+CAwxxzMwp3ehLJxI2r/hsE3If7cOCQhsvTesKYmrlovZsSrgw8w4uU2Iqq
         /lwA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=g/sWNfssEerQ3sU8Z1SMzydcbY6F1eP6mcPTCffvcYQ=;
        b=0LPi9H20Dy8YVx8gfuvr/3229CmdGK3VhfsIgWJ6UV+4hccHC61D1YsQeMn/Z3VZZ5
         jZgqs2btJH9Y2NqSIDpGW5ogyQIj4gpxYEqYouxYFRWT66OEGynyGNgc2h1B0TVa94Yc
         douBL/fWmveGPjpiHiRD/4/RCowKEz2iV0JSIJts0AcAm7Fy2KvnwrHitx7GNS/yFGGo
         FTPwxh5A29OyC08l9s2Mc9ZQt5LlGL1IJUTeSacauoef4Zgw7iYmkHLSfSa3psCd928F
         CN9uDv+BWQciXmkosSJUX2+X6DTUzhVWOX5vNgkCJmMcBa4LIQufqqEQ4hLc9JIrVGm8
         4RTA==
X-Gm-Message-State: ANoB5pnhPyyta1XZ3YvZA1ZvV67dHqeXMaUM/vXXLcfCCs/xTwISrtxL
	Y2spCpDPGCSpXqOIEeOpEGS1utQt7NO/8YIMGJELYMqqGsKSbwyu
X-Google-Smtp-Source: AA0mqf54wz3g947HtflFVt3QM/ade5zFF8m4jhepF4n1i0LTsqtVISiukHCXt2oNhaZILW4H7K1D4emFVxmFmFf57oM=
X-Received: by 2002:a17:90a:b291:b0:216:cdf6:54c0 with SMTP id
 c17-20020a17090ab29100b00216cdf654c0mr27485590pjr.34.1669155149802; Tue, 22
 Nov 2022 14:12:29 -0800 (PST)
MIME-Version: 1.0
References: <20221122044708.672-1-abner.chang@amd.com> <CY4PR11MB162238784F0CB3CD6E0D9B888C0D9@CY4PR11MB1622.namprd11.prod.outlook.com>
 <MN2PR12MB39661939E99DEA0A2882ADDFEA0D9@MN2PR12MB3966.namprd12.prod.outlook.com>
 <CO1PR11MB4929407CCB919C67DF0C0F25D20D9@CO1PR11MB4929.namprd11.prod.outlook.com>
In-Reply-To: <CO1PR11MB4929407CCB919C67DF0C0F25D20D9@CO1PR11MB4929.namprd11.prod.outlook.com>
From: "Pedro Falcato" <pedro.falcato@gmail.com>
Date: Tue, 22 Nov 2022 22:12:18 +0000
Message-ID: <CAKbZUD0=_01zrZtNMz2a24QHL0KrwmWwr8PYQJXOOSbXypOUag@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: "Chang, Abner" <Abner.Chang@amd.com>, "Ni, Ray" <ray.ni@intel.com>, 
	"Gao, Liming" <gaoliming@byosoft.com.cn>
Content-Type: multipart/alternative; boundary="000000000000c7737f05ee167771"

--000000000000c7737f05ee167771
Content-Type: text/plain; charset="UTF-8"

On Tue, Nov 22, 2022 at 6:10 PM Michael D Kinney <michael.d.kinney@intel.com>
wrote:

> Hi Abner,
>
> Removing that section 5.4.2.2 is required to close this bug.
>
> Meaning of 'static' is covered by the ANSI C standards.
>

Mike,

Sorry for spinning off a bit, but if we're dropping STATIC, can we also
drop the other defines (like CONST, VOID, etc)?
Potentially culminating into adopting C99 (does any EDK2-relevant C
compiler not support it?).

Pedro

--000000000000c7737f05ee167771
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Tue, Nov 22, 2022 at 6:10 PM Michael D=
 Kinney &lt;<a href=3D"mailto:michael.d.kinney@intel.com">michael.d.kinney@=
intel.com</a>&gt; wrote:</div><div class=3D"gmail_quote"><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">Hi Abner,<br>
<br>
Removing that section 5.4.2.2 is required to close this bug.<br>
<br>
Meaning of &#39;static&#39; is covered by the ANSI C standards.<br></blockq=
uote><div><br></div><div>Mike,</div><div><br></div><div>Sorry for spinning =
off a bit, but if we&#39;re dropping STATIC, can we also drop the other def=
ines (like CONST, VOID, etc)?</div><div>Potentially culminating into adopti=
ng C99 (does any EDK2-relevant C compiler not support it?).<br></div></div>=
<br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Pedro<br></=
div></div></div>

--000000000000c7737f05ee167771--