Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

["Pedro Falcato" <pedro.falcato@gmail.com>]

On Thu, Dec 7, 2023 at 9:08 AM Yuwei Chen <yuwei.chen@intel.com> wrote:
>
> Hi Liming,
>
>
>
> Is this feature been tested and reviewed these two weeks? 😊

Two questions:

1) What testing strategy do you have to test for regressions in such a
huge rewrite?
2) What's the point in shipping this to upstream if you're not aiming
for the replacement of the original VfrCompiler?
3) What's the value of rewriting this in Python? If the existing
VfrCompiler is already working fine (AFAIK?), a python version will
likely just be slower (unless the original C version is super badly
written).
I *seriously* struggle to understand what this Python movement is
supposed to do, except gratuitously rewrite large bits of BaseTools
for a net loss (performance)

-- 
Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112604): https://edk2.groups.io/g/devel/message/112604
Mute This Topic: https://groups.io/mt/102486097/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-