From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F09E6D80144 for ; Fri, 15 Dec 2023 17:04:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MnEp2Xq2igOq63o1IomDOjtWTp5BuOy6nGidAjTcqk0=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702659864; v=1; b=Ja7EG1zWhEPHS1Cu4jIgLobFaK7Rt5UevAQ8JyFTuRb+zvvGRT/BDCuf1pEUlsvoYxxC+nSZ H3e5Z80FUzZes7QzZ4JMzC/NUwPPhjv0FwOOh54Zub1nK+24zOdvRp7P5JS2c+bk0n22lxJVTjB v26wX7wVjXDlKVfgKKRITwkI= X-Received: by 127.0.0.2 with SMTP id a8TCYY7687511xrWbGMIEN5X; Fri, 15 Dec 2023 09:04:24 -0800 X-Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by mx.groups.io with SMTP id smtpd.web10.67487.1702659864042027371 for ; Fri, 15 Dec 2023 09:04:24 -0800 X-Received: by mail-vs1-f41.google.com with SMTP id ada2fe7eead31-4667dd862cdso14863137.1 for ; Fri, 15 Dec 2023 09:04:23 -0800 (PST) X-Gm-Message-State: uGWGhmIHBBAr9p4MMlYcFTqKx7686176AA= X-Google-Smtp-Source: AGHT+IEHR50qS6s+W0bdP/w2ipwHComOdHSypcU3IXCs7oOYwyhPi5ASmRReRHHXuJWMvSRS7IXqS9IjsTCXBRNn9NI= X-Received: by 2002:ac5:c937:0:b0:4b2:c554:d2bd with SMTP id u23-20020ac5c937000000b004b2c554d2bdmr7929993vkl.31.1702659862823; Fri, 15 Dec 2023 09:04:22 -0800 (PST) MIME-Version: 1.0 References: <000001da1317$b227a890$1676f9b0$@byosoft.com.cn> <1797076B3E222792.28092@groups.io> In-Reply-To: From: "Pedro Falcato" Date: Fri, 15 Dec 2023 17:04:11 +0000 Message-ID: Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation To: devel@edk2.groups.io, yuwei.chen@intel.com Cc: "Gao, Liming" , Rebecca Cran , "Zimmer, Vincent" , "Kinney, Michael D" , Leif Lindholm , Andrew Fish , "Feng, Bob C" , "Yang, Yuting2" , "Hartung, Stephen" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Ja7EG1zW; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) On Thu, Dec 7, 2023 at 9:08=E2=80=AFAM Yuwei Chen wr= ote: > > Hi Liming, > > > > Is this feature been tested and reviewed these two weeks? =F0=9F=98=8A Two questions: 1) What testing strategy do you have to test for regressions in such a huge rewrite? 2) What's the point in shipping this to upstream if you're not aiming for the replacement of the original VfrCompiler? 3) What's the value of rewriting this in Python? If the existing VfrCompiler is already working fine (AFAIK?), a python version will likely just be slower (unless the original C version is super badly written). I *seriously* struggle to understand what this Python movement is supposed to do, except gratuitously rewrite large bits of BaseTools for a net loss (performance) --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112604): https://edk2.groups.io/g/devel/message/112604 Mute This Topic: https://groups.io/mt/102486097/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-