From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by mx.groups.io with SMTP id smtpd.web11.5000.1643361185165759953 for ; Fri, 28 Jan 2022 01:13:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VV+iB3mK; spf=pass (domain: gmail.com, ip: 209.85.218.54, mailfrom: pedro.falcato@gmail.com) Received: by mail-ej1-f54.google.com with SMTP id s13so13922256ejy.3 for ; Fri, 28 Jan 2022 01:13:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hIILyIfEMT6HogooNZpyk5yUTkDJCMUM6tsvDgF71H0=; b=VV+iB3mKLiywPUO7f4xniPafG+BKzZayGPbl/gP/BaitzKDDST0kaci2+CPg8j1KiL ehZsSNS3Skh9ZHiUEPrP8CHd7sKK1JyKrZwifrBtmcvToY6YpakTp+nCQ1hm9C5LiPXn Cu8RUQJ97vfjUCDZzo8RVvOXb23V4SMoNCuCYu2/++OKfZkbCFB+Knwz9aDdz40zjJdl tU6b1bU3n2ey8AbXs3BsRJPGxbBan7YkkxGjNxdmm/dLVGw2vsTv/QHQZtA9wpxpG5Oc cGGd+46QCKNdEk83YwTY4Ro/hmbs4A42evFGmUiJfF/OV7IroEgnwPumQDg5ZxT2ty3X 63OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hIILyIfEMT6HogooNZpyk5yUTkDJCMUM6tsvDgF71H0=; b=cf1V/BBlNeqbvklMZtClkQdRXJiZ1UxnKyXY/7B1YBOnIl4wfCsd2B8cFYYC4HHi4n MNzw5bKbZBk6+599d42lWqIw3l654AfWCX7f4N5jAzlpKsN1q2e2mYVI2xOeaslGphQe msEg7vbqhtvXvxMcEaIlgW79KSzvl9UKYK4YWscb9wCW4Fttaxb8w+MoNhyRX5FDo4Kz 5oFmrbTXfNaqKap/zFkucsMudL4PQJ1/AQGf4IUe/vQfg5AASfUWa3ryjCj3laEGVSzP 8pITrWFzZ9seRtxnzbzeN9sPp3286OvToh2yq1nFsSmFmOm0ral+5MOUH7Jy2rh+jnsW vWnw== X-Gm-Message-State: AOAM533uAMNJSZh3XE1EmmXRP7S+P3+7UFaXX/G1tk3Ert4GBdgDRVXF i+qjmi+gZmFe/n89O1v/GOPn8ZM6qpe0DPaZxfA= X-Google-Smtp-Source: ABdhPJyMc9tvVtxEtqbV755DS5uw2KFzUtPtE+ZtOqhUNWCWpMZP3f3a5MH5DKRXa2Kr7OnIJwgXI0wmlEmej4jVqMQ= X-Received: by 2002:a17:907:3fa8:: with SMTP id hr40mr6209643ejc.596.1643361183447; Fri, 28 Jan 2022 01:13:03 -0800 (PST) MIME-Version: 1.0 References: <5d55ef7504d9c460d7fcdda26f890df8feeb8972.1643119699.git.jake@nvidia.com> In-Reply-To: <5d55ef7504d9c460d7fcdda26f890df8feeb8972.1643119699.git.jake@nvidia.com> From: "Pedro Falcato" Date: Fri, 28 Jan 2022 09:12:52 +0000 Message-ID: Subject: Re: [PATCH] Features/Ext4Pkg: Modularize Ext4 DSC/FDF files To: Jake Garver Cc: edk2-devel-groups-io , Jeff Brasen , ashishsingha@nvidia.com Content-Type: multipart/alternative; boundary="00000000000093be7205d6a0d760" --00000000000093be7205d6a0d760 Content-Type: text/plain; charset="UTF-8" Hi, Looks good to me. While I don't 100% understand why one would want this, I know there's a similar pattern in a few packages. All things considered, Reviewed-by: Pedro Falcato I'll wait for a day for any possible comments by other people before merging this. Thanks, Pedro On Tue, Jan 25, 2022 at 2:13 PM Jake Garver wrote: > This change modularizes the Ext4 DSC/FDF files following the model used > in edk2/NetworkPkg. > > A platform DSC can include Ext4 using "!include Features/Ext4.dsc.inc". > Ext.dsc.inc includes all the required information to enable Ext4 > features. Similarly, "!include Features/Ext4.fdf.inc" would be used in > the platform FDF. > > The Ext4 feature is enabled by default, but could be disabled at build > time using: > > BLD_*_EXT4_ENABLE=FALSE > > Signed-off-by: Jake Garver > --- > Features/Ext4Pkg/Ext4.dsc.inc | 16 ++++++++++++++++ > Features/Ext4Pkg/Ext4.fdf.inc | 11 +++++++++++ > Features/Ext4Pkg/Ext4Components.dsc.inc | 14 ++++++++++++++ > Features/Ext4Pkg/Ext4Defines.dsc.inc | 14 ++++++++++++++ > Features/Ext4Pkg/Ext4Libs.dsc.inc | 11 +++++++++++ > 5 files changed, 66 insertions(+) > create mode 100644 Features/Ext4Pkg/Ext4.dsc.inc > create mode 100644 Features/Ext4Pkg/Ext4.fdf.inc > create mode 100644 Features/Ext4Pkg/Ext4Components.dsc.inc > create mode 100644 Features/Ext4Pkg/Ext4Defines.dsc.inc > create mode 100644 Features/Ext4Pkg/Ext4Libs.dsc.inc > > diff --git a/Features/Ext4Pkg/Ext4.dsc.inc b/Features/Ext4Pkg/Ext4.dsc.inc > new file mode 100644 > index 0000000000..b560b9acbb > --- /dev/null > +++ b/Features/Ext4Pkg/Ext4.dsc.inc > @@ -0,0 +1,16 @@ > +## @file > +# Ext4 DSC include file for Platform DSC > +# > +# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & > AFFILIATES. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > +!include Features/Ext4Pkg/Ext4Defines.dsc.inc > + > +[LibraryClasses] > +!include Features/Ext4Pkg/Ext4Libs.dsc.inc > + > +[Components.common] > +!include Features/Ext4Pkg/Ext4Components.dsc.inc > diff --git a/Features/Ext4Pkg/Ext4.fdf.inc b/Features/Ext4Pkg/Ext4.fdf.inc > new file mode 100644 > index 0000000000..fb36070860 > --- /dev/null > +++ b/Features/Ext4Pkg/Ext4.fdf.inc > @@ -0,0 +1,11 @@ > +## @file > +# Ext4 FDF include file for All Architectures. > +# > +# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & > AFFILIATES. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +!if $(EXT4_ENABLE) == TRUE > + INF Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf > +!endif > diff --git a/Features/Ext4Pkg/Ext4Components.dsc.inc > b/Features/Ext4Pkg/Ext4Components.dsc.inc > new file mode 100644 > index 0000000000..34401272a0 > --- /dev/null > +++ b/Features/Ext4Pkg/Ext4Components.dsc.inc > @@ -0,0 +1,14 @@ > +## @file > +# Ext4 DSC include file for [Components] section of all Architectures. > +# > +# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & > AFFILIATES. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +!if $(EXT4_ENABLE) == TRUE > + Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf { > + > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000007 > + } > +!endif > diff --git a/Features/Ext4Pkg/Ext4Defines.dsc.inc > b/Features/Ext4Pkg/Ext4Defines.dsc.inc > new file mode 100644 > index 0000000000..b02eac59cf > --- /dev/null > +++ b/Features/Ext4Pkg/Ext4Defines.dsc.inc > @@ -0,0 +1,14 @@ > +## @file > +# Ext4 DSC include file for [Defines] section of all Architectures. > +# > +# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & > AFFILIATES. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +!ifndef EXT4_ENABLE > + # > + # This flag is to enable or disable the ext4 feature. > + # > + DEFINE EXT4_ENABLE = TRUE > +!endif > diff --git a/Features/Ext4Pkg/Ext4Libs.dsc.inc > b/Features/Ext4Pkg/Ext4Libs.dsc.inc > new file mode 100644 > index 0000000000..078183e0cc > --- /dev/null > +++ b/Features/Ext4Pkg/Ext4Libs.dsc.inc > @@ -0,0 +1,11 @@ > +## @file > +# Ext4 DSC include file for [LibraryClasses] section of all Architectures. > +# > +# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & > AFFILIATES. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +!if $(EXT4_ENABLE) == TRUE > + BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf > +!endif > -- > 2.17.1 > > -- Pedro Falcato --00000000000093be7205d6a0d760 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Looks good to me. While I don't= 100% understand why one would want this, I know there's a similar patt= ern in a few packages.

All things considered,
Reviewed-by: Pedro Falcato <pedro.falcato@gmail.com>

I'll wait= for a day for any possible comments by other people before merging this.

Thanks,
Pedro

On Tue, Jan 25, 2022= at 2:13 PM Jake Garver <jake@nvidia.= com> wrote:
This change modularizes the Ext4 DSC/FDF files following the model used<= br> in edk2/NetworkPkg.

A platform DSC can include Ext4 using "!include Features/Ext4.dsc.inc&= quot;.
Ext.dsc.inc includes all the required information to enable Ext4
features.=C2=A0 Similarly, "!include Features/Ext4.fdf.inc" would= be used in
the platform FDF.

The Ext4 feature is enabled by default, but could be disabled at build
time using:

=C2=A0 =C2=A0 BLD_*_EXT4_ENABLE=3DFALSE

Signed-off-by: Jake Garver <jake@nvidia.com>
---
=C2=A0Features/Ext4Pkg/Ext4.dsc.inc=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0| 16 ++++++++++++++++
=C2=A0Features/Ext4Pkg/Ext4.fdf.inc=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0| 11 +++++++++++
=C2=A0Features/Ext4Pkg/Ext4Components.dsc.inc | 14 ++++++++++++++
=C2=A0Features/Ext4Pkg/Ext4Defines.dsc.inc=C2=A0 =C2=A0 | 14 ++++++++++++++=
=C2=A0Features/Ext4Pkg/Ext4Libs.dsc.inc=C2=A0 =C2=A0 =C2=A0 =C2=A0| 11 ++++= +++++++
=C2=A05 files changed, 66 insertions(+)
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4.dsc.inc
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4.fdf.inc
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4Components.dsc.inc
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4Defines.dsc.inc
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4Libs.dsc.inc

diff --git a/Features/Ext4Pkg/Ext4.dsc.inc b/Features/Ext4Pkg/Ext4.dsc.inc<= br> new file mode 100644
index 0000000000..b560b9acbb
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4.dsc.inc
@@ -0,0 +1,16 @@
+## @file
+# Ext4 DSC include file for Platform DSC
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFI= LIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+!include Features/Ext4Pkg/Ext4Defines.dsc.inc
+
+[LibraryClasses]
+!include Features/Ext4Pkg/Ext4Libs.dsc.inc
+
+[Components.common]
+!include Features/Ext4Pkg/Ext4Components.dsc.inc
diff --git a/Features/Ext4Pkg/Ext4.fdf.inc b/Features/Ext4Pkg/Ext4.fdf.inc<= br> new file mode 100644
index 0000000000..fb36070860
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4.fdf.inc
@@ -0,0 +1,11 @@
+## @file
+# Ext4 FDF include file for All Architectures.
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFI= LIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+!if $(EXT4_ENABLE) =3D=3D TRUE
+=C2=A0 INF Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf
+!endif
diff --git a/Features/Ext4Pkg/Ext4Components.dsc.inc b/Features/Ext4Pkg/Ext= 4Components.dsc.inc
new file mode 100644
index 0000000000..34401272a0
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4Components.dsc.inc
@@ -0,0 +1,14 @@
+## @file
+# Ext4 DSC include file for [Components] section of all Architectures.
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFI= LIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+!if $(EXT4_ENABLE) =3D=3D TRUE
+=C2=A0 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf {
+=C2=A0 =C2=A0 <PcdsFixedAtBuild>
+=C2=A0 =C2=A0 =C2=A0 gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80= 000007
+=C2=A0 }
+!endif
diff --git a/Features/Ext4Pkg/Ext4Defines.dsc.inc b/Features/Ext4Pkg/Ext4De= fines.dsc.inc
new file mode 100644
index 0000000000..b02eac59cf
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4Defines.dsc.inc
@@ -0,0 +1,14 @@
+## @file
+# Ext4 DSC include file for [Defines] section of all Architectures.
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFI= LIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+!ifndef EXT4_ENABLE
+=C2=A0 #
+=C2=A0 # This flag is to enable or disable the ext4 feature.
+=C2=A0 #
+=C2=A0 DEFINE EXT4_ENABLE =3D TRUE
+!endif
diff --git a/Features/Ext4Pkg/Ext4Libs.dsc.inc b/Features/Ext4Pkg/Ext4Libs.= dsc.inc
new file mode 100644
index 0000000000..078183e0cc
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4Libs.dsc.inc
@@ -0,0 +1,11 @@
+## @file
+# Ext4 DSC include file for [LibraryClasses] section of all Architectures.=
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFI= LIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+!if $(EXT4_ENABLE) =3D=3D TRUE
+=C2=A0 BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.= inf
+!endif
--
2.17.1



--
Pedro Falcato
--00000000000093be7205d6a0d760--