Re: [edk2-devel] [PATCH v2 3/5] OvmfPkg/ResetVector: improve page table flag names

["Pedro Falcato" <pedro.falcato@gmail.com>]

On Wed, Jan 31, 2024 at 11:23 AM Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 1/31/24 09:14, Gerd Hoffmann wrote:
> >   Hi,
> >
> >>> Technically, if we want to be pedantic, these are PDPTEs (or PDPs I
> >>> guess), so PDE is misleading here.
> >>
> >> I remembered the fact that the SDM used different terms for different
> >> table levels, but honestly, I've never been able to keep all those in my
> >> mind for longer than 5 minutes. I recall them as fairly arbitrary.
> >
> > The names made sense back in the 90-ies when we had only two or three
> > (with PAE) paging levels on x86.  Nowdays with up to 5 levels not so
> > much.  I likewise can't remember all the names, so I very much prefer
> > to work with level numbers.
> >
> > The bits for the lowest level are slightly different from all levels
> > above,
>
> Right; I've not checked recently (and I certainly can't just recall the
> details), but this has been my "operating impression" anyway, and I felt
> that your macro names were a good match:
>
> > and I've used the level 1 + level 2 names (page table entry and
> > page directory entry) to name them.
>
> Pedro, what say you?

It was just a random comment, do whatever you think is more
maintainable/worth it. It's not like it makes much of a difference, I
just wanted the define to be unambiguous.
Something generic like HUGE_PAGE_ATTR would also work IMO (even if
hugepage is a super overloaded and confusing term in the kernel world
- ooh boy let's not get into that :P).

-- 
Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114912): https://edk2.groups.io/g/devel/message/114912
Mute This Topic: https://groups.io/mt/104052210/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-