From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 82D79740032 for ; Wed, 31 Jan 2024 17:50:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Dt3qNVv/Acylung9ImXiTJLLLPRzxAQUNFjrCkOGa4E=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706723454; v=1; b=j/6tQANQvVKdc4wYfK3FhbOJmJ1/WfHCPwMx88FYAm6H1dWpWypNOUA9bzfn4rclGrLILanZ x/hMrUMrhPKyIyQPiMzGwulvXmQM/b6spcb4U5XGy0qSlUt2WyH3b+Oj6jKaG7ooPn+oQ6oizf9 qaJhPo/jmfzQGbC3ho77ZCHQ= X-Received: by 127.0.0.2 with SMTP id ILKJYY7687511xmmsy3wKA7W; Wed, 31 Jan 2024 09:50:54 -0800 X-Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) by mx.groups.io with SMTP id smtpd.web10.1675.1706723453569590205 for ; Wed, 31 Jan 2024 09:50:53 -0800 X-Received: by mail-vk1-f177.google.com with SMTP id 71dfb90a1353d-4bd9fd9eb7aso33302e0c.1 for ; Wed, 31 Jan 2024 09:50:53 -0800 (PST) X-Gm-Message-State: bSw15KtKxbRyY5amlPFVTRjwx7686176AA= X-Google-Smtp-Source: AGHT+IEOJfE+UK2PBjlgTgz3UN7tQbkVQ/OsJfdsa6pw2hzeyE90IdKVv81xrxlPLLCn4KtInF7TAcf9jJa5P6YN3c8= X-Received: by 2002:a05:6122:368e:b0:4b7:8d7c:346f with SMTP id ec14-20020a056122368e00b004b78d7c346fmr1932872vkb.9.1706723452586; Wed, 31 Jan 2024 09:50:52 -0800 (PST) MIME-Version: 1.0 References: <20240130123204.764453-1-kraxel@redhat.com> <20240130123204.764453-4-kraxel@redhat.com> <69c99682-80b5-274d-4f8e-c8c8f4ed5e7a@redhat.com> <93b2aa7c-0159-a474-962a-1270630c8fd9@redhat.com> In-Reply-To: <93b2aa7c-0159-a474-962a-1270630c8fd9@redhat.com> From: "Pedro Falcato" Date: Wed, 31 Jan 2024 17:50:41 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH v2 3/5] OvmfPkg/ResetVector: improve page table flag names To: Laszlo Ersek Cc: devel@edk2.groups.io, kraxel@redhat.com, Erdem Aktas , Oliver Steffen , Jiewen Yao , Ard Biesheuvel , Min Xu , Tom Lendacky , Michael Roth , Liming Gao Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="j/6tQANQ"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Jan 31, 2024 at 11:23=E2=80=AFAM Laszlo Ersek w= rote: > > On 1/31/24 09:14, Gerd Hoffmann wrote: > > Hi, > > > >>> Technically, if we want to be pedantic, these are PDPTEs (or PDPs I > >>> guess), so PDE is misleading here. > >> > >> I remembered the fact that the SDM used different terms for different > >> table levels, but honestly, I've never been able to keep all those in = my > >> mind for longer than 5 minutes. I recall them as fairly arbitrary. > > > > The names made sense back in the 90-ies when we had only two or three > > (with PAE) paging levels on x86. Nowdays with up to 5 levels not so > > much. I likewise can't remember all the names, so I very much prefer > > to work with level numbers. > > > > The bits for the lowest level are slightly different from all levels > > above, > > Right; I've not checked recently (and I certainly can't just recall the > details), but this has been my "operating impression" anyway, and I felt > that your macro names were a good match: > > > and I've used the level 1 + level 2 names (page table entry and > > page directory entry) to name them. > > Pedro, what say you? It was just a random comment, do whatever you think is more maintainable/worth it. It's not like it makes much of a difference, I just wanted the define to be unambiguous. Something generic like HUGE_PAGE_ATTR would also work IMO (even if hugepage is a super overloaded and confusing term in the kernel world - ooh boy let's not get into that :P). --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114912): https://edk2.groups.io/g/devel/message/114912 Mute This Topic: https://groups.io/mt/104052210/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-