From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>, kraxel@redhat.com
Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>, Bob Feng <bob.c.feng@intel.com>,
Rebecca Cran <rebecca@bsdio.com>,
James Bottomley <jejb@linux.ibm.com>,
Sami Mujawar <Sami.Mujawar@arm.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
Sebastien Boeuf <sebastien.boeuf@intel.com>,
Zhichao Gao <zhichao.gao@intel.com>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Maciej Rabeda <maciej.rabeda@linux.intel.com>,
Maurice Ma <maurice.ma@intel.com>, Andrew Fish <afish@apple.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
Peter Grehan <grehan@freebsd.org>,
Sean Brogan <sean.brogan@microsoft.com>,
Guomin Jiang <guomin.jiang@intel.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
Yuwei Chen <yuwei.chen@intel.com>,
Benjamin You <benjamin.you@intel.com>,
Daniel Schaefer <daniel.schaefer@hpe.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>,
Wei6 Xu <wei6.xu@intel.com>, Jian J Wang <jian.j.wang@intel.com>,
Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
Guo Dong <guo.dong@intel.com>,
kilian_kegel@hotmail.com, Abner Chang <abner.chang@hpe.com>,
Oliver Steffen <osteffen@redhat.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Min Xu <min.m.xu@intel.com>, Ray Ni <ray.ni@intel.com>,
Alexei Fedorov <Alexei.Fedorov@arm.com>,
Julien Grall <julien@xen.org>, Nickle Wang <nickle.wang@hpe.com>,
Pawel Polawski <ppolawsk@redhat.com>,
Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics
Date: Tue, 15 Mar 2022 17:08:55 +0000 [thread overview]
Message-ID: <CAKbZUD0FNrOMFZFEmZ-hc+gO7+AjKbfNzapTd-SPtt3csfGpgw@mail.gmail.com> (raw)
In-Reply-To: <20220315122242.xwi2xckfos2c3cff@sirius.home.kraxel.org>
[-- Attachment #1: Type: text/plain, Size: 1746 bytes --]
Gerd,
Have you considered just pulling in LLVM's compiler-rt builtins? It
implements essentially everything we'll ever need for a GNU-like toolchain,
for all the architectures we support, and also has unit tests (
https://github.com/llvm/llvm-project/tree/main/compiler-rt/test/builtins/Unit
).
I think it would be a good idea considering it's guaranteed to be correct
and always implements whatever clang requires (and AFAIK clang always
requires what gcc requires).
Best regards,
Pedro
On Tue, Mar 15, 2022 at 12:23 PM Gerd Hoffmann <kraxel@redhat.com> wrote:
> On Tue, Mar 01, 2022 at 08:18:17AM +0100, Gerd Hoffmann wrote:
> > This is an attept to start cleaning up the messy compiler intrinsics
> > situation. Today we don't have a core intrinsics library, resulting
> > in everybody creating their own. ArmPkg has one, CryptoPkg has one.
> > I'm sure there are many more.
> >
> > This doesn't make sense. Given we can't avoid compiler intrinsics (as
> > proven by the existence of those libraries) we should better have them
> > as core library so we have to maintain a single version only.
> >
> > Given we already have BaseIoLibIntrinsic in MdePkg we can place the
> > compiler intrinsics there too. This little patch series does just that:
> > It moves over the existing ArmPkg intrinsics, fixes them to build on
> > non-arm too, and adds additional bits from the CryptoPkg intrinsics.
>
> Ping. How go forward with this? I've posted it as RFC because
> I expected a more controversial discussion. But seems everybody
> agrees this is a step into the right direction.
>
> So just merge this as-is?
>
> Yes, it passed CI (https://github.com/tianocore/edk2/pull/2542).
>
> take care,
> Gerd
>
>
>
>
>
>
>
--
Pedro Falcato
[-- Attachment #2: Type: text/html, Size: 2563 bytes --]
next prev parent reply other threads:[~2022-03-15 17:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 7:18 [PATCH 0/3] [RFC] consolidate compiler intrinsics Gerd Hoffmann
2022-03-01 7:18 ` [PATCH 1/3] MdePkg: promote CompilerIntrinsicsLib from ArmPkg to MdePkg Gerd Hoffmann
2022-03-01 7:18 ` [PATCH 2/3] MdePkg/CompilerIntrinsicsLib: fix msft sources for x64 Gerd Hoffmann
2022-03-01 7:18 ` [PATCH 3/3] MdePkg/CompilerIntrinsicsLib: move ia32 intrinsics and strcmp Gerd Hoffmann
2022-03-02 2:06 ` 回复: [edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics gaoliming
2022-03-02 2:16 ` Yao, Jiewen
2022-03-02 8:39 ` Kilian Kegel
2022-03-02 10:10 ` Gerd Hoffmann
2022-03-02 6:12 ` Ard Biesheuvel
2022-03-15 12:22 ` Gerd Hoffmann
2022-03-15 15:27 ` Michael D Kinney
2022-03-16 9:45 ` [edk2-devel] " Gerd Hoffmann
2022-03-18 1:26 ` 回复: " gaoliming
2022-03-18 1:54 ` Pedro Falcato
2022-03-15 17:08 ` Pedro Falcato [this message]
2022-03-16 10:02 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKbZUD0FNrOMFZFEmZ-hc+gO7+AjKbfNzapTd-SPtt3csfGpgw@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox