public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: devel@edk2.groups.io, sunilvl@ventanamicro.com
Cc: Gavin Xue <gavin.xue@intel.com>,
	Andrei Warkentin <andrei.warkentin@intel.com>,
	 Yimin Wang <yimin.wang@intel.com>,
	Alan Sheng <alan.sheng@intel.com>
Subject: Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64
Date: Fri, 16 Jun 2023 15:11:35 +0100	[thread overview]
Message-ID: <CAKbZUD0M3cEAm8SWEEHUJCGtJ2AmPQkZV0btCpgNVem_pQUr7A@mail.gmail.com> (raw)
In-Reply-To: <ZIw7DVomUn50XHCM@sunil-laptop>

On Fri, Jun 16, 2023 at 11:36 AM Sunil V L <sunilvl@ventanamicro.com> wrote:
>
> On Fri, Jun 16, 2023 at 03:22:57PM +0800, Gavin Xue wrote:
> > Different symbol (PROCESSOR_BIND_H__) define in RISCV64 ProcessorBinding.h
> > from other CPU Arch. An unexception compilation error generated
> > if include __PROCESSOR_BIND_H__ symbol in header file for
> > cross-platform compiling.

(replying through Sunil's reply as the original email doesn't seem to
have been sent to the list)

What exactly is the problem here? The header has its include guard,
you include it once, it defines PROCESSOR_BIND_H__, you include it
twice, the #ifndef doesn't pass and nothing gets "included" again.
I really don't understand what your problem is, here. Particularly the
__PROCESSOR_BIND_H__ inclusion bit, this all seems like a giant hack.

-- 
Pedro

  reply	other threads:[~2023-06-16 14:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16  7:22 [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64 Gavin Xue
2023-06-16 10:35 ` Sunil V L
2023-06-16 14:11   ` Pedro Falcato [this message]
2023-06-16 15:51     ` [edk2-devel] " Xue, Gavin
2023-06-21 14:16       ` Pedro Falcato
2023-06-22  9:58         ` Xue, Gavin
2023-06-22 15:45           ` Pedro Falcato
2023-06-27 20:29           ` Michael D Kinney
2023-06-30  9:28             ` Xue, Gavin
2023-06-30 16:59               ` Michael D Kinney
2023-07-03  9:01                 ` Xue, Gavin
2023-07-03 17:01                 ` Pedro Falcato
2023-07-04  9:39                   ` Xue, Gavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKbZUD0M3cEAm8SWEEHUJCGtJ2AmPQkZV0btCpgNVem_pQUr7A@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox