Re: [PATCH 0/2] ExtPkg Updates

["Pedro Falcato" <pedro.falcato@gmail.com>]

Hi Jeff,

Thanks for the patches! It's great that Ext4Pkg is already getting used!

I've looked at each patch and replied with feedback.
In general, they look good, although there are some minor issues. I
hadn't thought of the 1st patch but the 2nd seemed inevitable
for real world systems that may not unmount cleanly.

Best regards,

Pedro


On Thu, Sep 9, 2021 at 9:41 PM Jeff Brasen <jbrasen@nvidia.com> wrote:
>
> I have been using the new Ext4Pkg and been pretty successful and it is solving a use case we had.
>
> Had a couple updates to propose
>
> 1. Changed the implementation of the binding protocol to both check if the driver is already bound
> to the partition as well as added a really quick check to validate the magic value in supported.
> This improves performance when you have a large number of non-ext4 partitions on the system.
>
> 2. As we are planning on using this for boot support we want to support unclean filesystem states in
> case the user doesn't reset cleanly. I added a check if the recovery journal is present and if so treat
> the filesystem as read-only (I know the driver is only RO at this point, but figured if you added write
> support prior to recovery journal support we would want that). With this everything seems to work great.
> I can add this under a FeaturePcd if desired as well.
>
> Change log
>
> v1 - Initial revision
>
> Jeff Brasen (2):
>   Ext4Pkg: Improve Binding support behavior
>   Ext4Pkg: Support non-cleanlty unmounted filesystems
>
>  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h    | 14 +++++++
>  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c    | 57 +++++++++++++++++++++------
>  Features/Ext4Pkg/Ext4Dxe/Superblock.c | 45 +++++++++++++++++++--
>  3 files changed, 99 insertions(+), 17 deletions(-)
>
> --
> 2.17.1
>


-- 
Pedro Falcato