From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) by mx.groups.io with SMTP id smtpd.web09.5031.1631248839544239174 for ; Thu, 09 Sep 2021 21:40:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=K/ID97b7; spf=pass (domain: gmail.com, ip: 209.85.221.172, mailfrom: pedro.falcato@gmail.com) Received: by mail-vk1-f172.google.com with SMTP id g18so195156vkq.8 for ; Thu, 09 Sep 2021 21:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FaJR+7UQ87iD/tS0ijGotLZ4tJNOnuz1J1YcdRcUVfg=; b=K/ID97b7JeowFwPNRdpRCL3OQGDFyncnRyz3MWfoQRZRvaOJad72hQWtWu/TUzFLAo fwdrRN6i5J+MBST2LLzdNvEQPyQp9qIwv+9IBErqhHR5LMpw5seaOLuKetSQctnuEzmI nwY7YyA7tSvImYhRRUC/zzGkopDAn1/erGof3GFnz4K9Zh3nqJZhtX+D0thv56vl9C7l UxAz4GvdTdSa5D9DTK2iDqjF5n0SzJL/mTcXIblYGVip186NkRVRrnJdmu0UUBoNX+9Q INP1FO1xdTN1SoAkg85z3Xt2sPj9Nptr8gX/IM36uiYi+k0rP0iWFVAIY7PjeuyeNiqM m2IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FaJR+7UQ87iD/tS0ijGotLZ4tJNOnuz1J1YcdRcUVfg=; b=nL3zc0TF8BOSz7OcMvdiBzhlV99uKYByrVZhZ2Ep9MxPsKcsC7QpvDj6660FYUwf6G Sxa8XoGS1SY4LT/yObkkCpMvdQgWyzT6bw9Jbm2PAzR2PIpgLJnzf65xwxDXsZdRozEI P1rXkNvWiwZhMGslqtOQ85snmrxv5k5SzqY8R+q6aZjm1b51u5baPv1hJmedkRW8I9fj AQI3DHlCOCsW/BV11Xv1RpYjv2UoEwBJ9vV2NibahgnfWM4Nqknngai0QjNqa6EI1cYN ugUk0LBfx8sMbO3dSvBkzJyFZ0iifGk36vI6G/ATPcDZyekM70Bb/CWQB40/gPRqDmRK Cevw== X-Gm-Message-State: AOAM532xg6z7fY7iRV0FiVJi+IgNU7V442l2RYSc0k5SApymhRNMzRgC sP4HCJ0nhu6h1esXLzGLpKZ4ZiFUiw0DXCPEEeI= X-Google-Smtp-Source: ABdhPJyPSH3FhDcixSy5qUACpY3HVBfNihxta3SadjWhzrnuwbdF0yv4qydvPsra5Dfs5Q2zBnE2iun52mNvuiwL6b4= X-Received: by 2002:a1f:d902:: with SMTP id q2mr4356015vkg.20.1631248838728; Thu, 09 Sep 2021 21:40:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Fri, 10 Sep 2021 05:40:28 +0100 Message-ID: Subject: Re: [PATCH 0/2] ExtPkg Updates To: Jeff Brasen Cc: edk2-devel-groups-io Content-Type: text/plain; charset="UTF-8" Hi Jeff, Thanks for the patches! It's great that Ext4Pkg is already getting used! I've looked at each patch and replied with feedback. In general, they look good, although there are some minor issues. I hadn't thought of the 1st patch but the 2nd seemed inevitable for real world systems that may not unmount cleanly. Best regards, Pedro On Thu, Sep 9, 2021 at 9:41 PM Jeff Brasen wrote: > > I have been using the new Ext4Pkg and been pretty successful and it is solving a use case we had. > > Had a couple updates to propose > > 1. Changed the implementation of the binding protocol to both check if the driver is already bound > to the partition as well as added a really quick check to validate the magic value in supported. > This improves performance when you have a large number of non-ext4 partitions on the system. > > 2. As we are planning on using this for boot support we want to support unclean filesystem states in > case the user doesn't reset cleanly. I added a check if the recovery journal is present and if so treat > the filesystem as read-only (I know the driver is only RO at this point, but figured if you added write > support prior to recovery journal support we would want that). With this everything seems to work great. > I can add this under a FeaturePcd if desired as well. > > Change log > > v1 - Initial revision > > Jeff Brasen (2): > Ext4Pkg: Improve Binding support behavior > Ext4Pkg: Support non-cleanlty unmounted filesystems > > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 14 +++++++ > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 57 +++++++++++++++++++++------ > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 45 +++++++++++++++++++-- > 3 files changed, 99 insertions(+), 17 deletions(-) > > -- > 2.17.1 > -- Pedro Falcato