Re: FW: [PATCH v2 2/3] MdePkg: Support FDT library.

["Pedro Falcato" <pedro.falcato@gmail.com>]

+CC edk2-devel, It seems that you dropped it accidentally.

On Thu, Apr 13, 2023 at 7:30 PM Pedro Falcato <pedro.falcato@gmail.com> wrote:
>
> On Thu, Apr 13, 2023 at 5:53 PM Kinney, Michael D
> <michael.d.kinney@intel.com> wrote:
> >
> > Hi Pedro,
> >
> > Any comments in this new version?  Have your concerns been addressed, especially libc conformance.
> >
> > Mike
>
> Mike,
>
> I'm really sorry but I'm dealing with serious personal issues so I
> can't give you much feedback
>
> However I skimmed through the patch and it looks okay to me, if you
> add my copyright to the file with the libc implementations (as those
> were taken from LibcLib's patch). And possibly my signed-off-by but
> I'll leave that to your criteria.
>
> I still don't see much point in the libfdt wrapping code. Benny says
> it's due to EDK2 style, you say it's for stability/modularity reasons.
> I personally don't see much point in writing whole wrappers due to
> style, and libfdt is AIUI very much something  that has been mostly
> stable over time. In any case, do what you think is best. I'll trust
> your judgement and I won't block this patch for it.
>
> So with all that addressed, Acked-by: Pedro Falcato <pedro.falcato@gmail.com>
>
> Thank you,
> Pedro



-- 
Pedro