From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mx.groups.io with SMTP id smtpd.web11.21757.1681410715724803850 for ; Thu, 13 Apr 2023 11:31:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20221208 header.b=STAqAUe2; spf=pass (domain: gmail.com, ip: 209.85.216.43, mailfrom: pedro.falcato@gmail.com) Received: by mail-pj1-f43.google.com with SMTP id h24-20020a17090a9c1800b002404be7920aso16185092pjp.5 for ; Thu, 13 Apr 2023 11:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681410715; x=1684002715; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K57LGJA+G/UlTD9qrGkA/lYhLUMrhDab1IoKHwMyzL0=; b=STAqAUe269Q2RkkfVJXySBWaMPdAF6Qt5imkgZBZOPWiq/i8lcZD7zCRinruWMMv1o KQ0gUpFKHGSbjeNo8luHvVxMqi+SWgz32r3BgbB9uzoGC6aT8w45y3mw2PnZLBM/Q97c 2MweYyCVNUSr9iMSU5zxJcvvpF4Talc9Vg1CkjOkAbzOTjzIgJIIl6cXSmYvcCRurehN c2XbpCKZBj47jq6++0zIMICwwRZqPJzGbP2U+xACVodVXDwGnVmzm95zMgvMxykw7/9E RDERyWBfhV5Sdr3O4tMmpz9xGXQx8ycvf6Hybi0SsixnEYfE5fmRPRjCDyOJCwiBuGe5 85Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681410715; x=1684002715; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K57LGJA+G/UlTD9qrGkA/lYhLUMrhDab1IoKHwMyzL0=; b=iB7vC4+jYsqodfwWXKZN94zGccKwlyMHbeTcOB+ZAxh/0SbeunSOXCR7Gbb5smPJFk 6zDObYnb+Fo4iLGVX/4FuRksHlmDg9fs7cLb/IV0XR31LySlWZqOu97vgOsFurS0vMl2 NN1o14Q99ooHOYjGRgKAmLQm8PM/k9LllVCvNavQS7PDH5K+Tv3pDhRUkSXWa64HPzcH nVBbUmvVcqfG+k9UuRdk5BWGrFzOi16qHzvCiY0IKuj4T0GCpacf4Un/1RrhCNgdYWyr scR5R2aj6hqgZ4xGNrUpaQe/G2lynVRp1rvGepnMMj7bZ7gH99DjtLG7esv+M/DgCdzf Cx8w== X-Gm-Message-State: AAQBX9chZhIYDhQdWBZk6iKQBzQgJ1X+NwUEWD30VUsvtrgR4/122lyQ bumr4A5JMuAyfMegIzQO0uyx0MW9jL32t4VODts= X-Google-Smtp-Source: AKy350ZBLdxXnquIGiA14DuELWQb+lnbEz5qS//jd5Dh6p1sckUTDPM7QpU9kK1NsTTCAe0KM06JR1roCsz3Bdxu7t0= X-Received: by 2002:a17:902:f802:b0:1a1:f9f5:4dac with SMTP id ix2-20020a170902f80200b001a1f9f54dacmr837720plb.5.1681410714866; Thu, 13 Apr 2023 11:31:54 -0700 (PDT) MIME-Version: 1.0 References: <20230412183606.887-1-benny.lin@intel.com> <20230412183606.887-3-benny.lin@intel.com> In-Reply-To: From: "Pedro Falcato" Date: Thu, 13 Apr 2023 19:31:43 +0100 Message-ID: Subject: Re: FW: [PATCH v2 2/3] MdePkg: Support FDT library. To: "Kinney, Michael D" Cc: edk2-devel-groups-io Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable +CC edk2-devel, It seems that you dropped it accidentally. On Thu, Apr 13, 2023 at 7:30=E2=80=AFPM Pedro Falcato wrote: > > On Thu, Apr 13, 2023 at 5:53=E2=80=AFPM Kinney, Michael D > wrote: > > > > Hi Pedro, > > > > Any comments in this new version? Have your concerns been addressed, e= specially libc conformance. > > > > Mike > > Mike, > > I'm really sorry but I'm dealing with serious personal issues so I > can't give you much feedback > > However I skimmed through the patch and it looks okay to me, if you > add my copyright to the file with the libc implementations (as those > were taken from LibcLib's patch). And possibly my signed-off-by but > I'll leave that to your criteria. > > I still don't see much point in the libfdt wrapping code. Benny says > it's due to EDK2 style, you say it's for stability/modularity reasons. > I personally don't see much point in writing whole wrappers due to > style, and libfdt is AIUI very much something that has been mostly > stable over time. In any case, do what you think is best. I'll trust > your judgement and I won't block this patch for it. > > So with all that addressed, Acked-by: Pedro Falcato > > Thank you, > Pedro --=20 Pedro