From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mx.groups.io with SMTP id smtpd.web11.91705.1684164551697529822 for ; Mon, 15 May 2023 08:29:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20221208 header.b=KiXR72xD; spf=pass (domain: gmail.com, ip: 209.85.210.173, mailfrom: pedro.falcato@gmail.com) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-643557840e4so13964147b3a.2 for ; Mon, 15 May 2023 08:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684164551; x=1686756551; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xEpaPAuhPeXas249dnegOjyaUzzQTj9p5z4wsmdGDso=; b=KiXR72xDLxK+RDRkXLLq5Gtu+lcMauKPYM/oEcN3ZOIanyVGgpIIKo9ubUM+vyihkT 1Ry3V4i/g56CPZRKFEDgVeBkB9/Ki5w/DGj6k5Yix8NFZnmMXwGz5785dktDYofyD4sC pa4SDP4VylsFo/0uiNmqhr38sfMh3Ixt3wKDLl75MWodHanjI81wM7S5Gl8mghRMZfyk beXN1N1g1/CjLNeXWt8syVCZn3JWYB/eRv6Yk2Hm5sTF5Tl3qtbFSOgGJVIW41Mup0UV 2bzEbM0KowNZt455PBGe69AKI4EOHBQZFligk+OSYMBgzz3wj1FMbMPw8v3CXaIoVgTx 8aLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684164551; x=1686756551; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xEpaPAuhPeXas249dnegOjyaUzzQTj9p5z4wsmdGDso=; b=lF0TjIpJ00sMAFcEn9tKV2yOXYIZQK2CHmNF+8VXpU2Qz53hZWLgx/7h+GLZv0+Wme Bnrzq6Vzp2/27PQHAA29k1f5M6q1OMn8UFjLDIyB148hiML8OTjTen015rV1E/1w2yZD 0LT/hQkMDBDBXgChPiLoXNT9g1xLZ9yPh/IarpnK5ptE4K3AwABTARyDTjyHxnHXBzT0 +W3iOy8mfKAnmLr+UeFQm1vcjLN48w1bBk7DDPoHxJAHC153wRfSBniZf224G/V9yK1/ 80WzNUzEuI9PDSMg6NMXR5LxxpvFaNTsP6bcBpj7zhvhE75lbAumnMg3KnUKw56p2oxm lUrQ== X-Gm-Message-State: AC+VfDywnsP4SaxkE44VT7jwUZZcWG1FoQ8AHDhXmE20LejYneFaOrZs jB6yYgkK/0XSihMO9dA0omgLqjIYyHMzyUiD9iE= X-Google-Smtp-Source: ACHHUZ56lmf4ruMiURpJayOSgxWIrrwLq4Co1xfh5gxzrWAX5QCZSAw2CGmzauqFWC5kahWcS8banD2fon9ND/OIj8A= X-Received: by 2002:a05:6a20:7daa:b0:100:ab42:5457 with SMTP id v42-20020a056a207daa00b00100ab425457mr32523901pzj.22.1684164551119; Mon, 15 May 2023 08:29:11 -0700 (PDT) MIME-Version: 1.0 References: <20230515144539.176967-1-pedro.falcato@gmail.com> <9bc20ea6-3bb6-8b13-ea9f-790bcbed71ea@bsdio.com> <43C66EEC-4489-4D1D-B345-04CC7AB83670@posteo.de> In-Reply-To: <43C66EEC-4489-4D1D-B345-04CC7AB83670@posteo.de> From: "Pedro Falcato" Date: Mon, 15 May 2023 16:29:00 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/Base.h: Simply alignment expressions To: =?UTF-8?Q?Marvin_H=C3=A4user?= Cc: Rebecca Cran , edk2-devel-groups-io , Michael D Kinney , Liming Gao , Zhiguang Liu , Gerd Hoffmann Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, May 15, 2023 at 4:20=E2=80=AFPM Marvin H=C3=A4user wrote: > > Well, I explicitly added this macro as a prerequisite to code used in our= new PE library (remember this patch was initially sent in 2021). We still = require it downstream, but obviously upstream is not interested in the rela= ted contributions that were to follow at the time. > > Gerd picked it up because he wanted to attempt to re-try contributing the= new PE library, but I haven't heard from him in weeks. > > Design-wise, I agree it could be removed again. However, there first was = a downstream burden when adding it (as we needed to rewrite our history to = drop our downstream patch in favour of the upstream solution). Now introduc= ing another downstream burden *again* to remove the macro that was added on= ly a few weeks back would be a sign of poor management and planning. I don't agree with the removal of the macro. It's useful enough to consumers of Base.h, and clearly there's code that is indeed actively using it. It's also a single line of code. --=20 Pedro