From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 44A6F740038 for ; Fri, 1 Dec 2023 20:50:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=VEPiAw/vXnXWrHN1NPRfxiQAkS2rbfl6fiF/taaczoo=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701463852; v=1; b=u9fTTafIYwauSm9kAtHsSgUcSM+PrUmn3vsKg12QeUIA+w3DYnqCPxxHYOdBv6MlnEJjoUik QccCLDC1p3HGWbwnUZUkuVUX5jtM3uW6pG3QWWrzFPTEgCKymUpdLS9CaQOZSoVgXkdpvpIIjhe ZarsKaax7zVV53RdsD84L4K0= X-Received: by 127.0.0.2 with SMTP id qDP3YY7687511xa4WfByyucy; Fri, 01 Dec 2023 12:50:52 -0800 X-Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by mx.groups.io with SMTP id smtpd.web10.3880.1701463852146603534 for ; Fri, 01 Dec 2023 12:50:52 -0800 X-Received: by mail-ua1-f49.google.com with SMTP id a1e0cc1a2514c-7c500dcdd7dso784565241.1 for ; Fri, 01 Dec 2023 12:50:52 -0800 (PST) X-Gm-Message-State: cMNREU8pjP2YMVsMfW9YmaNPx7686176AA= X-Google-Smtp-Source: AGHT+IG8SkIIP5J7bjBcrh2B7O2NPoSK/DFB94tJtm99qVGzrTHbVH9nThkFeG+QOkvPq82C5Q+OddiNW2suHQmPvdE= X-Received: by 2002:a67:e451:0:b0:464:42ff:291c with SMTP id n17-20020a67e451000000b0046442ff291cmr182451vsm.5.1701463850796; Fri, 01 Dec 2023 12:50:50 -0800 (PST) MIME-Version: 1.0 References: <20231130224214.86027-1-pedro.falcato@gmail.com> <20231130224214.86027-2-pedro.falcato@gmail.com> <3a8ceb26-6fe9-4a1a-96d2-e74f7b3e7baf@linux.microsoft.com> In-Reply-To: <3a8ceb26-6fe9-4a1a-96d2-e74f7b3e7baf@linux.microsoft.com> From: "Pedro Falcato" Date: Fri, 1 Dec 2023 20:50:38 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/2] UnitTestFrameworkPkg: Fix Google Test components with multiple files To: devel@edk2.groups.io, mikuback@linux.microsoft.com Cc: Michael D Kinney , Sean Brogan Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=u9fTTafI; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Dec 1, 2023 at 5:07=E2=80=AFPM Michael Kubacki wrote: > > Hi Pedro, > > Visual Studio NOOPT builds result in linker errors. I combined your > patch series with the test instruction change in this PR - > https://github.com/tianocore/edk2/pull/5096. > > You can use a PR to test the VS build. Thanks for the heads up, but I ended up booting Windows to expedite the pro= cess. So, I noticed from the build logs that libcmtd.lib was having issues doing a /WHOLEARCHIVE link (not unheard of, had the same problems with Linux system libraries). Then I noticed in MSDN: "The /WHOLEARCHIVE option forces the linker to include every object file from either a specified static library, or if no library is specified, from all static libraries specified to the LINK command" Note the "from all static libraries specified to the LINK command". So I noticed libcmtd.lib was being specified manually, and I simply deleted /NODEFAULTLIB:libcmt.lib libcmtd.lib >From line 40 of UnitTestFrameworkPkgHost.dsc.inc. So, before I submit a v2 of this, does anyone know why this was added manually? Mike? Note: I tried to add /MTd, but that seems to be a cl.exe option, not link.e= xe --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111985): https://edk2.groups.io/g/devel/message/111985 Mute This Topic: https://groups.io/mt/102904623/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-