From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by mx.groups.io with SMTP id smtpd.web11.2519.1652290930614793213 for ; Wed, 11 May 2022 10:42:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=gSUtM//R; spf=pass (domain: gmail.com, ip: 209.85.217.43, mailfrom: pedro.falcato@gmail.com) Received: by mail-vs1-f43.google.com with SMTP id v139so2800021vsv.0 for ; Wed, 11 May 2022 10:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CRVoZfbnRZMnH3TO2ZiNf0QUF7PgBbLukKE4bR/8+dY=; b=gSUtM//RPgPJIYIZrqRMp+qCeSSFP5NQXHlBbw+q/abDqfetUDRnVS/YF8daVWstdW v6hWe3ArvPcMOS44QMb8vPMwu8iGh93moyVtJk1ARWyLHR8gyKNOpHUjQEbb3x5t8HWa 1Eoq+W7eKW1biCKZV7GunWQUcamNQ24WSgYMe9U1c9K3Z41Fck/37X0yNWsW7kPC/zs8 qdTIPD57IvIbwJ0sFzyn30vIi06tT5cYvtiZ6WSh4+vKvXRTqqt+kp8qJYFkuEwzNJ73 Uo7Pf2gcaQH6DAk1kN9QHcCQNkiIRALTQyFdyBATXHeUubinyJ3rJVk6hnzroIuAatv+ x+gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CRVoZfbnRZMnH3TO2ZiNf0QUF7PgBbLukKE4bR/8+dY=; b=mXNDKErhyC6ZZ0GNI0WV1iaqXaS8RWspFBHI2wn2sjzEeYWmzUYSlVzqUtR1QHjC1k +bcv0Hnjxbg3jNWvJb13+5GsRWtUXrhi52jl9mV/Znm1FFRKxOVyyOXDJGT6Y6+Oziqt 8CmUaIZkwPnv4HsRm6XjPU7G6FQjioinG5qrhGaIpNsdLOu+Ovzs5zq6axb0tJKSzqwi 8u9uji2TKzTd5KsaKzdvm/bWatL+K+nJi50CtAtHJcjX+HsyyhbpJNinur50gx8UmyLW IDkeDw8MIIybkYlLBPmyMvliKYeMitKZtWvB1AYiTNEyN6TPGZC+yn+TFlDudwRp2qtt vY5g== X-Gm-Message-State: AOAM533Xpan/cXfSIVaYEPkvjMYGCXJ0quPzKJxnZ64hS/OPH8nMzhkp +wzptGIQ6ssNR44xbPr+8ycpGKym4ErWWripYvqsXy37 X-Google-Smtp-Source: ABdhPJyfShdcaOHbWnLJUwouWU4V4WGXxoNAOJ9Q+EUTnvCvizpvAJdLthLTPVLXowRbJOdaDOgqZ4ytozIGhKlrKqk= X-Received: by 2002:a67:e9c5:0:b0:32d:76fc:ec79 with SMTP id q5-20020a67e9c5000000b0032d76fcec79mr14116673vso.7.1652290929544; Wed, 11 May 2022 10:42:09 -0700 (PDT) MIME-Version: 1.0 References: <20220407220146.149580-1-pedro.falcato@gmail.com> <16E9330A7A87074F.18109@groups.io> In-Reply-To: <16E9330A7A87074F.18109@groups.io> From: "Pedro Falcato" Date: Wed, 11 May 2022 18:41:58 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib To: edk2-devel-groups-io , Pedro Falcato Cc: Leif Lindholm , Michael D Kinney , Liming Gao , Zhiguang Liu Content-Type: multipart/alternative; boundary="000000000000ebd3d005debff50a" --000000000000ebd3d005debff50a Content-Type: text/plain; charset="UTF-8" Ping. Could someone review these patches? On Mon, Apr 25, 2022 at 6:14 PM Pedro Falcato via groups.io wrote: > Ping. If someone could take a look, it would be much appreciated. > > On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato > wrote: > >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3745 >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3871 >> >> Hi all, >> >> This patch-set attempts to address two open feature requests for Ext4Pkg >> by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to >> BaseLib (id 3871). >> >> The previous patch-set regarding 3871 attempted to merge the different >> crc16 implementations >> but failed because, contrary to what I thought, there are many, many >> different CRC16s which >> are all slightly different. This one (plus the separate edk2 patch) >> attempts to just merge >> CRC16-ANSI (confusingly, also known as CRC16) into BaseLib. >> >> Since this patch set grew to be considerably different from the original, >> I didn't mark it >> as v2 but rather a separate, new patch-set. >> >> CC'ing the edk2-platforms stewards (as I cannot review my own code) and >> the CC's of the MdePkg >> patch. >> >> Cc: Leif Lindholm >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Zhiguang Liu >> >> Pedro Falcato (3): >> Ext4Pkg: Replace the CRC implementations with BaseLib >> Ext4Pkg: Format using uncrustify >> Ext4Pkg: Add ext2/3 support >> >> Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 10 +- >> Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 279 +++++++++++++++++ >> Features/Ext4Pkg/Ext4Dxe/Collation.c | 4 +- >> Features/Ext4Pkg/Ext4Dxe/Crc16.c | 75 ----- >> Features/Ext4Pkg/Ext4Dxe/Crc32c.c | 84 ------ >> Features/Ext4Pkg/Ext4Dxe/Directory.c | 13 +- >> Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 6 +- >> Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 30 +- >> Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 95 +++--- >> Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 417 ++++++++++++++------------ >> Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 3 +- >> Features/Ext4Pkg/Ext4Dxe/Extents.c | 27 +- >> Features/Ext4Pkg/Ext4Dxe/File.c | 19 +- >> Features/Ext4Pkg/Ext4Dxe/Inode.c | 33 +- >> Features/Ext4Pkg/Ext4Dxe/Partition.c | 12 +- >> Features/Ext4Pkg/Ext4Dxe/Superblock.c | 20 +- >> 16 files changed, 640 insertions(+), 487 deletions(-) >> create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c >> delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c >> delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c >> >> -- >> 2.35.1 >> >> > > -- > Pedro Falcato > > > -- Pedro Falcato --000000000000ebd3d005debff50a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ping. Could someone review these patches?

On Mon, Apr 2= 5, 2022 at 6:14 PM Pedro Falcato via groups.io= <pedro.falcato=3Dgmail.com@g= roups.io> wrote:
Ping. If someone could take a look, it would be mu= ch appreciated.

On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato <pedro.falcato@gmail.c= om> wrote:
https://bugzilla.tianocore.org/show_bug.c= gi?id=3D3745
BZ: https://bugzilla.tianocore.org/show_bug.c= gi?id=3D3871

Hi all,

This patch-set attempts to address two open feature requests for Ext4Pkg by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to BaseLib = (id 3871).

The previous patch-set regarding 3871 attempted to merge the different crc1= 6 implementations
but failed because, contrary to what I thought, there are many, many differ= ent CRC16s which
are all slightly different. This one (plus the separate edk2 patch) attempt= s to just merge
CRC16-ANSI (confusingly, also known as CRC16) into BaseLib.

Since this patch set grew to be considerably different from the original, I= didn't mark it
as v2 but rather a separate, new patch-set.

CC'ing the edk2-platforms stewards (as I cannot review my own code) and= the CC's of the MdePkg
patch.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>

Pedro Falcato (3):
=C2=A0 Ext4Pkg: Replace the CRC implementations with BaseLib
=C2=A0 Ext4Pkg: Format using uncrustify
=C2=A0 Ext4Pkg: Add ext2/3 support

=C2=A0Features/Ext4Pkg/Ext4Dxe/BlockGroup.c |=C2=A0 10 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/BlockMap.c=C2=A0 =C2=A0| 279 +++++++++++++++= ++
=C2=A0Features/Ext4Pkg/Ext4Dxe/Collation.c=C2=A0 |=C2=A0 =C2=A04 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Crc16.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 75 -----=
=C2=A0Features/Ext4Pkg/Ext4Dxe/Crc32c.c=C2=A0 =C2=A0 =C2=A0|=C2=A0 84 -----= -
=C2=A0Features/Ext4Pkg/Ext4Dxe/Directory.c=C2=A0 |=C2=A0 13 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/DiskUtil.c=C2=A0 =C2=A0|=C2=A0 =C2=A06 +- =C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h=C2=A0 =C2=A0|=C2=A0 30 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c=C2=A0 =C2=A0 |=C2=A0 95 +++---
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h=C2=A0 =C2=A0 | 417 ++++++++++++++-= -----------
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf=C2=A0 |=C2=A0 =C2=A03 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Extents.c=C2=A0 =C2=A0 |=C2=A0 27 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/File.c=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 19 = +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Inode.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 33 +- =C2=A0Features/Ext4Pkg/Ext4Dxe/Partition.c=C2=A0 |=C2=A0 12 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Superblock.c |=C2=A0 20 +-
=C2=A016 files changed, 640 insertions(+), 487 deletions(-)
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c
=C2=A0delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c
=C2=A0delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c

--
2.35.1



--
Pedro Falcato
=20



--
Pedro Falcato
--000000000000ebd3d005debff50a--