From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 905159419F0 for ; Tue, 6 Feb 2024 16:44:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZSGQ8B6or9JjxmGXNUynLPW5AqgriTTR3i8D9Zl+YTs=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707237842; v=1; b=BIQ0fpBoezC3YuBHs6W5hO12lFnq8Djss1EO3JMuiZkLj6aF15ppoRbzieksS8VJ+yWQutOZ fTH8+onBQ7nsONLqIxmTJmoNwV4t7eWWaHtr+NeZa8bka0/s7srYfEyCf/q/QdZ3xrlkT62ohLY 8b1n5cwbsf6dbgKtAn6HUk3M= X-Received: by 127.0.0.2 with SMTP id dvXzYY7687511x8lt3WmhblC; Tue, 06 Feb 2024 08:44:02 -0800 X-Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by mx.groups.io with SMTP id smtpd.web10.26470.1707237841579622673 for ; Tue, 06 Feb 2024 08:44:01 -0800 X-Received: by mail-vs1-f42.google.com with SMTP id ada2fe7eead31-46d3b3e0671so472389137.1 for ; Tue, 06 Feb 2024 08:44:01 -0800 (PST) X-Gm-Message-State: H52yyW0uJgSZjWJ7MCLTlKGTx7686176AA= X-Google-Smtp-Source: AGHT+IGc5uTPa0hrauqQOFQ9YpdsFZoNgK4ShFFzio4W1iNmNet7isguU3FsrvqwrfyWtLLhJAT/5iZdVyL2MfiI88Y= X-Received: by 2002:a05:6102:3a11:b0:46c:ae93:9c7 with SMTP id b17-20020a0561023a1100b0046cae9309c7mr87882vsu.18.1707237840401; Tue, 06 Feb 2024 08:44:00 -0800 (PST) MIME-Version: 1.0 References: <20240206070234.31-1-n.jayaprakash@intel.com> <20240206070234.31-2-n.jayaprakash@intel.com> In-Reply-To: <20240206070234.31-2-n.jayaprakash@intel.com> From: "Pedro Falcato" Date: Tue, 6 Feb 2024 16:43:49 +0000 Message-ID: Subject: Re: [edk2-devel] [edk2 Patch 1/1] BaseTools: Syntax warning invalid escape sequence \C To: devel@edk2.groups.io, n.jayaprakash@intel.com Cc: Rebecca Cran , Michael D Kinney , Laszlo Ersek , Liming Gao , Bob Feng , Yuwei Chen Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=BIQ0fpBo; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Feb 6, 2024 at 7:02=E2=80=AFAM Jayaprakash, N wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4666 > > This commit fixes the issue reported through BZ4666. > The Syntax warning related to invalid escape sequence > for \C is seen on Windows OS based builds of edk2 sources. > On Windows the path seperator needs to prefixed with \ > so essentially we need to use \\ as path seperator. > > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Laszlo Ersek > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Jayaprakash N > Signed-off-by: Jayaprakash N > --- > BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTool= s/Source/Python/Workspace/DscBuildData.py > index 4768099343..b69d406249 100644 > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > @@ -2949,7 +2949,7 @@ class DscBuildData(PlatformBuildClassObject): > for include_file in IncFileList: > MakeApp +=3D "$(OBJECTS) : %s\n" % include_file > if sys.platform =3D=3D "win32": > - PcdValueCommonPath =3D os.path.normpath(mws.join(GlobalData.= gGlobalDefines["EDK_TOOLS_PATH"], "Source\C\Common\PcdValueCommon.c")) > + PcdValueCommonPath =3D os.path.normpath(mws.join(GlobalData.= gGlobalDefines["EDK_TOOLS_PATH"], "Source\\C\\Common\\PcdValueCommon.c")) AIUI, changing the \ to / would also work (and it would be prettier/more readable), since we're calling normpath right after. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115182): https://edk2.groups.io/g/devel/message/115182 Mute This Topic: https://groups.io/mt/104193926/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-