From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D8520AC0FFB for ; Wed, 18 Oct 2023 11:38:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NE1K5IF8yZ6RlOEAhEqz9v6O+XNykudaDvIsispjF6w=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697629105; v=1; b=OWEMAv1+SAqDRj7q+B02O/vVoBOb4xAqyB6ZVhv+2WJL96KfPurQvZgfD2zrWVFanedhsHBO WsNd4651A6UgBLbEXotXQAXsk7br2qXOJoYECRWrlf8GFoY/fR9pgmLF7ggFAid2su/YMJI3c7d qEuFiKKrqzz80AptLMdRao1o= X-Received: by 127.0.0.2 with SMTP id SnnwYY7687511xf0DXWJuZSO; Wed, 18 Oct 2023 04:38:25 -0700 X-Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by mx.groups.io with SMTP id smtpd.web10.279555.1697629104798712979 for ; Wed, 18 Oct 2023 04:38:24 -0700 X-Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-7b6043d0b82so2593744241.1 for ; Wed, 18 Oct 2023 04:38:24 -0700 (PDT) X-Gm-Message-State: P4nDFYObF3f0Jqp9Wc7yH5Fwx7686176AA= X-Google-Smtp-Source: AGHT+IEWbijTzBB/RXUwc7AUbrr0MmX1V6Gz0AwKCUmwLP3qh6c6KB70GzK9w9P5sUY0d7mIAmbfZgtijxNkmIuNHiI= X-Received: by 2002:a67:cb8b:0:b0:457:6999:968a with SMTP id h11-20020a67cb8b000000b004576999968amr4668050vsl.7.1697629103827; Wed, 18 Oct 2023 04:38:23 -0700 (PDT) MIME-Version: 1.0 References: <20231018-ehci-xhci-fix-v4-0-aa53138997a5@linaro.org> <20231018-ehci-xhci-fix-v4-4-aa53138997a5@linaro.org> <75b23ede-8f50-4d44-a786-fb04cd4abd00@os.amperecomputing.com> <2d881cf4-d12b-4ddb-8a5c-deb5f070c1cc@linaro.org> In-Reply-To: From: "Pedro Falcato" Date: Wed, 18 Oct 2023 12:38:12 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present To: Marcin Juszkiewicz Cc: devel@edk2.groups.io, Nhi Pham , Leif Lindholm , Ard Biesheuvel , Jeremy Linton , Chuong Tran , Rebecca Cran Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=OWEMAv1+; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Oct 18, 2023 at 12:28=E2=80=AFPM Marcin Juszkiewicz wrote: > > W dniu 18.10.2023 o 13:23, Pedro Falcato pisze: > > On Wed, Oct 18, 2023 at 12:16=E2=80=AFPM Marcin Juszkiewicz > > wrote: > >> > >> W dniu 18.10.2023 o 12:32, Nhi Pham pisze: > >>> Acked-by: Nhi Pham > >>> > >>> Nit: I think you want to run uncrustify for Patch 3 as well :) > >> > >> Done, will check other changes too. > >> > >> I have a strong feeling that Qemu part of EDK2 needs a bit > >> bigger patch when it comes to formatting: > >> > >> Platform/Qemu/QemuOpenBoardPkg/Include/Library/QemuOpenFwCfgLib.h = | 7 +- > >> Platform/Qemu/QemuOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLi= b.c | 33 +- > >> Platform/Qemu/QemuOpenBoardPkg/Library/PlatformSecLib/Ia32/SecEntry= .nasm | 99 ++- > >> Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Memory.c = | 108 +-- > >> Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pcie.c = | 30 +- > >> Platform/Qemu/QemuOpenBoardPkg/README.md = | 43 +- > > > > Something must be wrong with your config because QemuOpenBoardPkg is > > and was, AFAIK, all formatted using uncrustify. And if I run it > > locally, it seems to agree with me. > > EDK2 expects some random version of uncrustify. > > It is not part of BaseTools so I use upstream version. And it looks like > they format in different way using the same config file. Right. But we used the correct uncrustify version, so things are well formatted. I don't see the point in formatting with upstream uncrustify, you're just going to end up misformatting everything. Whether the current sanctioned solution is any sane at all (it is not) is another matter, but I seriously have no stamina to discuss these kinds of changes anymore. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109733): https://edk2.groups.io/g/devel/message/109733 Mute This Topic: https://groups.io/mt/102035954/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-