* [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds
@ 2022-09-15 23:06 Pedro Falcato
2022-09-15 23:10 ` Rebecca Cran
2022-09-16 6:51 ` Marvin Häuser
0 siblings, 2 replies; 4+ messages in thread
From: Pedro Falcato @ 2022-09-15 23:06 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran, Marvin Häuser
As reported by Rebecca Cran, there was some build breakage when
compiling with stack-protector-on-by-default toolchains. Adding the
proper library to the DSC should fix it.
Cc: Rebecca Cran <rebecca@quicinc.com>
Cc: Marvin Häuser <mhaeuser@posteo.de>
Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
Features/Ext4Pkg/Ext4Pkg.dsc | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Features/Ext4Pkg/Ext4Pkg.dsc b/Features/Ext4Pkg/Ext4Pkg.dsc
index 57f279a4d918..59bc327ebf6e 100644
--- a/Features/Ext4Pkg/Ext4Pkg.dsc
+++ b/Features/Ext4Pkg/Ext4Pkg.dsc
@@ -46,6 +46,11 @@
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
+
+ #
+ # Required for stack protector support
+ #
+ NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
###################################################################################################
#
--
2.37.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds
2022-09-15 23:06 [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds Pedro Falcato
@ 2022-09-15 23:10 ` Rebecca Cran
2022-09-16 6:51 ` Marvin Häuser
1 sibling, 0 replies; 4+ messages in thread
From: Rebecca Cran @ 2022-09-15 23:10 UTC (permalink / raw)
To: Pedro Falcato, devel; +Cc: Marvin Häuser
Reviewed-by: Rebecca Cran <rebecca@quicinc.com>
On 9/15/22 17:06, Pedro Falcato wrote:
> As reported by Rebecca Cran, there was some build breakage when
> compiling with stack-protector-on-by-default toolchains. Adding the
> proper library to the DSC should fix it.
>
> Cc: Rebecca Cran <rebecca@quicinc.com>
> Cc: Marvin Häuser <mhaeuser@posteo.de>
> Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
> Features/Ext4Pkg/Ext4Pkg.dsc | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Features/Ext4Pkg/Ext4Pkg.dsc b/Features/Ext4Pkg/Ext4Pkg.dsc
> index 57f279a4d918..59bc327ebf6e 100644
> --- a/Features/Ext4Pkg/Ext4Pkg.dsc
> +++ b/Features/Ext4Pkg/Ext4Pkg.dsc
> @@ -46,6 +46,11 @@
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> +
> + #
> + # Required for stack protector support
> + #
> + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>
> ###################################################################################################
> #
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds
2022-09-15 23:06 [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds Pedro Falcato
2022-09-15 23:10 ` Rebecca Cran
@ 2022-09-16 6:51 ` Marvin Häuser
2022-09-16 10:00 ` Pedro Falcato
1 sibling, 1 reply; 4+ messages in thread
From: Marvin Häuser @ 2022-09-16 6:51 UTC (permalink / raw)
To: Pedro Falcato; +Cc: devel, Rebecca Cran
Reviewed-by: Marvin Häuser <mhaeuser@posteo.de>
> On 16. Sep 2022, at 01:06, Pedro Falcato <pedro.falcato@gmail.com> wrote:
>
> As reported by Rebecca Cran, there was some build breakage when
> compiling with stack-protector-on-by-default toolchains. Adding the
> proper library to the DSC should fix it.
>
> Cc: Rebecca Cran <rebecca@quicinc.com>
> Cc: Marvin Häuser <mhaeuser@posteo.de>
> Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
> Features/Ext4Pkg/Ext4Pkg.dsc | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Features/Ext4Pkg/Ext4Pkg.dsc b/Features/Ext4Pkg/Ext4Pkg.dsc
> index 57f279a4d918..59bc327ebf6e 100644
> --- a/Features/Ext4Pkg/Ext4Pkg.dsc
> +++ b/Features/Ext4Pkg/Ext4Pkg.dsc
> @@ -46,6 +46,11 @@
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> +
> + #
> + # Required for stack protector support
> + #
> + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>
> ###################################################################################################
> #
> --
> 2.37.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds
2022-09-16 6:51 ` Marvin Häuser
@ 2022-09-16 10:00 ` Pedro Falcato
0 siblings, 0 replies; 4+ messages in thread
From: Pedro Falcato @ 2022-09-16 10:00 UTC (permalink / raw)
To: Marvin Häuser; +Cc: edk2-devel-groups-io, Rebecca Cran
[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]
Pushed as e55f0527dde48a5f139c1b8f35acc4e6b59dd794.
On Fri, Sep 16, 2022 at 7:51 AM Marvin Häuser <mhaeuser@posteo.de> wrote:
> Reviewed-by: Marvin Häuser <mhaeuser@posteo.de>
>
> > On 16. Sep 2022, at 01:06, Pedro Falcato <pedro.falcato@gmail.com>
> wrote:
> >
> > As reported by Rebecca Cran, there was some build breakage when
> > compiling with stack-protector-on-by-default toolchains. Adding the
> > proper library to the DSC should fix it.
> >
> > Cc: Rebecca Cran <rebecca@quicinc.com>
> > Cc: Marvin Häuser <mhaeuser@posteo.de>
> > Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
> > ---
> > Features/Ext4Pkg/Ext4Pkg.dsc | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Features/Ext4Pkg/Ext4Pkg.dsc b/Features/Ext4Pkg/Ext4Pkg.dsc
> > index 57f279a4d918..59bc327ebf6e 100644
> > --- a/Features/Ext4Pkg/Ext4Pkg.dsc
> > +++ b/Features/Ext4Pkg/Ext4Pkg.dsc
> > @@ -46,6 +46,11 @@
> > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> >
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> > BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> > +
> > + #
> > + # Required for stack protector support
> > + #
> > + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> >
> >
> ###################################################################################################
> > #
> > --
> > 2.37.3
> >
>
>
--
Pedro Falcato
[-- Attachment #2: Type: text/html, Size: 2389 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-16 10:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-15 23:06 [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds Pedro Falcato
2022-09-15 23:10 ` Rebecca Cran
2022-09-16 6:51 ` Marvin Häuser
2022-09-16 10:00 ` Pedro Falcato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox