From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mx.groups.io with SMTP id smtpd.web09.4269.1663322444805438514 for ; Fri, 16 Sep 2022 03:00:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=M1c8iFRw; spf=pass (domain: gmail.com, ip: 209.85.216.43, mailfrom: pedro.falcato@gmail.com) Received: by mail-pj1-f43.google.com with SMTP id p1-20020a17090a2d8100b0020040a3f75eso19863681pjd.4 for ; Fri, 16 Sep 2022 03:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=+A7l5sdQhhkNnk+VIDG+Z5fHLLHgBuOl+3xHqaY5+bQ=; b=M1c8iFRwHi9M8JHtCXiJRmkh3bWRgAGsqAOv1NYgU6XE89VWQOS+A0+EMBaozRexzj 4t+B1BXGqotOk3Rvq95STNy+mBfj8oFMnitrGEFrWA02SJrANK5mKOzuXVoy8+6ughsl h/hgehsDv2NdIU/s28uh5OGsvrRMJxm8em0q+zHN2tdlYV34FvL2OElVyUJ1MCVdwZef 1Fmz/b4nswUobsIhQTdLKcWA2iPzpgj8+o7xonHmJUJF5s7M8aTzTD9XViwxRbI0t9aZ qKJ8VZLwql/9pbnxLdJZ3t82aFJYTU6daJ7ImUDppvwwoHCq3p9GS5RHXLOC0rrDxlyf Wp8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=+A7l5sdQhhkNnk+VIDG+Z5fHLLHgBuOl+3xHqaY5+bQ=; b=WO4ELNCKP3o6cEzEAAyTW3udBZYWwy9K2+ESPouTUNRSqXsZrKHS+PvWB2o09m2NtM dU3C1WmT5Dr3YcPiFUhdFihmyIc9Y46OGXniDwrFFYVkEdkbiuSJu3miA9ZtGLprDQYn vxmXkOTwv1EFvw4WOPjzRlgu0R5S+RaUSZ3G+80+uO7XvzttpkC7VucbtSpu8bK4iYlJ M9St1J+NHdYUWtN61oxIlJhFhTF+HyrW8ms30juRPZa0zyDAzCg36uddGtfh/erT25e1 qMpfAfDpvn4VLkKsDsO63Hk79CT4mhrp1mQTQwlgZFE6+PZhFR79DDFxkwYMcxZ5s49m LvGg== X-Gm-Message-State: ACrzQf3zC59hyh3MZTlBzF5wUpyiVGz+D4px48+nj9hDxKTtRw+e2V8p lVYGBYB7Ho1PeaFuQ5fN8q43a7CpHE43p5HNwCE= X-Google-Smtp-Source: AMsMyM5mOz33oQTlLfXwoMOcJVAp8cs647q31AFPfUiXZzKi3A1+tiOmkBgbDiuCnE6kSDtavr6jEajRmT9ndYzWxvA= X-Received: by 2002:a17:902:f68d:b0:178:41dd:12ad with SMTP id l13-20020a170902f68d00b0017841dd12admr4034010plg.25.1663322444176; Fri, 16 Sep 2022 03:00:44 -0700 (PDT) MIME-Version: 1.0 References: <20220915230609.228037-1-pedro.falcato@gmail.com> <51187D88-0566-4E97-892D-FB705D6A24BA@posteo.de> In-Reply-To: <51187D88-0566-4E97-892D-FB705D6A24BA@posteo.de> From: "Pedro Falcato" Date: Fri, 16 Sep 2022 11:00:32 +0100 Message-ID: Subject: Re: [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds To: =?UTF-8?Q?Marvin_H=C3=A4user?= Cc: edk2-devel-groups-io , Rebecca Cran Content-Type: multipart/alternative; boundary="0000000000006ea66605e8c86f8d" --0000000000006ea66605e8c86f8d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Pushed as e55f0527dde48a5f139c1b8f35acc4e6b59dd794. On Fri, Sep 16, 2022 at 7:51 AM Marvin H=C3=A4user wro= te: > Reviewed-by: Marvin H=C3=A4user > > > On 16. Sep 2022, at 01:06, Pedro Falcato > wrote: > > > > =EF=BB=BFAs reported by Rebecca Cran, there was some build breakage whe= n > > compiling with stack-protector-on-by-default toolchains. Adding the > > proper library to the DSC should fix it. > > > > Cc: Rebecca Cran > > Cc: Marvin H=C3=A4user > > Signed-off-by: Pedro Falcato > > --- > > Features/Ext4Pkg/Ext4Pkg.dsc | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Features/Ext4Pkg/Ext4Pkg.dsc b/Features/Ext4Pkg/Ext4Pkg.ds= c > > index 57f279a4d918..59bc327ebf6e 100644 > > --- a/Features/Ext4Pkg/Ext4Pkg.dsc > > +++ b/Features/Ext4Pkg/Ext4Pkg.dsc > > @@ -46,6 +46,11 @@ > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > > > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib= /BaseOrderedCollectionRedBlackTreeLib.inf > > BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.in= f > > + > > + # > > + # Required for stack protector support > > + # > > + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > > > > > #########################################################################= ########################## > > # > > -- > > 2.37.3 > > > > --=20 Pedro Falcato --0000000000006ea66605e8c86f8d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Pushed as e55f0527dde48a5f139c1b8f35acc4e6b59dd794.
<= br>
On Fri,= Sep 16, 2022 at 7:51 AM Marvin H=C3=A4user <mhaeuser@posteo.de> wrote:
Reviewed-by: Marvin H=C3=A4user <mhaeuser@posteo.de>
> On 16. Sep 2022, at 01:06, Pedro Falcato <pedro.falcato@gmail.com> wrote:<= br> >
> =EF=BB=BFAs reported by Rebecca Cran, there was some build breakage wh= en
> compiling with stack-protector-on-by-default toolchains. Adding the > proper library to the DSC should fix it.
>
> Cc: Rebecca Cran <rebecca@quicinc.com>
> Cc: Marvin H=C3=A4user <mhaeuser@posteo.de>
> Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
> Features/Ext4Pkg/Ext4Pkg.dsc | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Features/Ext4Pkg/Ext4Pkg.dsc b/Features/Ext4Pkg/Ext4Pkg.d= sc
> index 57f279a4d918..59bc327ebf6e 100644
> --- a/Features/Ext4Pkg/Ext4Pkg.dsc
> +++ b/Features/Ext4Pkg/Ext4Pkg.dsc
> @@ -46,6 +46,11 @@
>=C2=A0 =C2=A0DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDeviceP= athLib.inf
>=C2=A0 =C2=A0OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionR= edBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
>=C2=A0 =C2=A0BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs= 2Utf8Lib.inf
> +=C2=A0
> +=C2=A0 #
> +=C2=A0 # Required for stack protector support
> +=C2=A0 #
> +=C2=A0 NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf >
> ######################################################################= #############################
> #
> --
> 2.37.3
>



--
Pedro Falcato
--0000000000006ea66605e8c86f8d--