From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by mx.groups.io with SMTP id smtpd.web11.823.1657146444646607764 for ; Wed, 06 Jul 2022 15:27:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ORzwdMbf; spf=pass (domain: gmail.com, ip: 209.85.217.47, mailfrom: pedro.falcato@gmail.com) Received: by mail-vs1-f47.google.com with SMTP id k2so6906512vsc.5 for ; Wed, 06 Jul 2022 15:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d0mC5xDu3TwqN3QiGqNV3NgjXxPDtpU9gSWIUdvdWSg=; b=ORzwdMbfXS1Au4ri0q+g3d2Z70ka6xBqRDVShUtGxN9zgtXGX3Tk1xughqwYElqoq7 k+S1JD2m/0ykeRnYL4um2PW+9KsXsH+u4Zo5K3OmITFzo6h51dDBl9sCpqQZIQPQmw5K Ob7gymvOZgu4L5x9zxGlxG1vNFiswgP5sFuUzK5mTs2jRVHEGsrflVyqW5Va4Db6Pp9t jBh1EeXK/SjEnFOALkxe7OaPogS5qF0JVig3buLTHj2+RvyF2ADDdLWQBY9i4+m0UgWL ohKPh8l7SIHP+xAjqm2oDWntF3pD6NFt3EaeQNf/58n5u35AjBdOeKaYY9BCECz140P1 tTMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d0mC5xDu3TwqN3QiGqNV3NgjXxPDtpU9gSWIUdvdWSg=; b=tMONq0CjubM1MfjFlVd+yvp8+jICovgj9EpKiYXiOvnI6xY5EyU9opOUeDeZEzVG1w KQZcP0PzG9e0ItOaUKJjmSil5EYEjMbyDDGF0dCQXdl64UALa1Ax8j1RIDcMZJ/j8Ds5 jYdGc62bTW3pOVJ0n3E+942TnSFbhf9Mg1vX7YLTtqL6OPEVC6MUmW3w63iXpyEZNh6h XotVR1DoGx/bZU0+itHrLXWdlaRS7B9/VHzJjThw1G7sXHwY+syq9wlbvlKcYR6GQAwV woYKxOAr+DUisglbbspGxcPSRYUywaRRw4JOB9R/zA2DeE1h+sz2ezkbQoxkU6wcarcM 3SWA== X-Gm-Message-State: AJIora/1Eo72/8z59JZg8hh4reCkTEDjiE9bSllj1C5G7BObwBaRUY9o M9FJF9J25WUNbDxPq8J8vGzt7viPbZaxp6pjuBg= X-Google-Smtp-Source: AGRyM1tzWW8oeJ9jsrOhJ7NV/xkB2cjFaCT49i96HlJCiDVTAoeKUlV8RugedGbWMTEBQVTfQHu135Zzg0wol+Jt6Ck= X-Received: by 2002:a67:c287:0:b0:356:f0ef:b969 with SMTP id k7-20020a67c287000000b00356f0efb969mr8043528vsj.62.1657146443549; Wed, 06 Jul 2022 15:27:23 -0700 (PDT) MIME-Version: 1.0 References: <20220705011622.351454-1-pedro.falcato@gmail.com> In-Reply-To: From: "Pedro Falcato" Date: Wed, 6 Jul 2022 23:27:12 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH v2] MdePkg/BasePrintLib: Add %z specifier To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , "Andrew Fish (afish@apple.com)" , "Gao, Liming" , "Liu, Zhiguang" Content-Type: multipart/alternative; boundary="0000000000001bd08b05e32a7969" --0000000000001bd08b05e32a7969 Content-Type: text/plain; charset="UTF-8" On Wed, Jul 6, 2022 at 7:22 PM Kinney, Michael D wrote: > Hi Pedro, > > This is an interesting feature. > > It is backwards compatible since you are adding a format specifier to the > PrintLib class. > > There is a 2nd lib instance that needs to be updated, and that is > DxePrintLibPrint2Protocol in MdeModulePkg. > > I think using ANSI C %z specifier syntax assumes that sizeof(size_t) == > sizeof(UINTN) for all supported compilers/CPU archs. > The ANSI C 99 specification does not state that this is always true. If > may be true in practice for the compiler/CPU archs > currently supported by Tianocore. > > It would be good to add a STATIC_ASSERT() to check that this is true and > break the build if a compiler+CPU combination > is used where that assumption is false. Not sure if this should go in > Base.h with other STATIC_ASSERT()s for > types. Or if it should go in PrintLib.h where this assumption is being > made. > Hi Mike, How can sizeof(size_t) != sizeof(UINTN)? It seems to be quite a stretch to interpret the standard in a way that the native word size will not be able to store "the maximum size of a theoretically possible object of any type". In any case, getting the size_t type is non-trivial and as far as I can tell would either depend on a C library or C extension trickery to try to get the type of sizeof(Type). > I would like to see some more background on the motivation for adding this > feature. > I think the current workaround would be to typecast and integer of type > size_t to UINT64 and use %Ld or > typecase to UINT32 and use %d. > Ok, some background: I essentially starting looking at DebugLib and PrintLib and I found myself very surprised by a good chunk of decisions. The API is very similar to standard printf() but it lacks support for a good portion of specifiers; some specifiers it implements don't have the C99 standard meaning, like the ones it implements for integers (%x and %lx for hex, for instance) which were non-obviously overridden to mean print UINT32 and print UINT64. Because of that, I feel that maybe reworking this library (creating PrintLib2 or something, since we can't break the existing uses) would be a good idea to have a "principle of least surprise" compliant API and would help smoothen the confusion curve between userspace code and EDK2 firmware. Since reworking the whole of PrintLib is a non-trivial amount of work, I settled for this very tiny feature that doesn't break anyone's code and is very handy to avoid odd workarounds like casting everything to a UINT64 so you can print it with %lx. Obviously, if there's interest in getting a more standard environment[1] in EDK2 (and I personally, although possibly naiively, don't see the downside), going down a PrintLib2 in the long haul is a good idea. But this patch took me around 10 minutes to write up and is probably useful in its current form. Thanks, Pedro [1] Why do I want to get a more standardized environment? Well, I simply believe it smoothens the learning curve between userspace -> kernel -> bootloader -> firmware. A good chunk of kernels and bootloaders already have relatively standard C APIs, but firmware, at least in our case, is still lacking. Also, makes you less prone to mistakes. > > Thanks, > > Mike > > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Pedro > Falcato > > Sent: Monday, July 4, 2022 6:16 PM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Gao, Liming < > gaoliming@byosoft.com.cn>; Liu, Zhiguang > > > > Subject: [edk2-devel] [PATCH v2] MdePkg/BasePrintLib: Add %z specifier > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3977 > > > > %z is used in standard C99 as the printf specifier for size_t types. > > Add support for it so we can portably print UINTN. > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Signed-off-by: Pedro Falcato > > --- > > MdePkg/Include/Library/PrintLib.h | 13 ++++++++----- > > MdePkg/Library/BasePrintLib/PrintLibInternal.c | 9 +++++++++ > > MdePkg/Library/BasePrintLib/PrintLibInternal.h | 1 + > > 3 files changed, 18 insertions(+), 5 deletions(-) > > > > diff --git a/MdePkg/Include/Library/PrintLib.h > b/MdePkg/Include/Library/PrintLib.h > > index 8d523cac52..0d67f62d3f 100644 > > --- a/MdePkg/Include/Library/PrintLib.h > > +++ b/MdePkg/Include/Library/PrintLib.h > > @@ -42,6 +42,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > - L, l > > - The number being printed is size UINT64. Only valid for types > X, x, and d. > > If this flag is not specified, then the number being printed is > size int. > > + - z > > + - The number being printed is of size UINTN. Only valid for types > X, x and d. > > + If this flag is not specified, then the number being printed is > size int. > > - NOTE: All invalid flags are ignored. > > > > [width]: > > @@ -73,18 +76,18 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > using this type too by making sure bits 8..15 of the argument > are set to 0. > > - x > > - The argument is an unsigned hexadecimal number. The characters > used are 0..9 and > > - A..F. If the flag 'L' is not specified, then the argument is > assumed > > + A..F. If the flags 'L', 'z' are not specified, then the > argument is assumed > > to be size int. This does not follow ANSI C. > > - X > > - The argument is an unsigned hexadecimal number and the number > is padded with > > - zeros. This is equivalent to a format string of "0x". If the > flag > > - 'L' is not specified, then the argument is assumed to be size > int. > > + zeros. This is equivalent to a format string of "0x". If the > flags > > + 'L', 'z' are not specified, then the argument is assumed to be > size int. > > This does not follow ANSI C. > > - d > > - - The argument is a signed decimal number. If the flag 'L' is > not specified, > > + - The argument is a signed decimal number. If the flags 'L', 'z' > are not specified, > > then the argument is assumed to be size int. > > - u > > - - The argument is a unsigned decimal number. If the flag 'L' is > not specified, > > + - The argument is a unsigned decimal number. If the flags 'L'. > 'z' are not specified, > > then the argument is assumed to be size int. > > - p > > - The argument is a pointer that is a (VOID *), and it is printed > as an > > diff --git a/MdePkg/Library/BasePrintLib/PrintLibInternal.c > b/MdePkg/Library/BasePrintLib/PrintLibInternal.c > > index 42b598a432..1cd99b2213 100644 > > --- a/MdePkg/Library/BasePrintLib/PrintLibInternal.c > > +++ b/MdePkg/Library/BasePrintLib/PrintLibInternal.c > > @@ -720,6 +720,9 @@ BasePrintLibSPrintMarker ( > > case 'l': > > Flags |= LONG_TYPE; > > break; > > + case 'z': > > + Flags |= SIZET_TYPE; > > + break; > > case '*': > > if ((Flags & PRECISION) == 0) { > > Flags |= PAD_TO_WIDTH; > > @@ -833,6 +836,12 @@ BasePrintLibSPrintMarker ( > > } else { > > Value = BASE_ARG (BaseListMarker, int); > > } > > + } else if ((Flags & SIZET_TYPE) != 0) { > > + if (BaseListMarker == NULL) { > > + Value = VA_ARG (VaListMarker, UINTN); > > + } else { > > + Value = BASE_ARG (BaseListMarker, UINTN); > > + } > > } else { > > if (BaseListMarker == NULL) { > > Value = VA_ARG (VaListMarker, INT64); > > diff --git a/MdePkg/Library/BasePrintLib/PrintLibInternal.h > b/MdePkg/Library/BasePrintLib/PrintLibInternal.h > > index 34d591c6fc..9193e6192b 100644 > > --- a/MdePkg/Library/BasePrintLib/PrintLibInternal.h > > +++ b/MdePkg/Library/BasePrintLib/PrintLibInternal.h > > @@ -29,6 +29,7 @@ > > #define ARGUMENT_REVERSED BIT12 > > #define COUNT_ONLY_NO_PRINT BIT13 > > #define UNSIGNED_TYPE BIT14 > > +#define SIZET_TYPE BIT15 > > > > // > > // Record date and time information > > -- > > 2.37.0 > > > > > > > > > > > > -- Pedro Falcato --0000000000001bd08b05e32a7969 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Jul 6, 2022 at 7:22 PM Kinney, Mi= chael D <michael.d.kinney@= intel.com> wrote:
Hi Pedro,

This is an interesting feature.

It is backwards compatible since you are adding a format specifier to the P= rintLib class.

There is a 2nd lib instance that needs to be updated, and that is DxePrintL= ibPrint2Protocol in MdeModulePkg.

I think using ANSI C %z specifier syntax assumes that sizeof(size_t) =3D=3D= sizeof(UINTN) for all supported compilers/CPU archs.
The ANSI C 99 specification does not state that this is always true.=C2=A0 = If may be true in practice for the compiler/CPU archs
currently supported by Tianocore.

It would be good to add a STATIC_ASSERT() to check that this is true and br= eak the build if a compiler+CPU combination
is used where that assumption is false.=C2=A0 Not sure if this should go in= Base.h with other STATIC_ASSERT()s for
types.=C2=A0 Or if it should go in PrintLib.h where this assumption is bein= g made.
=C2=A0

Hi Mike,
How can size= of(size_t) !=3D sizeof(UINTN)? It seems to be quite a stretch to interpret = the standard in a way that the native word size will not be able to store &= quot;the maximum size of a theoretically possible object of any type".= In any case, getting the size_t type is non-trivial and as far as I can te= ll would either depend on a C library or C extension trickery to try to get= the type of sizeof(Type).
=C2=A0
I would like to see some more background on the motivation for adding this = feature.
I think the current workaround would be to typecast and integer of type siz= e_t to UINT64 and use %Ld or
typecase to UINT32 and use %d.
=C2=A0
Ok, so= me background: I essentially starting looking at DebugLib and PrintLib and = I found myself very surprised by a good chunk of decisions. The API is very= similar to standard printf() but it lacks support for a good portion of sp= ecifiers; some specifiers it implements don't have the C99 standard mea= ning, like the ones it implements for integers (%x and %lx for hex, for ins= tance) which were non-obviously overridden to mean print UINT32 and print U= INT64. Because of that, I feel that maybe reworking this library (creating = PrintLib2 or something, since we can't break the existing uses) would b= e a good idea to have a "principle of least surprise" compliant A= PI and would help smoothen the confusion curve between userspace code and E= DK2 firmware.

Since reworking the whole of PrintLi= b is a non-trivial amount of work, I settled for this very tiny feature tha= t doesn't break anyone's code and is very handy to avoid odd workar= ounds like casting everything to a UINT64 so you can print it with %lx. Obv= iously, if there's interest in getting a more standard environment[1] i= n EDK2 (and I personally, although possibly naiively, don't see the dow= nside), going down a PrintLib2 in the long haul is a good idea. But this pa= tch took me around 10 minutes to write up and is probably useful in its cur= rent form.

Thanks,
Pedro
<= br>
[1] Why do I want to get a more standardized environment? Wel= l, I simply believe it smoothens the learning curve between userspace ->= kernel -> bootloader -> firmware. A good chunk of kernels and bootlo= aders already have relatively standard C APIs, but firmware, at least in ou= r case, is still lacking. Also, makes you less prone to mistakes.
=

Thanks,

Mike


> -----Original Message-----
> From: devel@= edk2.groups.io <devel@edk2.groups.io> On Behalf Of Pedro Falcato
> Sent: Monday, July 4, 2022 6:16 PM
> To: devel@ed= k2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosof= t.com.cn>; Liu, Zhiguang
> <zhigua= ng.liu@intel.com>
> Subject: [edk2-devel] [PATCH v2] MdePkg/BasePrintLib: Add %z specifier=
>
> BZ: https://bugzilla.tianocore.org/show_bu= g.cgi?id=3D3977
>
> %z is used in standard C99 as the printf specifier for size_t types. > Add support for it so we can portably print UINTN.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
>=C2=A0 MdePkg/Include/Library/PrintLib.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 | 13 ++++++++-----
>=C2=A0 MdePkg/Library/BasePrintLib/PrintLibInternal.c |=C2=A0 9 +++++++= ++
>=C2=A0 MdePkg/Library/BasePrintLib/PrintLibInternal.h |=C2=A0 1 +
>=C2=A0 3 files changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/MdePkg/Include/Library/PrintLib.h b/MdePkg/Include/Librar= y/PrintLib.h
> index 8d523cac52..0d67f62d3f 100644
> --- a/MdePkg/Include/Library/PrintLib.h
> +++ b/MdePkg/Include/Library/PrintLib.h
> @@ -42,6 +42,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>=C2=A0 =C2=A0 =C2=A0 - L, l
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 - The number being printed is size UINT64.= =C2=A0 Only valid for types X, x, and d.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 If this flag is not specified, then = the number being printed is size int.
> +=C2=A0 =C2=A0 - z
> +=C2=A0 =C2=A0 =C2=A0 - The number being printed is of size UINTN. Onl= y valid for types X, x and d.
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 If this flag is not specified, then the n= umber being printed is size int.
>=C2=A0 =C2=A0 =C2=A0 - NOTE: All invalid flags are ignored.
>
>=C2=A0 =C2=A0 [width]:
> @@ -73,18 +76,18 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 using this type too by making sure b= its 8..15 of the argument are set to 0.
>=C2=A0 =C2=A0 =C2=A0 - x
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 - The argument is an unsigned hexadecimal n= umber.=C2=A0 The characters used are 0..9 and
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 A..F.=C2=A0 If the flag 'L' is no= t specified, then the argument is assumed
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 A..F.=C2=A0 If the flags 'L', = 9;z' are not specified, then the argument is assumed
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 to be size int.=C2=A0 This does not = follow ANSI C.
>=C2=A0 =C2=A0 =C2=A0 - X
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 - The argument is an unsigned hexadecimal n= umber and the number is padded with
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 zeros.=C2=A0 This is equivalent to a form= at string of "0x". If the flag
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 'L' is not specified, then the ar= gument is assumed to be size int.
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 zeros.=C2=A0 This is equivalent to a form= at string of "0x". If the flags
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 'L', 'z' are not specifie= d, then the argument is assumed to be size int.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 This does not follow ANSI C.
>=C2=A0 =C2=A0 =C2=A0 - d
> -=C2=A0 =C2=A0 =C2=A0 - The argument is a signed decimal number.=C2=A0= If the flag 'L' is not specified,
> +=C2=A0 =C2=A0 =C2=A0 - The argument is a signed decimal number.=C2=A0= If the flags 'L', 'z' are not specified,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 then the argument is assumed to be s= ize int.
>=C2=A0 =C2=A0 =C2=A0 - u
> -=C2=A0 =C2=A0 =C2=A0 - The argument is a unsigned decimal number.=C2= =A0 If the flag 'L' is not specified,
> +=C2=A0 =C2=A0 =C2=A0 - The argument is a unsigned decimal number.=C2= =A0 If the flags 'L'. 'z' are not specified,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 then the argument is assumed to be s= ize int.
>=C2=A0 =C2=A0 =C2=A0 - p
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 - The argument is a pointer that is a (VOID= *), and it is printed as an
> diff --git a/MdePkg/Library/BasePrintLib/PrintLibInternal.c b/MdePkg/L= ibrary/BasePrintLib/PrintLibInternal.c
> index 42b598a432..1cd99b2213 100644
> --- a/MdePkg/Library/BasePrintLib/PrintLibInternal.c
> +++ b/MdePkg/Library/BasePrintLib/PrintLibInternal.c
> @@ -720,6 +720,9 @@ BasePrintLibSPrintMarker (
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 case 'l':
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Flags |=3D LONG= _TYPE;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 case 'z':
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Flags |=3D SIZET_TYP= E;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 case '*':
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ((Flags &= ; PRECISION) =3D=3D 0) {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Flags |= =3D PAD_TO_WIDTH;
> @@ -833,6 +836,12 @@ BasePrintLibSPrintMarker (
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Value = =3D BASE_ARG (BaseListMarker, int);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else if ((Flags & SIZ= ET_TYPE) !=3D 0) {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (BaseListMarker = =3D=3D NULL) {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Value =3D VA_= ARG (VaListMarker, UINTN);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Value =3D BAS= E_ARG (BaseListMarker, UINTN);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (BaseListMar= ker =3D=3D NULL) {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Value = =3D VA_ARG (VaListMarker, INT64);
> diff --git a/MdePkg/Library/BasePrintLib/PrintLibInternal.h b/MdePkg/L= ibrary/BasePrintLib/PrintLibInternal.h
> index 34d591c6fc..9193e6192b 100644
> --- a/MdePkg/Library/BasePrintLib/PrintLibInternal.h
> +++ b/MdePkg/Library/BasePrintLib/PrintLibInternal.h
> @@ -29,6 +29,7 @@
>=C2=A0 #define ARGUMENT_REVERSED=C2=A0 =C2=A0 BIT12
>=C2=A0 #define COUNT_ONLY_NO_PRINT=C2=A0 BIT13
>=C2=A0 #define UNSIGNED_TYPE=C2=A0 =C2=A0 =C2=A0 =C2=A0 BIT14
> +#define SIZET_TYPE=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0BIT15
>
>=C2=A0 //
>=C2=A0 // Record date and time information
> --
> 2.37.0
>
>
>
>
>



--
Pedro Falcato
--0000000000001bd08b05e32a7969--