From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 515167803CE for ; Mon, 11 Dec 2023 15:41:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7p+cy+Km3dsKqpHphQQPnNikFos8Ra4cxaZK7iPBhbg=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702309277; v=1; b=Ia3BX0cGaaDNwdWq95gLu7hhNZ4elL4OiCXMWYqwgaZ6gD9mLqvYLzfK0K24c0KxBGVS0RyL h4sPS6ZolmA3tS60hMAMp0BMvLaKGeEzCIeBY6MiJd/qV/CBE9i3oP3+1kXAe4TsRcPkS4Xxuf9 AmWm2BFfPShUNyhXd3mjJJWA= X-Received: by 127.0.0.2 with SMTP id BDS8YY7687511xyJC87vqAtG; Mon, 11 Dec 2023 07:41:17 -0800 X-Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) by mx.groups.io with SMTP id smtpd.web10.11513.1702309276484112411 for ; Mon, 11 Dec 2023 07:41:16 -0800 X-Received: by mail-vk1-f171.google.com with SMTP id 71dfb90a1353d-4b2cc6bba61so1163695e0c.0 for ; Mon, 11 Dec 2023 07:41:16 -0800 (PST) X-Gm-Message-State: ps2U21fK6pO2O9BhtsVMRCqrx7686176AA= X-Google-Smtp-Source: AGHT+IHvidydbyFqttmW2W2K0DL+Tgev2fXwys8B4hyoK7IOHrlLozycY+veUi8CC7qbL0w/iX2/qTLVA1qCzo21oGU= X-Received: by 2002:a05:6122:888:b0:4b4:dab6:1720 with SMTP id 8-20020a056122088800b004b4dab61720mr1734259vkf.12.1702309275545; Mon, 11 Dec 2023 07:41:15 -0800 (PST) MIME-Version: 1.0 References: <20231204082950.96914-1-dhaval@rivosinc.com> <20231204082950.96914-5-dhaval@rivosinc.com> In-Reply-To: From: "Pedro Falcato" Date: Mon, 11 Dec 2023 15:41:04 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH v9 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V To: Sunil V L Cc: devel@edk2.groups.io, Dhaval Sharma , Michael D Kinney , Liming Gao , Zhiguang Liu , Laszlo Ersek Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Ia3BX0cG; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Dec 11, 2023 at 3:20=E2=80=AFPM Sunil V L wrote: > > On Mon, Dec 11, 2023 at 03:09:19PM +0000, Pedro Falcato wrote: > > On Mon, Dec 11, 2023 at 1:12=E2=80=AFPM Sunil V L wrote: > > > > > > On Sun, Dec 10, 2023 at 07:51:12PM +0530, Dhaval Sharma wrote: > > [...] > > > > nit: Can we pick a log style here? Like : > > > > In this case, "CacheOpCacheRange: Performing ...". It's just pretti= er > > > > and more greppable. > > > > My interpretation of this was removing __func__ and instead having = some > > > > relevant text would make it more searchable. > > > > And it kind of did make sense to me. I know many places __func__ is= used > > > > but this is just a perspective. > > > > > > > I think the comment meant to follow a standard logging format since > > > there was no ":" and a space in original change. I prefer __func__ ov= er > > > this so that we don't need to update multiple lines in case function > > > name gets changed. > > > > I definitely meant that __func__ should not be used for this as well. > > You can't really search for an error message if you're doing > > gratuitous printf formatting for no reason. > > Linux even has a policy where user-facing strings (i.e logs) cannot > > get broken up, even if you run out of line width. > > > Thanks Pedro. Do you mean __func__ should not be used at all in any > of logging? Or is there a case where it is allowed vs not allowed? My point is that we should aid people trying to do git grep FWIW, Linux itself uses __func__ a bunch for logs. But I personally dislike it, for the reasons stated above. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112309): https://edk2.groups.io/g/devel/message/112309 Mute This Topic: https://groups.io/mt/102967058/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-