From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6F808941571 for ; Thu, 16 Nov 2023 08:15:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=HLKe3TiTLC5xqrVVwYii8mz8oYrJ4andfeNITAUGplg=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700122526; v=1; b=r7qp3jVe5sOxFL2GSEmkS3CctWpPlLJnAAhDiUfjDVugQVHeqhzhoovk352ciBUV1O45z8Sc B1T4AzTocgs4NlmZFti8B8XiqPx+YyW7XaUY7tRNb0dQLhozVgmvlPkIvP5Ibc1mO+ZE/np3OCX 0k+YmKaVpnQLdrwijzdFXhoM= X-Received: by 127.0.0.2 with SMTP id TDZjYY7687511xxtIHELyIH3; Thu, 16 Nov 2023 00:15:26 -0800 X-Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by mx.groups.io with SMTP id smtpd.web10.2679.1700122525415030116 for ; Thu, 16 Nov 2023 00:15:25 -0800 X-Received: by mail-vs1-f47.google.com with SMTP id ada2fe7eead31-45da9f949aaso190121137.2 for ; Thu, 16 Nov 2023 00:15:25 -0800 (PST) X-Gm-Message-State: MzZEWNAozqMH8n0P6i7Iohoux7686176AA= X-Google-Smtp-Source: AGHT+IE6emKGB3ulI2Hm6ZkWXE7jWhY7JZinvyfDaO29tSCRZmFBCYOIHua6ZoJPtUtAXn9UN7ni3gfWa+JgXTMFuWU= X-Received: by 2002:a05:6102:20c7:b0:462:792d:1c7b with SMTP id i7-20020a05610220c700b00462792d1c7bmr10419vsr.18.1700122524278; Thu, 16 Nov 2023 00:15:24 -0800 (PST) MIME-Version: 1.0 References: <20231106032521.2251143-1-lichao@loongson.cn> <20231106032901.2285407-1-lichao@loongson.cn> <94637080-fb4d-44a1-9399-2b67525e4f6f@quicinc.com> In-Reply-To: <94637080-fb4d-44a1-9399-2b67525e4f6f@quicinc.com> From: "Pedro Falcato" Date: Thu, 16 Nov 2023 08:15:14 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH v2 15/30] EmbeddedPkg: Add PcdPrePiCpuIoSize width for LOONGARCH64 To: devel@edk2.groups.io, quic_llindhol@quicinc.com Cc: lichao@loongson.cn, Ard Biesheuvel , Abner Chang , Daniel Schaefer Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=r7qp3jVe; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Nov 15, 2023 at 6:55=E2=80=AFPM Leif Lindholm wrote: > > On 2023-11-06 03:29, Chao Li wrote: > > Added LoongArch64 architecture CPU IO width. > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4584 > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Abner Chang > > Cc: Daniel Schaefer > > Signed-off-by: Chao Li > > Reviewed-by: Leif Lindholm > > I note that as a result of this we are now definining this token > individually for 5 different architectures, in order to provide two > different default values. We should probably look at consolidating > those, but that responsibility doesn't have to land on this set. > > / > Leif > > > --- > > EmbeddedPkg/EmbeddedPkg.dec | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec > > index 341ef5e6a6..241d4f3acc 100644 > > --- a/EmbeddedPkg/EmbeddedPkg.dec > > +++ b/EmbeddedPkg/EmbeddedPkg.dec > > @@ -165,6 +165,9 @@ > > [PcdsFixedAtBuild.X64] > > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16|UINT8|0x00000011 > > > > +[PcdsFixedAtBuild.LOONGARCH64] > > + gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16|UINT8|0x00000011 > > + Leif, Can you clarify the meaning of PcdPrePiCpuIoSize? I was thinking it's supposed to be the size of the port-mapped IO for the architecture/platform (as hinted by in X64 =3D IA32 =3D 16, and ARM=3D0), but from a quick git grep I can tell that 1) most platforms define it to something else (ArmVirt defines it to 16, real platforms have a plethora of other values) 2) gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize has no internal consumer in EmbeddedPkg, but only in ArmPlatformPkg and LoongArchQemuPkg (and BeagleBoardPkg's PrePi) 3) Platform/Loongson/LoongArchQemuPkg/Loongson.dec: gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|0|UINT8|0x00010001 <-- ?? and FWIW, LoongArch does not seem to have port-mapped IO at all. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111303): https://edk2.groups.io/g/devel/message/111303 Mute This Topic: https://groups.io/mt/102413876/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-