From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0184B941EB8 for ; Thu, 30 Nov 2023 22:45:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1HtxyVi2fcSET4pbVWwOjJ1rxXN5eSmVhYf3o6YNTgg=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701384303; v=1; b=ZjrEqr5zjVVOwzI/Xq0mtlUvpnu3z8gev3vo1XRFhpzD55YKNR8ViFmmHLuYsspa9xPFeZsC IBMoHe4u/hnzYJjULc7fJ3LO8aEryHKn6Vfk5lq/n1k3hk5VVPMyc/g++MIbwE8zANeTGbQjhO3 xUhMs00Oq6EBSj2XhqU1DRHk= X-Received: by 127.0.0.2 with SMTP id af5WYY7687511x8Tnu7o8iHh; Thu, 30 Nov 2023 14:45:03 -0800 X-Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by mx.groups.io with SMTP id smtpd.web10.9404.1701384302914271887 for ; Thu, 30 Nov 2023 14:45:03 -0800 X-Received: by mail-vs1-f49.google.com with SMTP id ada2fe7eead31-46458475f2aso397530137.0 for ; Thu, 30 Nov 2023 14:45:02 -0800 (PST) X-Gm-Message-State: 7NEghARGF37gDJUDK3xC5PCZx7686176AA= X-Google-Smtp-Source: AGHT+IFosQ1d+xcqk4H5jkgliV4cLfVZ04HUHGIJIMTIHmjhiJNDJ94pqjIZF3qKPqOrS3yMjlLWxQsyeRaknP56MHE= X-Received: by 2002:a05:6102:509f:b0:45d:b2b4:59d3 with SMTP id bl31-20020a056102509f00b0045db2b459d3mr21148254vsb.23.1701384301840; Thu, 30 Nov 2023 14:45:01 -0800 (PST) MIME-Version: 1.0 References: <20231130024611.67135-1-pedro.falcato@gmail.com> <20231130024611.67135-3-pedro.falcato@gmail.com> In-Reply-To: From: "Pedro Falcato" Date: Thu, 30 Nov 2023 22:44:50 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH 2/2] MdePkg/Test: Add google tests for BaseLib To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , Savva Mitrofanov , "Gao, Liming" , "Liu, Zhiguang" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZjrEqr5z; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, Nov 30, 2023 at 9:31=E2=80=AFPM Kinney, Michael D wrote: > > Hi Pedro, > > I agree that silent failures are terrible. > > The issue is documented with the requirement to use #include here: > > https://github.com/tianocore/edk2/tree/master/UnitTestFrameworkPkg#google= test-configuration > > Unit tests are built with their own DSC configuration extensions. Does a= dding > --whole-archive to the GCC SLINK settings of the following file resolve t= he issue? > > https://github.com/tianocore/edk2/blob/master/UnitTestFrameworkPkg/UnitTe= stFrameworkPkgHost.dsc.inc Thanks for the guidance! I got it to work by changing DLINK and DLINK2. Sent out a patch set addressing that. When that goes through (hopefully), we'll be able to respin these tests without the #include hack. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111918): https://edk2.groups.io/g/devel/message/111918 Mute This Topic: https://groups.io/mt/102886794/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-