From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8A4A17803CD for ; Thu, 30 Nov 2023 02:48:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KwOj1S9U9gNrNS6JHy8ikvynXd0dKTsuSzBgRO3z2cI=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701312494; v=1; b=GhvZW7cR7y7SWmWurrp3XvHAZIdNBoCIsIIkGUDXjCdX9iCfkDc0kV0z4ngWvAikOfIr9L1j iCVNoydZ+XxfmCQOWPqd00H1KLwvDcNVniO+jPOok3jePwEql0syjz+vl9KFvLuNH3hPBj7ITzL 87X48mSMI4p9NcKb2BQjuyLo= X-Received: by 127.0.0.2 with SMTP id NoanYY7687511x40cG97T023; Wed, 29 Nov 2023 18:48:14 -0800 X-Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by mx.groups.io with SMTP id smtpd.web11.63447.1701312493709379161 for ; Wed, 29 Nov 2023 18:48:13 -0800 X-Received: by mail-ua1-f49.google.com with SMTP id a1e0cc1a2514c-7c4bcb4e890so137246241.2 for ; Wed, 29 Nov 2023 18:48:13 -0800 (PST) X-Gm-Message-State: wa97zEaUMyru5DGpZlke66Mbx7686176AA= X-Google-Smtp-Source: AGHT+IHNcy0re2LBYLCNWkEVCb+IE14lTdKXgicqdIdtbl99Fj5zPaQNq2Fpxf/mpvYTJYAH9sFnDJq/QJkQQK/oudY= X-Received: by 2002:a05:6102:c04:b0:45e:e5cc:ccb4 with SMTP id x4-20020a0561020c0400b0045ee5ccccb4mr23582913vss.28.1701312492525; Wed, 29 Nov 2023 18:48:12 -0800 (PST) MIME-Version: 1.0 References: <179C4698EAA331A7.11889@groups.io> In-Reply-To: <179C4698EAA331A7.11889@groups.io> From: "Pedro Falcato" Date: Thu, 30 Nov 2023 02:48:01 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH 0/2] MdePkg: Fix CRC16-ANSI calculation To: devel@edk2.groups.io, pedro.falcato@gmail.com Cc: Savva Mitrofanov , "Kinney, Michael D" , Liming Gao , Zhiguang Liu Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GhvZW7cR; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, Nov 30, 2023 at 2:46=E2=80=AFAM Pedro Falcato via groups.io wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4609 > > CalculateCrc16Ansi is currently miscalculating all checksums and causing > ext4 mount failures on older (~13 year old) filesystems. > > This patchset: > 1) Fixes CalculateCrc16Ansi to properly calculate checksums > This is a breaking change. > 2) Adds google test tests for BaseLib. They were immensely helpful in > making sure things were correct, while iterating quickly. > > Boot tested on a freshly baked "old filesystem" using a script[1], > and tested for further correctness using unit tests. > > [1] https://gist.github.com/heatd/6adaae8288e270897975d9321c5e8f41 > > Pedro Falcato (2): > MdePkg/BaseLib: Fix CRC16-ANSI calculation > MdePkg/Test: Add google tests for BaseLib > > MdePkg/Include/Library/BaseLib.h | 5 ++ > MdePkg/Library/BaseLib/CheckSum.c | 4 +- > .../Library/BaseLib/GoogleTestBaseLib.inf | 31 +++++++++ > .../Library/BaseLib/TestBaseLibMain.cpp | 23 +++++++ > .../Library/BaseLib/TestCheckSum.cpp | 64 +++++++++++++++++++ > .../SafeIntLibUintnIntnUnitTests64.cpp | 4 +- > MdePkg/Test/MdePkgHostTest.dsc | 5 ++ > 7 files changed, 132 insertions(+), 4 deletions(-) > create mode 100644 MdePkg/Test/GoogleTest/Library/BaseLib/GoogleTestBase= Lib.inf > create mode 100644 MdePkg/Test/GoogleTest/Library/BaseLib/TestBaseLibMai= n.cpp > create mode 100644 MdePkg/Test/GoogleTest/Library/BaseLib/TestCheckSum.c= pp > > -- > 2.43.0 whoops, dropped some CC's here, adding... --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111886): https://edk2.groups.io/g/devel/message/111886 Mute This Topic: https://groups.io/mt/102886792/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-