From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f169.google.com (mail-vk1-f169.google.com [209.85.221.169]) by mx.groups.io with SMTP id smtpd.web08.8106.1655222354000726109 for ; Tue, 14 Jun 2022 08:59:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=iD3umbLS; spf=pass (domain: gmail.com, ip: 209.85.221.169, mailfrom: pedro.falcato@gmail.com) Received: by mail-vk1-f169.google.com with SMTP id n203so4229850vke.7 for ; Tue, 14 Jun 2022 08:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JbMkNKw/1VfW54Bd6bnf3A9KlvFryy6gtuu7AW/Vflw=; b=iD3umbLSViVqNahlR17zmkbq1qJ06nABQFmxZMp/sEHA0FwQbrV3AXgSpTuvgXlegd mdr/fwpyjqcMWaMVm8WVCUw2q/gIdBi28nMmUjKxhVQViuwsldLWPBhQte9wHuC4oClB IHphBo8a+Ecq9N0KyfMtCtWDvrwdVw3W6fKNA2kXJ8k0ehbkRP4q4pNk/85VomfHo7vw 8QuYcvfDa0l/aWvL4FS4qVbB8M/P77sCesTti4LBeMJJ95wGa0Cs3A+4SWZTzG926XiQ HrKTjlUSmORS3qIK46kKnScNN7UitCmJiptY2fSjH0X60s2tTQYX2u1MSSliBA+vEE5h +Cpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JbMkNKw/1VfW54Bd6bnf3A9KlvFryy6gtuu7AW/Vflw=; b=ITgiC5ATY+Ht+a/Xu+aeAlTqKXcMRmsVrm6bF6PkUOz+P+6jH3tUXd2uipGtf8WWUi DE+6mrLC+DnvGo8wHqTCpStoJziEmy8mELE2+ixAdHXk3zTMO6HwgEzjdecUSlduVj0h AmLN0pdI7WmAoBUaZMhac1zm1rt5eUmw7sQ/Ynci5BZfaFj64nQGOIz6aR+xZyjepcV+ IHLOhEjdlPPW4brYYOqMBFKIbkkYzFNOoq387/0OKZ/RC4/HAQ/xNSCK6q0ymDlwNVBi WLLwdN1R9M2hlKZyv2xBujr4r4DxG/JSW/bY95ze3bgtnORbzao341koamovNpy5l3PA bKCw== X-Gm-Message-State: AJIora9BJLXqLe8mEz7bKRyUzrnGBjG0F44VNBxklsVwXS6gy2aNEwYd blKfRf3iYCdd85wwBI48o4vmCIay9OwVWpsuceg= X-Google-Smtp-Source: AGRyM1uvGHuY0BaRb7Xa73mvhWky8+oQF6OiKz6Lf8NRSXr6IABJ3EUELeFsr0TsfPw7GiKMamRXbvjzU4P2XdkTvxY= X-Received: by 2002:a1f:a1c6:0:b0:35e:3f6a:b8b8 with SMTP id k189-20020a1fa1c6000000b0035e3f6ab8b8mr2501295vke.26.1655222352992; Tue, 14 Jun 2022 08:59:12 -0700 (PDT) MIME-Version: 1.0 References: <20220407220146.149580-1-pedro.falcato@gmail.com> <16E9330A7A87074F.18109@groups.io> <16EE1DD8FA9A45F3.9448@groups.io> <00f801d8762d$7a24fd40$6e6ef7c0$@byosoft.com.cn> <000c01d87f8b$bf94c790$3ebe56b0$@byosoft.com.cn> In-Reply-To: <000c01d87f8b$bf94c790$3ebe56b0$@byosoft.com.cn> From: "Pedro Falcato" Date: Tue, 14 Jun 2022 16:58:58 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib To: gaoliming Cc: edk2-devel-groups-io , Leif Lindholm , Michael D Kinney , Zhiguang Liu Content-Type: multipart/alternative; boundary="0000000000005fdc9805e16a7cd3" --0000000000005fdc9805e16a7cd3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you Liming, pushed. On Tue, Jun 14, 2022 at 2:12 AM gaoliming wrote: > Pedro: > > Yes. You can merge this patch with my ACK. > > > > Thanks > > Liming > > *=E5=8F=91=E4=BB=B6=E4=BA=BA:* Pedro Falcato > *=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4:* 2022=E5=B9=B46=E6=9C=8813=E6=97= =A5 22:45 > *=E6=94=B6=E4=BB=B6=E4=BA=BA:* gaoliming > *=E6=8A=84=E9=80=81:* edk2-devel-groups-io ; Leif L= indholm < > leif@nuviainc.com>; Michael D Kinney ; > Zhiguang Liu > *=E4=B8=BB=E9=A2=98:* Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg= : Add ext2/3 > support and move crc16/32c to BaseLib > > > > Liming, > > > > Sorry for the question, but can I merge this with your Ack and my RB or d= o > I have to wait for another RB? > > I want to solve this as soon as possible since right now Ext4Pkg won't > build with upstream edk2. > > > > Thanks, > > Pedro > > > > On Thu, Jun 2, 2022 at 4:05 AM gaoliming wrote= : > > Pedro=EF=BC=9A > > Thanks for your enhancement to support ext2/3 file system. Acked-by: > Liming Gao for this patch set. > > > > Thanks > > Liming > > *=E5=8F=91=E4=BB=B6=E4=BA=BA:* Pedro Falcato > *=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4:* 2022=E5=B9=B46=E6=9C=881=E6=97=A5= 5:33 > *=E6=94=B6=E4=BB=B6=E4=BA=BA:* edk2-devel-groups-io ; Pedro Falcato < > pedro.falcato@gmail.com> > *=E6=8A=84=E9=80=81:* Leif Lindholm ; Michael D Kinney= < > michael.d.kinney@intel.com>; Liming Gao ; > Zhiguang Liu > *=E4=B8=BB=E9=A2=98:* Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg= : Add ext2/3 > support and move crc16/32c to BaseLib > > > > Ping. Please review now that the stable freeze is over. > > > > On Wed, May 11, 2022 at 6:42 PM Pedro Falcato via groups.io > wrote: > > Ping. Could someone review these patches? > > > > On Mon, Apr 25, 2022 at 6:14 PM Pedro Falcato via groups.io > wrote: > > Ping. If someone could take a look, it would be much appreciated. > > > > On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato > wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3745 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3871 > > Hi all, > > This patch-set attempts to address two open feature requests for Ext4Pkg > by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to BaseLi= b > (id 3871). > > The previous patch-set regarding 3871 attempted to merge the different > crc16 implementations > but failed because, contrary to what I thought, there are many, many > different CRC16s which > are all slightly different. This one (plus the separate edk2 patch) > attempts to just merge > CRC16-ANSI (confusingly, also known as CRC16) into BaseLib. > > Since this patch set grew to be considerably different from the original, > I didn't mark it > as v2 but rather a separate, new patch-set. > > CC'ing the edk2-platforms stewards (as I cannot review my own code) and > the CC's of the MdePkg > patch. > > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > > Pedro Falcato (3): > Ext4Pkg: Replace the CRC implementations with BaseLib > Ext4Pkg: Format using uncrustify > Ext4Pkg: Add ext2/3 support > > Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 10 +- > Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 279 +++++++++++++++++ > Features/Ext4Pkg/Ext4Dxe/Collation.c | 4 +- > Features/Ext4Pkg/Ext4Dxe/Crc16.c | 75 ----- > Features/Ext4Pkg/Ext4Dxe/Crc32c.c | 84 ------ > Features/Ext4Pkg/Ext4Dxe/Directory.c | 13 +- > Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 6 +- > Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 30 +- > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 95 +++--- > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 417 ++++++++++++++------------ > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 3 +- > Features/Ext4Pkg/Ext4Dxe/Extents.c | 27 +- > Features/Ext4Pkg/Ext4Dxe/File.c | 19 +- > Features/Ext4Pkg/Ext4Dxe/Inode.c | 33 +- > Features/Ext4Pkg/Ext4Dxe/Partition.c | 12 +- > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 20 +- > 16 files changed, 640 insertions(+), 487 deletions(-) > create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c > delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c > delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c > > -- > 2.35.1 > > > > -- > > Pedro Falcato > > > > -- > > Pedro Falcato > >=20 > > > > -- > > Pedro Falcato > > > > -- > > Pedro Falcato > --=20 Pedro Falcato --0000000000005fdc9805e16a7cd3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you Liming, pushed.

On Tue, Jun 14, 2022 at 2:12 = AM gaoliming <gaoliming@byos= oft.com.cn> wrote:

Pedro:

=C2=A0Yes. You can merge this patch with my ACK.<= u>

=C2=A0<= u>

Thanks<= u>

Liming<= span style=3D"font-size:10.5pt;font-family:=E7=AD=89=E7=BA=BF" lang=3D"EN-U= S">

=E5=8F= =91=E4=BB=B6=E4=BA=BA: Pedro Falca= to <pedro.f= alcato@gmail.com>
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B46=E6=9C=88= 13=E6=97=A5 22:45
=E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming <gaoliming@byosoft.com.cn>
=E6=8A=84=E9=80= =81: edk2-devel-groups= -io <devel@edk= 2.groups.io>; Leif Lindholm <leif@nuviainc.com>; Michael D Kinney <michael.d.kinney@i= ntel.com>; Zhiguang Liu <zhiguang.liu@intel.com>
=E4=B8=BB= =E9=A2=98: Re: [edk2-d= evel] [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16= /32c to BaseLib

=C2=A0

Liming,

=C2=A0

Sorry for the = question, but can I merge this with your Ack and my RB or do I have to wait= for another RB?

= I want to solve this as soon as possible since right n= ow Ext4Pkg won't build with upstream edk2.

=C2=A0

Thanks,

P= edro

=C2=A0

= On Thu, Jun 2, 2022 at 4:05 AM gaoliming <gaoliming@byosoft.co= m.cn> wrote:

Pedro=EF=BC=9A

=C2=A0Thanks for your enhancement to support ext2/3 fil= e system. Acked-by: Liming Gao <gaoliming@byosoft.com.cn> for this patch set. =

=C2=A0

Thanks

Liming

=E5=8F=91=E4=BB=B6=E4=BA=BA: Pedro Falcato <pedro.falcato@gmail.com>
=E5=8F=91=E9=80=81=E6=97= =B6=E9=97=B4: 2022=E5=B9=B46=E6=9C=881=E6=97=A5 5:33
=E6=94=B6=E4=BB=B6=E4=BA=BA: edk2-devel-groups-io <devel@edk2.groups.io>; = Pedro Falcato <pedro.falcato@gmail.com>
=E6=8A=84=E9=80=81: Leif Lindholm <leif@nuviainc.com>; Mic= hael D Kinney <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn&g= t;; Zhiguang Liu <zhiguang.liu@intel.com>
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH edk= 2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib<= /span>

=C2=A0

Ping. Please review now that t= he stable freeze is over.

=C2=A0

On Wed, May 11, 2022 at 6:42 PM Pedro F= alcato via groups.io <= ;pedro.falcato=3Dg= mail.com@groups.io> wrote:

Ping. Could someone review these patches?

=C2=A0=

On Mon, Apr 25, 2022 at 6:14 PM Pedro Falcato via groups.io <pedro.falcato=3Dgmail.com@groups.io> wrote:

Ping. If s= omeone could take a look, it would be much appreciated.

=C2=A0=

On Thu, Ap= r 7, 2022 at 11:01 PM Pedro Falcato <pedro.falcato@gmail.com> wrote:<= /u>

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3745=
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3871<= br>
Hi all,

This patch-set attempts to address two open feature r= equests for Ext4Pkg
by adding ext2/3 support (id 3745) and moving crc16-= ansi/crc32c to BaseLib (id 3871).

The previous patch-set regarding 3= 871 attempted to merge the different crc16 implementations
but failed be= cause, contrary to what I thought, there are many, many different CRC16s wh= ich
are all slightly different. This one (plus the separate edk2 patch) = attempts to just merge
CRC16-ANSI (confusingly, also known as CRC16) int= o BaseLib.

Since this patch set grew to be considerably different fr= om the original, I didn't mark it
as v2 but rather a separate, new p= atch-set.

CC'ing the edk2-platforms stewards (as I cannot review= my own code) and the CC's of the MdePkg
patch.

Cc: Leif Lind= holm <leif@nuviai= nc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: L= iming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Pedro Falcato (3):
=C2=A0 Ext4Pkg: Replace the CRC implementations= with BaseLib
=C2=A0 Ext4Pkg: Format using uncrustify
=C2=A0 Ext4Pkg:= Add ext2/3 support

=C2=A0Features/Ext4Pkg/Ext4Dxe/BlockGroup.c |=C2= =A0 10 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/BlockMap.c=C2=A0 =C2=A0| 279 ++= +++++++++++++++
=C2=A0Features/Ext4Pkg/Ext4Dxe/Collation.c=C2=A0 |=C2=A0= =C2=A04 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Crc16.c=C2=A0 =C2=A0 =C2=A0 |= =C2=A0 75 -----
=C2=A0Features/Ext4Pkg/Ext4Dxe/Crc32c.c=C2=A0 =C2=A0 =C2= =A0|=C2=A0 84 ------
=C2=A0Features/Ext4Pkg/Ext4Dxe/Directory.c=C2=A0 |= =C2=A0 13 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/DiskUtil.c=C2=A0 =C2=A0|=C2= =A0 =C2=A06 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h=C2=A0 =C2=A0|= =C2=A0 30 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c=C2=A0 =C2=A0 |=C2= =A0 95 +++---
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h=C2=A0 =C2=A0 | 41= 7 ++++++++++++++------------
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf= =C2=A0 |=C2=A0 =C2=A03 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Extents.c=C2=A0= =C2=A0 |=C2=A0 27 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/File.c=C2=A0 =C2=A0= =C2=A0 =C2=A0|=C2=A0 19 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Inode.c=C2=A0= =C2=A0 =C2=A0 |=C2=A0 33 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Partition.c= =C2=A0 |=C2=A0 12 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Superblock.c |=C2=A0= 20 +-
=C2=A016 files changed, 640 insertions(+), 487 deletions(-)
= =C2=A0create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c
=C2=A0delet= e mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c
=C2=A0delete mode 100644 = Features/Ext4Pkg/Ext4Dxe/Crc32c.c

--
2.35.1=



--

= Pedro Falcato



--

Pedro Falcato


<= br>--

Pedro Falcato



--

= Pedro Falcato



--
Pedro Falcato
--0000000000005fdc9805e16a7cd3--