Re: [edk2-devel] [PATCH v2 0/7] edksetup.bat, BaseTools: Improve Windows environment setup and BaseTools C compilation

["Pedro Falcato" <pedro.falcato@gmail.com>]

On Sat, May 6, 2023 at 6:24 PM Rebecca Cran <rebecca@bsdio.com> wrote:
>
> There are remnants of Python 2 support in BaseTools/toolsetup.bat that it's
> probably time to remove since we only support Python 3.6 and newer these days.
> So, remove the variables that enable Python3 support and simplify the batch
> script. I've also seen errors where after running edksetup.bat the build
> command isn't available because PYTHONPATH wasn't being set, so fix that
> when the Pip BaseTools are being used.
>
> At the same time, let's add a check that we meet the minimum version
> requirement so we don't end up failing with an obscure error.
>
> Building BaseTools causes a warning about threading.currentThread being
> deprecated, so update code in NmakeSubdirs.py to switch to
> threading.current_thread.
>
> There needs to be further work, because if PYTHON_COMMAND isn't specified then
> it defaults to "py -3", where py is C:\Windows\py.exe, which doesn't work if
> you're using a virtualenv since it installs python.exe and pythonw.exe in
> venv\Scripts. toolsetup.bat therefore fails to detect the Pip BaseTools and
> uses the in-source Basetools.
>
> GitHub PR: https://github.com/tianocore/edk2/pull/4302
> GitHub branch: https://github.com/bcran/edk2/tree/py3
>
> Changes between v1 and v2
> =========================
>
> - Require Python 3.6 or newer: 3.6 was when PEP 526 was added, which we use.
> - Fix Tests/RunTests.py on Windows.
>
> Dongyan Qian (1):
>   BaseSynchronizationLib: Fix LoongArch64 synchronization functions
>
> Gerd Hoffmann (2):
>   OvmfPkg: move OvmfTpmPei.fdf.inc to Include/Fdf
>   OvmfPkg: move OvmfTpmDxe.fdf.inc to Include/Fdf

Why did you pick these up? Accident?

-- 
Pedro