From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mx.groups.io with SMTP id smtpd.web11.40613.1683400598685922947 for ; Sat, 06 May 2023 12:16:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20221208 header.b=M12YgAMj; spf=pass (domain: gmail.com, ip: 209.85.216.47, mailfrom: pedro.falcato@gmail.com) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-24de3a8bfcfso2893368a91.1 for ; Sat, 06 May 2023 12:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683400598; x=1685992598; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qBuf+LND4XjAKm3CmIdZrmHPbd9f7uD//A/VhAGmwv4=; b=M12YgAMjkNq5dCwHYXXLm6fVkRq0WPV3jdksvDN6SsHdLu8Utx+6dSHidbfMHP/ax4 3SLJvELvWppNRwTFshFVIweyRh51rNAwVW8+4FUzkgeMdN1PzONG8rxazOGDmub3VAHY CB573UpmFbcdI6cm2DgbQhG4JKRhAIhWI9DZGXpyUyCX3C9FTevxwchxsa9NVQTvhh3B 0QU4iCPEca8MKJ6jKw/k84o42caNc7AlI78KuQ62rXPMRfVBnwjRoIVkalyy0U0wdlmY JEoMcUSRc8ZU3QvxZrQHg0DURy96boawae3Qy7iyFX2eBRTipsH049ef94yyL97EHE3x phbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683400598; x=1685992598; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qBuf+LND4XjAKm3CmIdZrmHPbd9f7uD//A/VhAGmwv4=; b=iR11koBQils9OoaNBfE/VRCXBdHoVVhrTYFFqwIzdKg1bMJeL/pzU75FxT4SAAYw6h rnyFzCT3JaLg7VUgw1+ab5iHDdjcuV9uQcPJFVKDLmuFfyPea/SrNUR1CH36SiIyGGy1 LZUo5xRkX1FIyhB42TnIx04v6Llff3Z7EZ3sT4Zzon8PBxK40mDqtu9KIa1Gt7bx2Ryl lYB2pC31jY243yRoXIQ2Z1ExdIUoaqahz+WWmwkZpWSJR5O5j8RyhMl8c3G2RWBYVbeI X8ooil5/VvZ8yDXRPOSZ1eD1AZkECf0OybIgzMUq1lkjucnqEcRWMOXf+kZ4EsfS2Gzs 01mg== X-Gm-Message-State: AC+VfDxPdBu/YWyaPhOlquw/PEITjOB5GjCvPqrlOyLFwGIxQFZ7+5Ff HziNgh89EYiBgHO5bGkZNI2qs5ceV8buTmVHv+HotfZO73BJaA== X-Google-Smtp-Source: ACHHUZ5h+otXYIkkcCpUy5g5l1pYE+joan5aQxy4yGguu7Br9fBt6XUL2hGttRzehPY+2yd7+xrTOzPPn5dxI8545r4= X-Received: by 2002:a17:90b:1e4b:b0:24e:1f5:2e05 with SMTP id pi11-20020a17090b1e4b00b0024e01f52e05mr5770142pjb.13.1683400597858; Sat, 06 May 2023 12:16:37 -0700 (PDT) MIME-Version: 1.0 References: <20230506172402.116-1-rebecca@bsdio.com> In-Reply-To: <20230506172402.116-1-rebecca@bsdio.com> From: "Pedro Falcato" Date: Sat, 6 May 2023 20:16:26 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH v2 0/7] edksetup.bat, BaseTools: Improve Windows environment setup and BaseTools C compilation To: devel@edk2.groups.io, rebecca@bsdio.com Cc: Andrew Fish , Leif Lindholm , Michael D Kinney , Liming Gao , Bob Feng , Yuwei Chen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, May 6, 2023 at 6:24=E2=80=AFPM Rebecca Cran wro= te: > > There are remnants of Python 2 support in BaseTools/toolsetup.bat that it= 's > probably time to remove since we only support Python 3.6 and newer these = days. > So, remove the variables that enable Python3 support and simplify the bat= ch > script. I've also seen errors where after running edksetup.bat the build > command isn't available because PYTHONPATH wasn't being set, so fix that > when the Pip BaseTools are being used. > > At the same time, let's add a check that we meet the minimum version > requirement so we don't end up failing with an obscure error. > > Building BaseTools causes a warning about threading.currentThread being > deprecated, so update code in NmakeSubdirs.py to switch to > threading.current_thread. > > There needs to be further work, because if PYTHON_COMMAND isn't specified= then > it defaults to "py -3", where py is C:\Windows\py.exe, which doesn't work= if > you're using a virtualenv since it installs python.exe and pythonw.exe in > venv\Scripts. toolsetup.bat therefore fails to detect the Pip BaseTools a= nd > uses the in-source Basetools. > > GitHub PR: https://github.com/tianocore/edk2/pull/4302 > GitHub branch: https://github.com/bcran/edk2/tree/py3 > > Changes between v1 and v2 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > > - Require Python 3.6 or newer: 3.6 was when PEP 526 was added, which we u= se. > - Fix Tests/RunTests.py on Windows. > > Dongyan Qian (1): > BaseSynchronizationLib: Fix LoongArch64 synchronization functions > > Gerd Hoffmann (2): > OvmfPkg: move OvmfTpmPei.fdf.inc to Include/Fdf > OvmfPkg: move OvmfTpmDxe.fdf.inc to Include/Fdf Why did you pick these up? Accident? --=20 Pedro