From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mx.groups.io with SMTP id smtpd.web11.102701.1674828575228058047 for ; Fri, 27 Jan 2023 06:09:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=h8dV+K7G; spf=pass (domain: gmail.com, ip: 209.85.216.47, mailfrom: pedro.falcato@gmail.com) Received: by mail-pj1-f47.google.com with SMTP id rm7-20020a17090b3ec700b0022c05558d22so4943774pjb.5 for ; Fri, 27 Jan 2023 06:09:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YlpJoKbQ54hXzzcmGCAAndl93cf/blHuSY591IgsEK0=; b=h8dV+K7GXAd6nNH/p4gjOS+P17t4hbBiy6b/C8h59MlvRPm3eEVLSGamQKKGqMZrwy 0CyvADikOaBaV17iwG8XGn35EWxT7EL8Sxr1vhnlTEqNOdiysqvI7cfRugN6SYCBwKK2 lAZSnw/5OFYNO0uZFLrnZzZ5pTuftAMWmL52xtjxfFpdfHV/Y5FNcHw5igJcAZytiaES IHoXsCFTFmC+BGFv2YhE8x015aN8RdHULkyZ7gJ6yi8CScUXalz5V5tf49fyMiSPICxN fp8b5WcrMoJlXyasSmFCjJGv49sdEFH5cYhpsEPCyxhmltf233pibvhzVTvKRHjVvNBt y++A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YlpJoKbQ54hXzzcmGCAAndl93cf/blHuSY591IgsEK0=; b=Ouf8U0XoDh69Jon+/HsGV/RXGh8JFt5vuIFxeaY2Jw0zPFF5xgnedv1qhvxVXquREv ALx4PIv9RjlNPqnvQ2k3iHT8giAW/+vbTkMKmyp6PV5cq6SvlVshF5XqDpdPBBc0+VV+ hcgABUivpU/WcsRsXHrc7ra5RojAKi05seCYPUQ6yTeVufhVp2CNBVfSDleUmj9qL8aa Wl7y3Yg7xytjK8EeT7rIBWB7QFjNCltjhaasvRvZb1bRgIHkw6btOujyBCzgfRE9cNZE zBl5jYYj9j6lx91AYVC/Hg4C9f5fUsTzK0Qm84V97tw9bKvC1QHi9dCG5BLIqade2hrP p0WQ== X-Gm-Message-State: AO0yUKVxg4iFlpl3FRJVpuyL2HFIpL3wN4GdbnHOCvqBGz0QYN07ayvE g3bMfNkR+TOMSfS3QYzTRYb7+fv1yLm7Sm2R3LY= X-Google-Smtp-Source: AK7set//FNHcp5Gf4RULXlKWbJ8d1IuCafvJuWd9O6dt892rQ0oMINHXgpOXmnqbL+7nKcjGtGTi1L9t1g66sQ+T6/k= X-Received: by 2002:a17:903:41cd:b0:196:237f:164d with SMTP id u13-20020a17090341cd00b00196237f164dmr1491402ple.14.1674828574613; Fri, 27 Jan 2023 06:09:34 -0800 (PST) MIME-Version: 1.0 References: <20230127092945.94389-1-savvamtr@gmail.com> <20230127092945.94389-12-savvamtr@gmail.com> In-Reply-To: From: "Pedro Falcato" Date: Fri, 27 Jan 2023 14:09:23 +0000 Message-ID: Subject: Re: [edk2-platforms][PATCH v3 11/11] Ext4Pkg: Filter out directory entry names containing \0 as invalid To: =?UTF-8?Q?Marvin_H=C3=A4user?= Cc: Savva Mitrofanov , edk2-devel-groups-io , Vitaly Cheptsov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 27, 2023 at 10:04 AM Marvin H=C3=A4user wr= ote: > > On 27. Jan 2023, at 10:29, Savva Mitrofanov wrote: > > > > The directory entry name conventions forbid having null-terminator > > symbols in its body and can lead to undefined behavior conditions > > and crashes > > > > Cc: Marvin H=C3=A4user > > Cc: Pedro Falcato > > Cc: Vitaly Cheptsov > > Fixes: 89b2bb0db263 ("Ext4Pkg: Fix and clarify handling regarding non-u= tf8 dir entries") > > Signed-off-by: Savva Mitrofanov > > --- > > Features/Ext4Pkg/Ext4Dxe/Directory.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/Features/Ext4Pkg/Ext4Dxe/Directory.c b/Features/Ext4Pkg/Ex= t4Dxe/Directory.c > > index 0753a20b5377..465749c9b51d 100644 > > --- a/Features/Ext4Pkg/Ext4Dxe/Directory.c > > +++ b/Features/Ext4Pkg/Ext4Dxe/Directory.c > > @@ -28,9 +28,16 @@ Ext4GetUcs2DirentName ( > > { > > CHAR8 Utf8NameBuf[EXT4_NAME_MAX + 1]; > > UINT16 *Str; > > + UINTN Index; > > I *really* do not like UINTN in code that does not deal with buffer addre= sses and sizes. I'd change it to UINT8, but I'll leave it up to Pedro. Considering this is a size (length of name) and it gets explicitly bounded by name_len (a UINT8) I'm okay with it. But if for some reason you need to submit a v4, please change. Reviewed-by: Pedro Falcato --=20 Pedro