From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: "Marvin Häuser" <mhaeuser@posteo.de>
Cc: Ard Biesheuvel <ardb@kernel.org>,
edk2-devel-groups-io <devel@edk2.groups.io>
Subject: Re: [PATCH 1/1] Ext4Pkg: Move unicode collation initialization to Start()
Date: Fri, 24 Feb 2023 00:34:35 +0000 [thread overview]
Message-ID: <CAKbZUD0xXfv+pqGsjL_t1XU=xN+qQ2_fGj-Noe5g-jwz1gCE9w@mail.gmail.com> (raw)
In-Reply-To: <91E4C588-DC5F-454B-818B-6875A2826CFE@posteo.de>
On Tue, Feb 21, 2023 at 7:37 PM Marvin Häuser <mhaeuser@posteo.de> wrote:
>
>
> On 21. Feb 2023, at 20:25, Pedro Falcato <pedro.falcato@gmail.com> wrote:
>
> Marvin,
>
> Do you want me to spin up a quick v2 without the
> Ext4IsCollationInitialized? Just doing the check internally in
> Ext4InitialiseUnicodeCollation.
>
>
> It'd be my preferred solution, but it's just a detail.
>
> Reviewed-by: Marvin Häuser <mhaeuser@posteo.de> in any case
>
>
> --
> Pedro
>
>
Fixed it up on my end and removed the unanimously-odd
Ext4IsCollationInitialized.
Pushed as 54306d0.
Thank you both for the bug report and reviews!
--
Pedro
prev parent reply other threads:[~2023-02-24 0:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 20:14 [PATCH 1/1] Ext4Pkg: Move unicode collation initialization to Start() Pedro Falcato
2023-02-18 12:30 ` Marvin Häuser
2023-02-18 15:14 ` Pedro Falcato
2023-02-18 17:04 ` Marvin Häuser
2023-02-20 7:52 ` Ard Biesheuvel
2023-02-20 8:00 ` Marvin Häuser
2023-02-21 19:25 ` Pedro Falcato
2023-02-21 19:37 ` Marvin Häuser
2023-02-24 0:34 ` Pedro Falcato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKbZUD0xXfv+pqGsjL_t1XU=xN+qQ2_fGj-Noe5g-jwz1gCE9w@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox