From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mx.groups.io with SMTP id smtpd.web11.6392.1677198886939973714 for ; Thu, 23 Feb 2023 16:34:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=mLBYN9i9; spf=pass (domain: gmail.com, ip: 209.85.214.180, mailfrom: pedro.falcato@gmail.com) Received: by mail-pl1-f180.google.com with SMTP id e5so16097077plg.8 for ; Thu, 23 Feb 2023 16:34:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NbdO3CDBqLbe//m3jHDqVkYc/UlprNaaBLoz2PeZMTY=; b=mLBYN9i9D5ldjk7CGHyeuzhH3jUNxXTeN3eQiY7wSqMHhEdSts0qZ9dq86kl+VO5ro fIcKv04oYZzBEfJ2me0ab4d3TfNgCiz2VVrliacCLl+wiYI1lcIU56gPW22t2bc5vbKF CjXcoKLilPEw0gJWxqPfItPnKIik0NXmr9ZWoLd7T/KvXqTdvYRjAXdKYLtuyRHU0loS kfRHxi/kRW6Q811WrkWoOjt2aT9dJpnHWT5mLJupo6DlhAEPHgs0xLvRfFoTw3DeK3+E IM/C+k8Efv3T4emGko07AJkElTPbBY2P5JR2rT8Awru9RF+Ngrs4W4vwdZ1utStnN2+u s4rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NbdO3CDBqLbe//m3jHDqVkYc/UlprNaaBLoz2PeZMTY=; b=2V/x/tjAGr914WFmvvKxGc/D4RFnq/72TmXleeUa83I/VzyVFWzxU8UGEqygYei9ho 2CZBDK1o+S2scswwosFwBODL8pq9gd6pXgHHS+tJZ0fhalbrIe5cHEqufZFjwzuJD2xY 1cnF9ZhyhAPb7qevTPEsvSvsfTfmLikMEdMlCHzY6MFADkaioxQk24h8GaHWkeJhG/fF k3oBHmIEuGCANEADdxcoLfOYzzqt1URtNX6b21hSIAQ5bHsvno8fA7MiZnppYZdf7VGF qFlANo1edhyafT8fR9eTCgdD1MBgRwfJzPxA4dtLsaNLPKd/3wtMGfWM6LZekllBG0RY 5Snw== X-Gm-Message-State: AO0yUKW8GwyGkOMG9jpdTc03l2adxkxVvu75gTEDh8eSzxnwVh7nbIn9 BsGn29Tu9BmJpAl6o1OMxBa7XusvUIvltSkakE4= X-Google-Smtp-Source: AK7set8hbtz4LInh9TYhjzu1fKPpLvKc/FbiTmG1vvZiWJ6tBXn6IkCz2T8k9ygkO1vY9UBkGCeDRHsg6r38x/AxhlE= X-Received: by 2002:a17:90b:46c3:b0:234:b23:eade with SMTP id jx3-20020a17090b46c300b002340b23eademr1037485pjb.9.1677198886211; Thu, 23 Feb 2023 16:34:46 -0800 (PST) MIME-Version: 1.0 References: <549E455D-0A81-40BB-A944-9F79EE17248F@posteo.de> <91E4C588-DC5F-454B-818B-6875A2826CFE@posteo.de> In-Reply-To: <91E4C588-DC5F-454B-818B-6875A2826CFE@posteo.de> From: "Pedro Falcato" Date: Fri, 24 Feb 2023 00:34:35 +0000 Message-ID: Subject: Re: [PATCH 1/1] Ext4Pkg: Move unicode collation initialization to Start() To: =?UTF-8?Q?Marvin_H=C3=A4user?= Cc: Ard Biesheuvel , edk2-devel-groups-io Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 21, 2023 at 7:37 PM Marvin H=C3=A4user wro= te: > > > On 21. Feb 2023, at 20:25, Pedro Falcato wrote: > > Marvin, > > Do you want me to spin up a quick v2 without the > Ext4IsCollationInitialized? Just doing the check internally in > Ext4InitialiseUnicodeCollation. > > > It'd be my preferred solution, but it's just a detail. > > Reviewed-by: Marvin H=C3=A4user in any case > > > -- > Pedro > > Fixed it up on my end and removed the unanimously-odd Ext4IsCollationInitialized. Pushed as 54306d0. Thank you both for the bug report and reviews! --=20 Pedro