From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9D806941B62 for ; Sun, 29 Oct 2023 19:15:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=aBWNyttjqBJ138ah/SxrVYorOr//ys7xZfswj0FJFt0=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698606927; v=1; b=eBQpaoeNllbYHSWoNzORkwc/jLL/le3A/r8HoImUvsfYE/umyG1FguBjjV0oOjlfylX/BARc 3k5mtTnDiSjnJgCisw1u3NDO67Lc0G3QvwSCexDi4yecBoQXxUY8mGY0f7cz42SMQRMv9b8shd2 or4KRAhB1eIyNhvPJlkGaQ6o= X-Received: by 127.0.0.2 with SMTP id 5gcAYY7687511x8HIqWhO1mC; Sun, 29 Oct 2023 12:15:27 -0700 X-Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by mx.groups.io with SMTP id smtpd.web10.78612.1698606926672004010 for ; Sun, 29 Oct 2023 12:15:26 -0700 X-Received: by mail-vs1-f54.google.com with SMTP id ada2fe7eead31-45b653c29faso362981137.0 for ; Sun, 29 Oct 2023 12:15:26 -0700 (PDT) X-Gm-Message-State: OATPszPxZNUtuG5I4E5H8DsQx7686176AA= X-Google-Smtp-Source: AGHT+IERxtogPtpfk5II9hF1gW9S5JrJ5wiVb1lN72FvK8dgGdK7rI633yCG72dHqp/hZ1p7Y/1Ut4udxe7+vKWaUJc= X-Received: by 2002:a67:e08c:0:b0:45a:b096:ec80 with SMTP id f12-20020a67e08c000000b0045ab096ec80mr6774725vsl.31.1698606925422; Sun, 29 Oct 2023 12:15:25 -0700 (PDT) MIME-Version: 1.0 References: <20231029144613.150580-1-dhaval@rivosinc.com> In-Reply-To: <20231029144613.150580-1-dhaval@rivosinc.com> From: "Pedro Falcato" Date: Sun, 29 Oct 2023 19:15:14 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH v7 0/5] Cache Management Operations Support For RISC-V To: devel@edk2.groups.io, dhaval@rivosinc.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Sunil V L , Andrei Warkentin , Laszlo Ersek , Michael D Kinney , Liming Gao , Zhiguang Liu , Daniel Schaefer Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=eBQpaoeN; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Sun, Oct 29, 2023 at 2:46=E2=80=AFPM Dhaval Sharma = wrote: > > Implementing code to support Cache Management Operations (CMO) defined by > RISC-V CMO instructions.https://github.com/riscv/riscv-CMOs > This is a re-write of original series v5. > The patchset contains 5 patches- created based on V5 feedback. > 1. Restructuring of existing code and move instruction declarations into = BaseLib > 2. Renaming existing functions to denote type of instruction used to maan= age cache. > This is useful for further patches where more cache management instruc= tions are added. > 3. Add the new cache maintenance operations to BaseLib, including the > new assembly instruction encodings. > 4. Update BaseCacheMaintenanceLib (utilizing the new BaseLib primitives) > 5. Add platform level PCD to allow overriding of RISC-V features. > With or without nits fixed: Reviewed-by: Pedro Falcato But I would *really* prefer it if you could test this on a real board with this extension. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110277): https://edk2.groups.io/g/devel/message/110277 Mute This Topic: https://groups.io/mt/102256459/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-